Received-SPF: pass (google.com: domain of linux-kernel+bounces-199759-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 3 Jun 2024 19:15:07 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ard Biesheuvel <ardb@kernel.org>, linux-kernel@vger.kernel.org,
	patches@lists.linux.dev,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] sysfs: Add stub sysfs_bin_attr_simple_read() for
 !CONFIG_SYSFS
Message-ID: <20240603221507.GC19897@nvidia.com>
References: <0-v1-44baae71b833+ab-sysfs_simple_read_jgg@nvidia.com>
 <Zl4rqswlbGM-eRY6@wunner.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zl4rqswlbGM-eRY6@wunner.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RvIQxTANPfn5MG19zgYZJ/LB7kzjbPyEt3LKfCSZFhv0u92HvM5Bm8JFkDSE?=
 =?us-ascii?Q?Rsic3+8r2eNlI7KrfMx7yz6B147+j2gWfWDtvQ14lJGNXntBLUDgE0KM/Gr7?=
 =?us-ascii?Q?UC7S+6rw+46QFjsYMpknhqNzKEEDreMGljaLRmnAigQkMsbCu/HjlvcalEKG?=
 =?us-ascii?Q?MJaQMEHgWSVoMAQqFeKqSTSdoPFAxEMXGS4oXcZfOZyETFHgPmlekL4Z69zw?=
 =?us-ascii?Q?4v5B3hXAHuakf0zUo4IlNyDqWvuOnF5qf3QGPvsqWLrkch1amTP2sGtYJGke?=
 =?us-ascii?Q?jebQ2n3kBkfByTkOY/uW7Y+3aPbF3tX70z+EeVsU+cGkzHiMxow2dVkOIcFD?=
 =?us-ascii?Q?MOckp1h/uNZP5yhsUzGROWDC5+FHlCVzDwDvZQ0Do/0ET0DsXWobJ6EGefaQ?=
 =?us-ascii?Q?etIsdQ6QDCtjUIzNmnmBi1AbhVb2nYr/ylPMuJmg2GCMRpJLMnlF82lK+6K8?=
 =?us-ascii?Q?dAb9w9ia9slHYYi45ZodjjBuBEVELoWiT+SKh5mbhpRzI3Ys9HHTiRNI4U9D?=
 =?us-ascii?Q?zKAWu32sUWbpr08KgzgdYdGc8i5Qo1W5va3SdDaFZBAS0wwSWrHPMCz/57bp?=
 =?us-ascii?Q?7Tdr1Hdt3NRiFqlb+98wt+SqOrVXfU6MC3XA/jwSXbvkmg3KA36Xldc7tTv0?=
 =?us-ascii?Q?U2UfxV6famxbJUdvbzLwJT28peywvvL22qZ7ZNeNR13oUtxDJ0HVAaqcqkwP?=
 =?us-ascii?Q?BLkI7tJILDgQvqScicM0t7tJFcVibQqF/toq1ypmR/YMYz/P0gcra3MlASsl?=
 =?us-ascii?Q?X5vhAwC0u4DfPfFEtCM+4X7/8ivvFN9dWarX4rXosNP3xkO1P5P47A24+kQy?=
 =?us-ascii?Q?dmKbGpqfw5gvMZE+VVHfBq4iPW2rW/n+pcuVMCaM8fucn+6d4RtGf4a07gLu?=
 =?us-ascii?Q?SrVFFV2nWJPVLbvn/2HDSxo/BsYr2F3eOhmrD9ntp5MIqN2t7FkSg2L3lkWT?=
 =?us-ascii?Q?ZC9b6U6MGc2n4Jq4LTI7jl726MeWsOmercBJJqiYpn1NrKv6kuIuNVP2kt6B?=
 =?us-ascii?Q?kAXopPyU9Ez0+vMHddZZLkSA4MjXcmSeXyXoqPZuHmb1xrsF8TkJvD7oK49U?=
 =?us-ascii?Q?/1+7kTYSmGrKmp3HG+YSZbSEzDKqBoNkfUGTYF5OFHeA2Pevy4l2eKxWzNBw?=
 =?us-ascii?Q?Dda4n+V7iKDZ8DiEVis05l07mV/o8MHdGaOCvcRwbZAlCVb0e3755wampqmB?=
 =?us-ascii?Q?I4z9Fa5qncQlEtBoLJL9Wvc/1DUBdutRxuUylZC5Wupgv6W1IjTwTIqerU+g?=
 =?us-ascii?Q?IclHcVzbVFvfZ49Sxft0p7BLWf7qe6/E6Yo0L6+a6GAaGPu5gjkiG9GYaWXr?=
 =?us-ascii?Q?Elp9Csm05XHYT95QdB1CHJ6rjisa6i0wbxKS7PnXDSCeZcG4KbDxSaIQs38S?=
 =?us-ascii?Q?RySRo7AM3ZaABImY6BlWeB9NMx1CubqbOw2Gnhvm9Y6NjqEHVCHaKVX7j/R1?=
 =?us-ascii?Q?gouNoT8VQvNgA0qZlQvtGDn28p+U/NB7UtdAR19fbE6cJqzrOasIE2BZMSHC?=
 =?us-ascii?Q?P8VtO6TWpmhDuBgahzQHa143HNf/hCSW13l/fsLnwKjeBN3LdXW65wi5Ao1a?=
 =?us-ascii?Q?WIrKJJ+ykwCMQzB47uE=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95f2aa3a-4c2f-4446-5955-08dc841aa182
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 22:15:09.4496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bqVuYdHSs6vl8rv6fsJk9yhZs2KPE4zkBegXYLmSSLtjS/wN8Dmux0xjFmRfMbJp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6948

On Mon, Jun 03, 2024 at 10:46:34PM +0200, Lukas Wunner wrote:
> On Mon, Jun 03, 2024 at 02:30:45PM -0300, Jason Gunthorpe wrote:
> > Since the only declaration for sysfs_bin_attr_simple_read() is inside the
> > "#ifdef CONFIG_SYSFS". Add a stub to the #else section too.
> [...]
> > I don't see a patch for this yet, but I did find a 0-day robot complaint:
> > 
> > https://lore.kernel.org/all/202404200345.eGdn5uxW-lkp@intel.com/
> 
> I already submitted a patch on May 23, but it hasn't been applied yet:
> 
> https://lore.kernel.org/all/05f4290439a58730738a15b0c99cd8576c4aa0d9.1716461752.git.lukas@wunner.de/

Ah, it is not a good practice to put patches you want applied buried
in a thread, that is perhaps why it has been overlooked..

> (My patch returns 0, yours -EINVAL, but I don't think that matters.)

Yes, it looks like the function will never be called.

Jason