Received-SPF: pass (google.com: domain of linux-kernel+bounces-199752-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ac141363f0b6c44b11c421f752776ef9.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240422232404.213174-7-sboyd@kernel.org>
References: <20240422232404.213174-1-sboyd@kernel.org> <20240422232404.213174-7-sboyd@kernel.org>
Subject: Re: [PATCH v4 06/10] dt-bindings: kunit: Add fixed rate clk consumer test
From: Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, devicetree@vger.kernel.org, Brendan Higgins <brendan.higgins@linux.dev>, David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rafael J . Wysocki <rafael@kernel.org>, Rob Herring <robh@kernel.org>, Saravana Kannan <saravanak@google.com>, Daniel Latypov <dlatypov@google.com>, Christian Marangi <ansuelsmth@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Maxime Ripard <maxime@cerno.tech>
To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>
Date: Mon, 03 Jun 2024 15:02:01 -0700
User-Agent: alot/0.10

Quoting Stephen Boyd (2024-04-22 16:23:59)
> diff --git a/Documentation/devicetree/bindings/test/test,clk-fixed-rate.y=
aml b/Documentation/devicetree/bindings/test/test,clk-fixed-rate.yaml
> new file mode 100644
> index 000000000000..b9f58cba944c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/test/test,clk-fixed-rate.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/test/test,clk-fixed-rate.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: KUnit clk fixed rate test clk consumer

Removed KUnit from the title.

> +
> +maintainers:
> +  - Stephen Boyd <sboyd@kernel.org>
> +
> +description:
> +  A clk consumer of a fixed rate clk used to test the fixed rate clk
> +  implementation.
> +
> +properties:
> +  compatible:
> +    const: test,clk-fixed-rate

None of this is really fixed rate clk specific. I'm going to rename this
to "test,single-clk-consumer" so that it can be used anywhere we want to
consume a single clock cell. Someone can introduce a double/multiple
binding as needed.

> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    clock-consumer {
> +      compatible =3D "test,clk-fixed-rate";
> +      clocks =3D <&fixed_clk>;
> +    };
> +...