Received-SPF: pass (google.com: domain of linux-kernel+bounces-199760-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2a8c0faf-5e56-4140-977b-da312136435f@amd.com>
Date: Mon, 3 Jun 2024 15:16:30 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2] ionic: advertise 52-bit addressing limitation
 for MSI-X
To: David Christensen <drc@linux.ibm.com>,
 Brett Creeley <brett.creeley@amd.com>,
 "supporter:PENSANDO ETHERNET DRIVERS" <drivers@pensando.io>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 "open list:PENSANDO ETHERNET DRIVERS" <netdev@vger.kernel.org>,
 open list <linux-kernel@vger.kernel.org>
References: <20240530214026.774256-1-drc@linux.ibm.com>
 <20240603212747.1079134-1-drc@linux.ibm.com>
Content-Language: en-US
From: "Nelson, Shannon" <shannon.nelson@amd.com>
In-Reply-To: <20240603212747.1079134-1-drc@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?STM5YXdSSjhMVjRFa210Y0c3SmVsZ3NXNW9tQXpsQ0RJK2ZCWVAybXVGbzd3?=
 =?utf-8?B?WmxIY3FNWHY5NndUdGZYQjNDdVQvQ3JrMVhmcFYwWXZpUnNXWnFZTFlZSVRH?=
 =?utf-8?B?Qk4vdVZpWmo0aVVEcG02YVZtRnNIdWh3NW9hS1BOSFJSdTFMTW5Ud2xDU3Fv?=
 =?utf-8?B?N3B3UGdWaURNRG8zS2tyMDEzMjdYdW5KWXV5aU9NN1llTVd1aWl1a3VPcnFE?=
 =?utf-8?B?VTFtV0VwaENkcXJSUWlYdmdUQkxOa1dhU1JBNk9OWFBGcmFvbjUrVXJRSmEx?=
 =?utf-8?B?eGxVZ0taQ1FJTE9ES2toVFZERFZxbXZ3dXlrYktramdzcHBJUy95czNvM1I5?=
 =?utf-8?B?Q2pJL295YUhPdFBkKzZIMStNZnRUNU53aGw2dmY5QWdoNHBWcE5iY3JIMTFB?=
 =?utf-8?B?YTRvV05CTGxKd1RIOXVWZ1dORk9pRlV0VEJBYVZtOVEzaDJSaC9tNGxUSDFJ?=
 =?utf-8?B?eldtaTc1cjlRWGJGZGcwL2ovc2RRZDRVSjJsbGg1ZTRuYTcwcWNURVFHQXkr?=
 =?utf-8?B?ODhtdmVLQ245YnA0UW1jUFIrclBlOGZXWXVNQ1dFKzd2dEVCYnoyRkNYaTlY?=
 =?utf-8?B?eWxtRWREMzk0VFVtb3BmY3M3clJxbVJWeFNTdjRBMHlqVUlPalJCUHJvcXFT?=
 =?utf-8?B?Y2tCUTZxZm93Zmh4SVpUd3lHV1psMC9rVXlpZmJMZ3JyMW1KYk9nMUdvOTAz?=
 =?utf-8?B?WC82OVM3eThCTjZCVzRieTMwK1FCZEVoRFpUb1VhaVgwN3ZsZ002bFltb3ln?=
 =?utf-8?B?a1NEVmVNem1ZdWhoVGt4eENMTFJwZDBoWUdMZG1keFlvRzRaZTN6ZFpqb3hs?=
 =?utf-8?B?Y1RLODc4UzZWbDZpN2hwSGRTZFpTRGsyOWhtNmRNRENieS9rcTdzemNHTS8r?=
 =?utf-8?B?NmYydGVHRFYyTnJtOHFGYWdEWitaNUxNYURxTnU0VUdZc3crOS95NmpFdGVa?=
 =?utf-8?B?bjljUXRiaGpwckJEa3dFMTBTdXRpNDVpOUx5QUhpalJlbHQvbzZoNTB6NEdv?=
 =?utf-8?B?Zjc1Tmlub2Y1RWpvRkNyVllkSTlxUXd6SVFxU0VnQ3NleUVCQkVzU2RpVzhL?=
 =?utf-8?B?Y2FsSkxuaXhMZ1Qyay94aThaNm4vTXRxeWJBOFo4VUpQczR5dTk4OXdzSldh?=
 =?utf-8?B?ZUx1eWQzdExNTDNpNkg3c0lhN201bHNRTGpHc1pZVEZvcWhWdDh6dGp4SjVv?=
 =?utf-8?B?Sk00YjJhb1RveUp3NmN5NVllMVd1R2hTVzhyNE5DQVYzTHErbTAxQzkzOEk0?=
 =?utf-8?B?Uk9RRDVPTURhbjVDMzJsaDUwL0w4eC9vUk5kNVJEcGxlS09pNS9CYUxaaWVn?=
 =?utf-8?B?YmluU0lRenNWckVGZTNPdXBmcElZVjNxVktpWUdsOGdyZ1VJWkUxWjNDRjBM?=
 =?utf-8?B?VDRvVktKSmVXZ1VQbjhoL2V3YndieVhLVDVSRXRrakhJWXVhbUNkN1h5SEUv?=
 =?utf-8?B?M1Rsa25RYnA2KzlFSWJjK0owdFJQbGNjMWZZZW4rVWpnKyt1cVJnR1JybnhU?=
 =?utf-8?B?QTZheVBJTXdkUzkvVHM1ZzMyYi9YWmVzV1RSdE1EaDkvenhDRjBWcWNkUG55?=
 =?utf-8?B?SHNKQnFyQ1F3WVU4Si9oRkM4S0h1eFMwQ1VoWmFMQ0hISXhJQlNjb0tOU0pO?=
 =?utf-8?B?bTV3aWZ5SFZ6UXBzUFBpU2lJZWh6ckY4QXdmbThmd204TEI2ODc4K1Y0bFZ2?=
 =?utf-8?B?M2R5K2VJRituQW1sOEp4U1FxS0dZVExzUUUwUlAzcTR5bCtmdzlTUjBybDJq?=
 =?utf-8?B?cVFBd1RYNzdZRGZUWm9Kc0R5VmZNVUd0NG42bnVqRnB2bHVUYlI0WXVVQzZh?=
 =?utf-8?B?TzZkTVRMUVRKSTJkZXpubXQraEs0SlBIUlNZbTVKWVlMbGhtOW1LOVBPYXg3?=
 =?utf-8?B?NkpnazFORkFUSmhKdEVtM00vdmFJZWVjeUpGWExGeFpLZ3ZIazZ4Qkl5cFRG?=
 =?utf-8?B?RzlFUUhDQzJUNVF0ekJ1akNPS1VmQWhPZnVQT0JGMHhnVjVFYVRkQUp1ZUJm?=
 =?utf-8?B?dlE0K2Mxa3dSYXorR0ozUE01YjBwdS82M2s0Q1pGNkREdk5hWEpzZTRUQmRN?=
 =?utf-8?B?ckFmQkZyOE9za1dHMERGaFlPVi9IeG1KOXI0RjdPQ1FDMHhNR3hDTWxHMmVF?=
 =?utf-8?Q?HO3YyJIQrsmfc0ouuKu4kQJ8g?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76ce898d-91e3-45b2-af9f-08dc841ad32f
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 22:16:32.8553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FxSKn1/fv4pI7B9AoIBWKzu+KsNN5giExLsbR2GqcLfSpaQop8Aw55SVSCJJq4j9BhXqhrYYENVg6FhCRqfGZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6621

On 6/3/2024 2:27 PM, David Christensen wrote:
> 
> Current ionic devices only support 52 internal physical address
> lines. This is sufficient for x86_64 systems which have similar
> limitations but does not apply to all other architectures,
> notably IBM POWER (ppc64). To ensure that MSI/MSI-X vectors are
> not set outside the physical address limits of the NIC, set the
> no_64bit_msi value of the pci_dev structure during device probe.
> 
> Signed-off-by: David Christensen <drc@linux.ibm.com>
> ---
> v2: Limit change to ppc64 systems as suggested
> ---

Works for me, thanks!
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>

>   drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> index 6ba8d4aca0a0..a7146d50f814 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> @@ -326,6 +326,11 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>                  goto err_out;
>          }
> 
> +#ifdef CONFIG_PPC64
> +       /* Ensure MSI/MSI-X interrupts lie within addressable physical memory */
> +       pdev->no_64bit_msi = 1;
> +#endif
> +
>          err = ionic_setup_one(ionic);
>          if (err)
>                  goto err_out;
> --
> 2.43.0
>