Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1291200lqj; Mon, 3 Jun 2024 17:15:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX0hehL7/R4EfYK2l9PiihXM9q2+jsrX4UP6CBWFy9QWCMevZO26+gNTpU5nf85l888oqj97tAth2/bQCMouFP2kSXWPG8Oamcq6Pv4Ig== X-Google-Smtp-Source: AGHT+IEbAzmD8Tx1kiXbEGzQTqm30w81zxoufwSI7lZBdwbXH9BlokdH+ZEvxkgFdI8LAtnvQQP/ X-Received: by 2002:a17:906:3886:b0:a68:f2e9:e24f with SMTP id a640c23a62f3a-a68f2e9e33fmr316557266b.56.1717460120897; Mon, 03 Jun 2024 17:15:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717460120; cv=pass; d=google.com; s=arc-20160816; b=iLZM175RnqanSBCM+n1mmMvr9zB2e7eMndQ2okjFJbbwTj4VLCB7YfC5jwNJERnTUT eF9qsFDcKtkg8q7P9pBSi2y6fg58xYTtzmY3LHOs5DU/+000vwasfHYG27XSe2apdgt6 Q5Zwx5s4GYCYGpbUPNs4Q1gKFs8KKX5rQ48Ueo2ZKChoRG73B8hQJ2WY7VW1q66XxM4H WiQw9ziJGkYVW9Gk14v4ZSN+KY0mXt2VvGks82d9/gZ7AUyucIgFZGPJG9Z1Hv53jlLl uxmv4qBsnxRICtGTHvLoV15OWwQp3aHSLkDr3QLYUHoBwq35Wp8Ak3dZKcTB9Ha100jH frZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=AwKVDEUTzAer2/zn06Z29sDGLQZ1Y33UuQ16v4vW8wI=; fh=xM3aVzQ6zbQZkn9Yyvw/gYe0G3r00d1KBU4Hza4O8Ms=; b=ozaVnM8XwgqwaSxULZpUUMGWfZyqvtfsTEQ2Ue0AdIfR5i4zjvScRMO14Fs97P9ewm l496lt9y7GzlOhTCUkt8lc/kQMaZ4S9b1Syk+eJMI3k90bbI/HdeAs9znEJhDpekS8xJ LORJJlEd3TFk9l6T8HntymLFWTPVuV/71DY8CZRxtnzZe6RiFibW4xREpONWjY8j8fpB CfRC3IiBZCq39tcIL9+8GvbedoI/bB3vTm+uYPNmDX6jPG8SpqESCgTjURSrUMJng/xA lD4MOeUHu59JcUv9uSJZk35/2WUeP221RipehOTeh0+w40p7xa5E/VZngEd1e5yUUdNX 5YlA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f7I6Xfup; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-199863-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199863-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a690cc745a7si139869866b.1017.2024.06.03.17.15.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 17:15:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199863-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f7I6Xfup; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-199863-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199863-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9C6781F22C15 for ; Tue, 4 Jun 2024 00:15:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 754B817FD; Tue, 4 Jun 2024 00:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f7I6Xfup" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94098622; Tue, 4 Jun 2024 00:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717460109; cv=none; b=F7lPW6YM62XSNYCwiBf60LqpD8IA3jp0mm23DFESNDEn8HvQxvN2DboMpcOXtagSqmgpORHRreeq8fSQL37oTDxWbCOQFC1RGsEornSJ2cEpKnbrKn51t1AD97YtjCcX0Zn4xoXBNV1pMhIimMKzu+mYeNlhDkVGjoSLRhxcy/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717460109; c=relaxed/simple; bh=3pjvfGdcJwmqkuaIPFqlBnicTRQYalvmjRMwHiifioM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tQFsg1L2VWFPjoO3dqiGbDVyI2iNYk4e+rERS2O85MmfWwXyoJRLwguK6mpwcuh9uPoB7DyVLePtXMC+Vu9DS1mvVy6iLNY9wdfvyDWGdWyNgYI9Re4GmYwJ/5pIlxn5Lm896bMFwOMBO28BHQz8KkZaCu/KKMewVXJWwfkUjX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f7I6Xfup; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B35F1C2BD10; Tue, 4 Jun 2024 00:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717460109; bh=3pjvfGdcJwmqkuaIPFqlBnicTRQYalvmjRMwHiifioM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f7I6Xfuph3hbzicFUXWOqzQkePA+YDQ4TGaek1pwLmdUpapH0cHkPS5AspVBmO/nG Inbg4sPcsFsxrNav9S5uk40Rj53dxmjoTig5za8kfb8F9IukGizBqeYmakLslzva5n B4Q5KYQ39Eh21xy0mI6Av3nPKYckVUnIBJCXqfvTkkg5asm+xu0zSJEgNL2t0cIr6K ojz5pAAOsEAZnO3aTdAmInt7mNhd+ymSRKxXP1VO+qXJ9ixeZH32AYYAMM7cEWiKxk FAbj+6vbMcHZrbOLhAZcE/QLShDb4AgFCdTWDl9hw8Lu8QxQNOxRtq2oJysdu5k6qE yG45bziBoc4ug== Date: Mon, 3 Jun 2024 17:15:07 -0700 From: Jakub Kicinski To: Aaron Conole Cc: Adrian Moreno , netdev@vger.kernel.org, Pravin B Shelar , "David S. Miller" , Eric Dumazet , Paolo Abeni , Shuah Khan , dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman Subject: Re: [PATCH net-next 1/2] selftests: openvswitch: fix action formatting Message-ID: <20240603171507.2bd5e904@kernel.org> In-Reply-To: References: <20240603183121.2305013-1-amorenoz@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 03 Jun 2024 15:00:03 -0400 Aaron Conole wrote: > I agree, this is an issue. BUT I think it might be better to just > filter by field type up front. See: > > https://github.com/apconole/linux-next-work/commit/7262107de7170d44b6dbf6c5ea6f7e6c0bb71d36#diff-3e72e7405c6bb4e9842bed5f63883ca930387086bb40d4034e92ed83a5decb4bR441 > > That version I think ends up being much easier to follow. If you want > to take it for your series, feel free. If you disagree, maybe there's > something I'm not considering about it. > > NOTE that version is just a bunch of independent changes that are > squashed together. I have a cleaner version. > > I can also bundle up the series I have so far and submit, but I didn't > want to do that until I got all the pmtu.sh support working. Maybe it > makes sense to send it now though. Simon, Jakub - wdyt? I'd say - hold onto the changes until pmtu.sh works, unless there's *any* reason for a particular patch to go in early, eg: - patch fixes existing bug - someone else needs a patch - ... - a patch which falls under some of the criteria above depends on the patch