Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1322353lqj; Mon, 3 Jun 2024 18:55:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW0YhUelp7Uvu9AWV1hal3mcJTIJPm3VYRHbpihA+VBYlRW/ULGD4b9cekgY2k+2V0ohu5XLhiBEwKPJYZXf0ktHT8bGO16iI9/9I7hSw== X-Google-Smtp-Source: AGHT+IHZGfOdBa3IxnhJtGoI8FgmyinG7xoyLaTCp91P6tTVU0Odi+TEvO0qF1Hw4+ou4xVZlHrT X-Received: by 2002:a17:906:5910:b0:a68:c6c1:cd61 with SMTP id a640c23a62f3a-a695441f829mr89100066b.29.1717466148296; Mon, 03 Jun 2024 18:55:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717466148; cv=pass; d=google.com; s=arc-20160816; b=YqYrlS4OhSOhD4nREkvgVeSnmQl8xo8kBuzeKRkkrJ5Pu4wHOgo/98mMbWN9KmyI6+ GcnZH7hlFa+XrcEoXK/ktBy1n0NZp9k00iYonww+MAIFEYZcnvdf9YWunMeNadO44rpo YNvufYsm+5jYQAd8I4iDPR3/kJumXGwm4GGbEVZWJF9oayA41LIdfWhWLvpCThNR5Qgt X5GdzoWzPjg2lZwsVtpmE7SZC7jt9elT23o2UoJx63Qq1nEV6d+WNqAVySjWO2eTKmt8 nYFVf/05lzHzJaOdSz16+jjJnMbudUiqgt9Sowth2IUwgdCay3tQVfwTakvcDeedkNvL mMpA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=40R6Kft8TrrBRz+Be1UN6OcHNVpwpIg7s9uxpQMzgAU=; fh=u7VIfotmvhCnFPKh0R845OAh004BwcT1TGiZ1dQEGzo=; b=RB6usb+4OPP/tOk2vcxkMVFnn6vqJuJUQzJ5deFlShfm8UWCNKKmeGIUSs93aKeS7T kDh8kPDsVJA9Rh0QNYGMR/PX1hYvf7+C8DPreKbsv02J6krN7sgKYlAIkPSO9v8+EEWj uO7OfuBqc5oq0V+F7zW58qGv0OAsPR5L8CeB9U4m9xdtT128Tn5Aqndwp2NTrgcP+zOs Ts6RtwNxRVuDehx+o4i5DXixxQOzRsJ0KupOUbNuUoBHyWYwSfx4cBs/dSlVBR4ObJiS hGcK62/PDm0mDuJL8QLudpCS9Wvq7tdGq/eS18XQn1OdF7p3sj5p+qrikY00Cl53PyZG JArA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KXuCHG+6; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-199923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199923-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a68c1775d72si279285866b.1047.2024.06.03.18.55.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 18:55:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-199923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KXuCHG+6; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-199923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-199923-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0CB781F25BCD for ; Tue, 4 Jun 2024 01:55:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 80BEC13F45D; Tue, 4 Jun 2024 01:54:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KXuCHG+6" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77F0F13D60F for ; Tue, 4 Jun 2024 01:54:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717466065; cv=none; b=EK0swBMOC87XV5F9fO3eK7zC+RH0bDvW+G978fmT4BB+3OoRbeZ8EsXt1S8hKz9mWBENIdhpu4hyRZjpbZSFciTOOdBtcRs6Xf00gSk3IUyIXfdpUy1lfMmAY4hA5Gsqe6ciRrvMOTXQAKGGRuK+lPndC2+PKCUHopCRKGlSDTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717466065; c=relaxed/simple; bh=Y8tmajavNhEb2U4e54gDZyZwgTBk84qW7m36BoQgWp0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iHyuqylaIueHfDwnlDzPlRjE+yevMOxjPPgF1IzeDVm5Xy5Mswimbyf1YrVFpE6B21ZUR6l9vxlDrusAaL6liw34hg0/hFi29yosHN8WUJ49td2mBL+7+0vG6c53CB2ESE6AlGKb7GiBbxqn2ivl5ik8axQjNvGUaCdAD1ZDRt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KXuCHG+6; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717466064; x=1749002064; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Y8tmajavNhEb2U4e54gDZyZwgTBk84qW7m36BoQgWp0=; b=KXuCHG+6IJBSBfhb4lOgwBoN7SwhyImuy8jyE4bXjBMgDqJoJLnX3p4q jApEFRn2Yh72q+HpDC6exNXVOaZpnGbPLkkBi9wVmKiIB43Lj5lxwSjRg s6KVIVw2D0ySS1C29IdIfEm+S8dUNav+7zPwAhci7YintSgEhayX3hH0Y NiRp0f/dOClAyQVTqx6Nt8JtZm5+gIDUqlxau8wvVxmmASQymyHhs3ASR N8svGxf1tjM3YH734EhcihiTR+flRgSSPoRmVYALknQGV+jAd8RdZgDm4 p9I32TCEJJPI9p/O8lqPPCVpYl6uQ9wKG6sGhs1ZrvHf8lsBD1NZhcLbI Q==; X-CSE-ConnectionGUID: 0QS0fvMqTCiOyJ1KismtCg== X-CSE-MsgGUID: W8jDsbOaSxOB53vb2HUVAg== X-IronPort-AV: E=McAfee;i="6600,9927,11092"; a="25384950" X-IronPort-AV: E=Sophos;i="6.08,212,1712646000"; d="scan'208";a="25384950" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 18:54:24 -0700 X-CSE-ConnectionGUID: q82kEK5bRvekjrNhIFC1Zw== X-CSE-MsgGUID: CmxBK1IlQW2p11gUJOibRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,212,1712646000"; d="scan'208";a="37661843" Received: from unknown (HELO allen-box.sh.intel.com) ([10.239.159.127]) by orviesa008.jf.intel.com with ESMTP; 03 Jun 2024 18:54:20 -0700 From: Lu Baolu To: Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian Cc: Yi Liu , David Airlie , Daniel Vetter , Kalle Valo , Bjorn Andersson , Mathieu Poirier , Alex Williamson , mst@redhat.com, Jason Wang , Thierry Reding , Jonathan Hunter , Mikko Perttunen , iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lu Baolu Subject: [PATCH v2 06/22] drm/msm: Use iommu_paging_domain_alloc() Date: Tue, 4 Jun 2024 09:51:18 +0800 Message-Id: <20240604015134.164206-7-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240604015134.164206-1-baolu.lu@linux.intel.com> References: <20240604015134.164206-1-baolu.lu@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The domain allocated in msm_iommu_new() is for the @dev. Replace iommu_domain_alloc() with iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu --- drivers/gpu/drm/msm/msm_iommu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c index d5512037c38b..2a94e82316f9 100644 --- a/drivers/gpu/drm/msm/msm_iommu.c +++ b/drivers/gpu/drm/msm/msm_iommu.c @@ -407,10 +407,13 @@ struct msm_mmu *msm_iommu_new(struct device *dev, unsigned long quirks) struct msm_iommu *iommu; int ret; - domain = iommu_domain_alloc(dev->bus); - if (!domain) + if (!device_iommu_mapped(dev)) return NULL; + domain = iommu_paging_domain_alloc(dev); + if (IS_ERR(domain)) + return ERR_CAST(domain); + iommu_set_pgtable_quirks(domain, quirks); iommu = kzalloc(sizeof(*iommu), GFP_KERNEL); -- 2.34.1