Received-SPF: pass (google.com: domain of linux-kernel+bounces-200061-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates
 13.93.42.39 as permitted sender) receiver=protection.outlook.com;
 client-ip=13.93.42.39; helo=westeu12-emailsignatures-cloud.codetwo.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=topic.nl;
Message-ID: <0fceefc4-2b3c-41a4-a6ac-d0b6dbacc1f7@topic.nl>
Date: Tue, 4 Jun 2024 07:26:48 +0200
User-Agent: Mozilla Thunderbird
From: Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH] usb: dwc3: gadget: Inform system of suspended state
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
CC: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.c5f44c79-75b2-43c1-a791-806fe8b693cd@emailsignatures365.codetwo.com>
 <20240603131304.233403-1-mike.looijmans@topic.nl>
 <20240604010256.4dxamwvcjxug6xfb@synopsys.com>
Content-Language: en-US, nl
Organization: Topic
In-Reply-To: <20240604010256.4dxamwvcjxug6xfb@synopsys.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 =?utf-8?B?a2ozWjJ5ZVZpcDJ3dVhnakR3cE13V2s4bjBhSXpaRlBtVEZBYjEzalcvWUlh?=
 =?utf-8?B?STk0UzgveVBpZTk4anRCTHVWL3MzQ2lnbFJyeVNJeE5RTmtXcWNlOVM1WmJE?=
 =?utf-8?B?Q1Rrd2RJeFU5UEE3aWVJK1VhLzRPVTlWd1d3Z2hSVE4xbmt4akVMTUdDYVkx?=
 =?utf-8?B?Q0I1a3c4T2wzSWZjdXFsQjVQT1JtVVhTUWVSdTlCcFpMeWU4ZlMyd0IwclZJ?=
 =?utf-8?B?YWFtSVF3KzVvZk54Y0RvSG9qZGlUT0VGaHJjdjY2MFRDL3JMdGJPRjhsQ09C?=
 =?utf-8?B?NURELzFPNVZKUWxYOElGRFdGT0MyWTN6SVdpZ1piTjhKK0ZUQ1lrQ1BnRGJ3?=
 =?utf-8?B?aXIwaTBnU3ZsRXNqNjhLaVpYeVlqYU9PT3piTGJkL25ZeDUrSW5oem5ZK3JF?=
 =?utf-8?B?NW5kei9tN080dmZFUzl1V2N1T1R3YnFSa09lYXNJS0RRRjRrRmNtVk9hdFhM?=
 =?utf-8?B?WlRWRkZnQU5WOWFwV1RpR1A2ekM5RkFQTU1KSFovVVh3RUYvTFl1ZDd1cXcw?=
 =?utf-8?B?MzlHVlRWcXZ6dG9sNFdQV0VVRmVOQ3hrZHZCTE5DSWlJS1pjUVRMbzFQUTNL?=
 =?utf-8?B?Q1VLS3lUNnJZL0pTb0lRM3hPNVFpWEt6NTBQbytEdUxjczBCZDdrZmZKNHpr?=
 =?utf-8?B?cFRjaWZmV3lrNjRGZU51RFB3SW14cERveHhVQ25EQ0ZNR1VUcHRGMnBvTWE0?=
 =?utf-8?B?ZEtSMTBmWVpDMTE2aXNIbjVsOHMvMDVXTDZKS09WRHRHNGJOb1B0WGN5K1Y4?=
 =?utf-8?B?emxDSlNMVlpMOFFnVDNHMXZuZHlWQmFzMWtLeXBxS0I5czFxQlI1NEgzZTRm?=
 =?utf-8?B?dDg0cUg0MmhrMTdkMXYxa0hMSTJtcitFQlZ4VTBkUzRwWXZzY3ZEUDJybFVy?=
 =?utf-8?B?VkpaUGdlWHB2K1ZlRGRPUzE5N1ZKZ3duckw5MnJjT2Q1dkhQeS9PbXJma2xx?=
 =?utf-8?B?QW9URWZ4YXBITzFPeHhQaWNkdWlnUXBoT2RiVWtFWGdzYXFDOE45enV1MGdI?=
 =?utf-8?B?aTViR0xXNkZiUXZ5S0kybmh4QTlVcnJ0UHpMbkxLY21DUE9DakRoNzg1MkV0?=
 =?utf-8?B?ZTF5TXBWajVBZ2FQL3N6ZnVCcEVwWEpzNGZUNFB2VjFjQTFJcUhDS21OSXZP?=
 =?utf-8?B?eEFBYVBsNTI2bjZ0SDlaSjdKUGczWmhhOWFVd2Z0djFyRlR4aDN2ZU5aZE94?=
 =?utf-8?B?MFk0cWdEemNHalZGeXhiWWhFRklWMTVnTmFUNWNDNmI2K2h2aGRuVjlLWUNo?=
 =?utf-8?B?RDkwQklLWit3a0FkSUMxYWdOSHIvYmxWM040Nnk5aG1xWEVWNzIwSlRTKzJ6?=
 =?utf-8?B?bGswVTBlS3pRUEdrRXI4N29Fd0lRS3hUcGE1ZGh4Q2JIWHhqdW5OOHJ5OUs2?=
 =?utf-8?B?NGYrQXRuUGt2d3QrSy9hRXJuRnNaU1NYa3hhNUNCdHhNekx5SUQ4bWVIOW56?=
 =?utf-8?B?Wk5kWXhLRG5PYTlyc3JNTVd3RXVncks2bWxmdDB5a0NPTkIyMmczdFk3dXha?=
 =?utf-8?B?L2VqWWNGOFY1c3ZvYmNoRG0yWFJZWHRmd2drWGpScUVzMlJ1NU5SVzRYbnQ5?=
 =?utf-8?B?Wk45OEJWd0t5TGNYeVdRWDhoSnBEV3hqRDA2aU5JdWhWdnFvYVpEMkhVUGlo?=
 =?utf-8?B?VnhNVHRYL3dnNm9TaCtQZCswbUkrL0Q0eDNaemtubHBBczZHWllZRnZkSkNq?=
 =?utf-8?B?dmJQSFkxeHVRcjFYMWJPR212UkV4Z1QxNjFLUE9sRTdnT3RMQ2ZLUFFBPT0=?=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(52116005)(1800799015)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8160
X-CodeTwo-MessageID: 7097d2d7-1dfa-42d9-9542-2b4cb81d4f85.20240604052652@westeu12-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AMS1EPF00000042.eurprd04.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e59f5b2e-db81-46fb-1a1b-08dc8456ef55
X-Microsoft-Antispam:
	BCL:0;ARA:13230031|36860700004|376005|1800799015|35042699013|82310400017;
X-Microsoft-Antispam-Message-Info:
	=?utf-8?B?VCszd2I5NnJTUmRUTUNxV1pQSUpiUExYUkdWVEs4UzBDZlMvZmxxOWl6cFBP?=
 =?utf-8?B?MitkTTJxTGlueWtZUmpZazYzVUNCcWZhSHBuWHdwN290NTRLRnFFTHZKOUdK?=
 =?utf-8?B?V3ZDZUpUSjBONTNWVWZqeTVnaWxFNkF1L08vWDRSWG1QSTJCNFNHczBUZ1VU?=
 =?utf-8?B?RnhEUXh0VUlBMWx3c3FwRFVMdlY0QUpkZVIzdzcwcUQyMzZ0cG4zTGVBTHU3?=
 =?utf-8?B?R2FZYWVQdmR6S2Q4ZGlqaFdtWWRDTTkxeFNWSTRJTnRNdCtMZE1pZTZQdkVW?=
 =?utf-8?B?Uk9NajNuSmh0aTZMcEtkYzBQblpCU3hTd0FGVUNwTnlkZ0RpWmRWTGVGbXJm?=
 =?utf-8?B?YnA1ZHVGcUFERWRKb3lLMHpHMTZqdlJHeFFXMktQWGNraFpjemJCU1VUSndC?=
 =?utf-8?B?SEZ6dTN3a1NvenExWFlPbDlvQTZHM2F4WDZ6UUdlWjJhYnFOVWNmSVdhMUs4?=
 =?utf-8?B?d01XZ1BpZUpIdmJndDB5VFY0VURwYkxRN0R4ajBPNUFKY0dHQmxNT1h1Wkpy?=
 =?utf-8?B?bCswMHJzTmsvN1g5ZjlKZnkvelNsZHdIK0o2YXY5NWxHR0kzKzhlU2lyYjZm?=
 =?utf-8?B?cjhFUWxIbWJvb1I2dGVCNFViOUYramZVZG9HTnZDS0VzdVBZVFp1ZGN2bnhY?=
 =?utf-8?B?QmtQbi9oTVErS1dPSTBUYi9sM0trS2dRT2pTNk00MmRUNVZ6UWFTWGZNYWFr?=
 =?utf-8?B?WFpUOThWR1RGVHRaU3MyRHhrenJaOUhJUHRZM2YyVW9ma21lYUU0dEg0b3hM?=
 =?utf-8?B?eVVBc2d1c243TzNaZ3RLTk9rRGxFSElKdFpQNkwwNHMvNUR1RVlRTmZUOUFt?=
 =?utf-8?B?WHhpMFozYzczd2QrMFd0KzA5LzFKK05kd1RHMXBkdnFwZjc2dDdCZkJ4QWdS?=
 =?utf-8?B?TmU1VjBkWGFYeG8rS0pHaWJ5YUdNVEpjUXJtR0ZXYkl1em12UXRkeWNqWXBG?=
 =?utf-8?B?VUo3VUtWQUdXdWpGS3BFVWxMeU1nSm55ODJOaG13UHprMjVGYkk1WW5KczVN?=
 =?utf-8?B?NnJFcnFCam15V3Bwa0R4V0xaemlWaHh0Zy9rVTJwVjdKTDRsTDJMWitKalds?=
 =?utf-8?B?amZsV0NpRm4rNW14ODh5cXN5YU1PSWIxeGhNUzZocW1qRHF1VHJOU3M2aXh3?=
 =?utf-8?B?V2Y3Nm15aEZpWDhyNmZ3ZUFqeDJteldDT3Jrd3lodUZ2bHN6Rk1nSUpaVURt?=
 =?utf-8?B?QkEveERoYWhwUGYvdlVFQXhXUklWRXo2K29iVGsvOElianBya0lsTGNXNTMw?=
 =?utf-8?B?UHlQVmNRVzhTRnVYRlZ2a01XUXB5N05vNHplZzhLd2tVVlBZNExzTXpGbjNX?=
 =?utf-8?B?ZDRzanA4Mi9IWGQ5VEpjWURoTnZUQzkzQlhjTURUbXBxQjh4ajB0SGQ3QlJM?=
 =?utf-8?B?d3pZV2lLdHI5dE9wMTBrblppODUwbVNYaDdhbmNYMDM0MEZjWldWUFF6cnkw?=
 =?utf-8?B?c2xIUGg3VUNoM2RBa3Y4QXVFdUNMUXZieWE1QjBOTE9wRzF5c2k1Z2J1WVlD?=
 =?utf-8?B?Y1lVdkt0UGJEUk9oY3cyUnp6c0lrT1JUVStvek8zclFlZE5kbFMrVVVMVklh?=
 =?utf-8?B?WkQ3UEp3bEJJcHZJS25ORlVvaE9GblpXTjVvVWF1SjlUT0MwOTNvYmNiZGVl?=
 =?utf-8?B?QW84a0tuM1JaL3VNSWRNM3JXZTVua0R1UjdWN2xlQ3lhM1BBOFlRRUIyV0lU?=
 =?utf-8?B?bmFyOTlrOW0wUmthdEV3ZXRWQkY1TUc3c3VoamRrNVhDV0ptZitqNGgwejhz?=
 =?utf-8?Q?C21CaFCPmL3MHJCgDMBixQeSRx1K/mq9k9LjxKk?=
X-Forefront-Antispam-Report:
	CIP:13.93.42.39;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu12-emailsignatures-cloud.codetwo.com;PTR:westeu12-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(36860700004)(376005)(1800799015)(35042699013)(82310400017);DIR:OUT;SFP:1102;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 05:26:53.4147
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4311eec5-adf0-48da-5b3b-08dc8456f18e
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[13.93.42.39];Helo=[westeu12-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AMS1EPF00000042.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9561

On 04-06-2024 03:03, Thinh Nguyen wrote:
> Hi,
>
> On Mon, Jun 03, 2024, Mike Looijmans wrote:
>> When disconnecting the USB cable on an LS1028 device, nothing happens
>> in userspace, which keeps thinking everything is still up and running.
>> Turns out that the DWC3 controller only sends DWC3_DEVICE_EVENT_SUSPEND
>> in that case, and not a DWC3_DEVICE_EVENT_DISCONNECT as one would
>> expect. As a result, sysfs attribute "state" remains "configured"
>> until something resets it.
>>
>> Forward the "suspended" state to sysfs, so that the "state" at least
>> changes into "suspended" when one removes the cable, and hence also
>> matches the gadget's state when really suspended.
> On disconnection, did you see disconnect interrupt? If so, it should
> transition to USB_STATE_NOATTACHED. This change doesn't seem to directly
> address your issue. Can you provide the driver tracepoints?

The device doesn't issue a disconnect event, I didn't have tracing=20
enabled in the kernel but added some dev_info() calls to determine what=20
was going on. Added this to dwc3_process_event_entry():

dev_info(dwc->dev, "event: 0x%x type=3D0x%x", event->raw, event->type.type)=
;

When disconnecting the cable from the host, I see this:

[=C2=A0=C2=A0 50.841411] dwc3 3110000.usb: event: 0x6084 type=3D0x42
[=C2=A0=C2=A0 50.841457] dwc3 3110000.usb: event: 0x4086 type=3D0x43
[=C2=A0=C2=A0 50.841494] dwc3 3110000.usb: event: 0x6084 type=3D0x42
[=C2=A0=C2=A0 50.841534] dwc3 3110000.usb: event: 0x4086 type=3D0x43
[=C2=A0=C2=A0 50.841571] dwc3 3110000.usb: event: 0x4086 type=3D0x43
[=C2=A0=C2=A0 52.650990] dwc3 3110000.usb: event: 0x30601 type=3D0x0

The "0x4086" and "0x6084" messages are endpoint events that occur all=20
the time while connected. The last event is the "suspend" one. After=20
that, total silence.

If you need traces, please point me to a description on how to obtain them.


>
> Thanks,
> Thinh
>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>>
>>   drivers/usb/dwc3/gadget.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>> index 4df2661f6675..99e8ea9db600 100644
>> --- a/drivers/usb/dwc3/gadget.c
>> +++ b/drivers/usb/dwc3/gadget.c
>> @@ -4343,6 +4343,7 @@ static void dwc3_gadget_suspend_interrupt(struct d=
wc3 *dwc,
>>   	if (!dwc->suspended && next =3D=3D DWC3_LINK_STATE_U3) {
>>   		dwc->suspended =3D true;
>>   		dwc3_suspend_gadget(dwc);
>> +		usb_gadget_set_state(dwc->gadget, USB_STATE_SUSPENDED);
>>   	}
>>  =20
>>   	dwc->link_state =3D next;
>> --=20
>> 2.34.1
>>
>>
>> Met vriendelijke groet / kind regards,
>>
>> Mike Looijmans


--=20
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl