Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1390690lqj; Mon, 3 Jun 2024 23:00:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWuXbvD3enlF7Mayew6Kjgtg5i21mydCCBTjwm0xM/qnokE+b2E12Ko97fUP97QiXIWKMYS3O+rCb78q4tNcwJksco23y0zjTGlOAcN0w== X-Google-Smtp-Source: AGHT+IEZRU33rTuuAz+3q40FeUET5zccs9tUkTdXA7/IG7ZnDJZn5jtkCkFpGgezCnG0jLp2fGTl X-Received: by 2002:a17:906:4916:b0:a68:e681:be2c with SMTP id a640c23a62f3a-a69543b65bemr122066166b.20.1717480813763; Mon, 03 Jun 2024 23:00:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717480813; cv=pass; d=google.com; s=arc-20160816; b=r7BRpfydDUFHHsxnFGGwJCK1GJRLllNqNYl80+D7uynhhskfSbfK14KU5jRK8hpgO4 1QHEGhhmUvdfUAK8N3Kkwx1H167DeHc8Qc0yZ8kFvW0ZpjLaSsvKlQhDoNSX7UVj9wZb SetpibQwIHafB4z05ILWm/P3oktYsG9ntdK5gmRtX7JGepak52pnICydnVITKo3hhaMB /yfOQeo521Ij1FBRmQr22GplyZwDm6yUz992xif3SPHbvLjme0yjNC/qF7W1NBk2Zqb/ jqZyog+C3senGWhwGnErxVecerEnFDrcrGLDkTwa//+84kR7ErgeboqMPemMFt5PNhdi hOwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OdslcSmw0P2RQFMfM7R8ZopVA60HpFv0+KaXWBjvP8w=; fh=YrYAYQM9L0nuGrT9BbKhK9G2xANUY3ugDklZktNnsUg=; b=M76zZFxjdC/6Sn70B1xI2NeUkZ9b2sgG8g0Z47Kf0fUXy6D42OuhrVadsxEkLlrh2P OoNAQfaquoEvl+iqZgnVxjn9wpBPOv4YrZKSKEt5439yX5YRv7H0stGJmeFxq7VrBpSf JE1rBMz4DFSm2sg6K7ypBCyXbCgPhF+1kMT4Xa7SG60Uf2p+HUlJR07rHAHpBOkwUgHB BW/6Ca+YSpJW+gmXCPR6ywUuR4Bmw1ycFcQwzMb3WXxqQkf4mDyWJ0r3UsYSKVxT3Da7 xAsWP1fyB9/1iy4MORrSSftynuxlFUxP9Syuw9Q3cdrlouL3U6T3HHUxagAWQ9I/kI95 9FpA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rCnhakrs; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-200079-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200079-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a68147422ddsi458175066b.578.2024.06.03.23.00.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 23:00:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-200079-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rCnhakrs; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-200079-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200079-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 792421F2336E for ; Tue, 4 Jun 2024 06:00:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5AE9213E8BF; Tue, 4 Jun 2024 05:59:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rCnhakrs" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B8BA13E3F2 for ; Tue, 4 Jun 2024 05:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717480796; cv=none; b=Kn3LqcnQOPdKN5HuTl6MfpmSIVDAqzqXrjJNnb5YHyeXK8oHHX1i7ehhH3ae/wcgDrPHURQrBeQl/x3yChvRqKgPa7S5e2kj6UOF7AMoG6uhDFZbyGXti5TrT6bZ4Wpsu/GaJXcoxi4tGD6dMWqK9CSjMuSA+mpO2bllDc36HSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717480796; c=relaxed/simple; bh=Ckf0ovplH5lI/Jy8+5S/19UVx5VPM/Jncn3YBcF4M0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z2+KPi5frliJM24Fo+GOZmnNVm9U3TJm1er43voj0TQmeaZNUmUi8Hy4rq7L3hMnuR+Zqm2q0oqqr/L26ELiBs3vSwL8H+zSQXpS6KqBv8JAnvf5TdsHucvFMb/CwZtr5ssGYG3cYD5xAh2uPpprgUl/oxQJse5mIU/maC2QczI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rCnhakrs; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECD07C4AF07; Tue, 4 Jun 2024 05:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717480795; bh=Ckf0ovplH5lI/Jy8+5S/19UVx5VPM/Jncn3YBcF4M0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rCnhakrsZoz//aDMnmzLkfalR6VF8Cs3+FUOfBfhLqcwwIBHSeW4qeNNpoeWcd3xQ tvJ4t75M6iwjmS2dQXO0pPSAHgI8xnP0SSl6jG5lWKGLYLssvpEAB1pdqO19H8p+Iz MbI7bQP98l/S0t8M6QNmOR+nfnxWPtU9Fd4m5sPY= Date: Tue, 4 Jun 2024 08:00:02 +0200 From: Greg Kroah-Hartman To: "Winkler, Tomas" Cc: "Usyskin, Alexander" , "Lubart, Vitaly" , "linux-kernel@vger.kernel.org" Subject: Re: [char-misc-next] mei: me: release irq in mei_me_pci_resume error path Message-ID: <2024060451-lukewarm-matrimony-2c38@gregkh> References: <20240603132928.977787-1-tomas.winkler@intel.com> <2024060419-stoneware-staff-b840@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 04, 2024 at 05:45:56AM +0000, Winkler, Tomas wrote: > > > > On Mon, Jun 03, 2024 at 04:29:28PM +0300, Tomas Winkler wrote: > > > The mei_me_pci_resume doesn't release irq on the error path, in case > > > mei_start() fails. > > > > > > Signed-off-by: Tomas Winkler > > > --- > > > drivers/misc/mei/pci-me.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > What commit does this fix? > > I would say 33ec0826314734fc4f3c9bf37 , kernel version 3.13, it's very old. I can respin with the comment, if you wish. As it's a memory-leak fix, that would be good, thanks. greg k-h