Received-SPF: pass (google.com: domain of linux-kernel+bounces-200083-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Ng, Boon Khai" <boon.khai.ng@intel.com>
To: =?iso-8859-1?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC: Andrew Lunn <andrew@lunn.ch>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S .
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, "Jakub
 Kicinski" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin
	<mcoquelin.stm32@gmail.com>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "Ang, Tien Sung" <tien.sung.ang@intel.com>,
	"G Thomas, Rohan" <rohan.g.thomas@intel.com>, "Looi, Hong Aun"
	<hong.aun.looi@intel.com>, Andy Shevchenko
	<andriy.shevchenko@linux.intel.com>, "Tham, Mun Yew" <mun.yew.tham@intel.com>
Subject: RE: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net:
 stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Thread-Topic: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net:
 stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Thread-Index: AQHasBkLCj07Z540QUGXqLg1tlacPLGrb/8AgAB3OtCAALcdgIACos0AgAA0dwCAB3I7sA==
Date: Tue, 4 Jun 2024 06:05:35 +0000
Message-ID: <BL3PR11MB57488DF9B08EACD88D938E2FC1F82@BL3PR11MB5748.namprd11.prod.outlook.com>
References: <20240527093339.30883-1-boon.khai.ng@intel.com>
 <20240527093339.30883-2-boon.khai.ng@intel.com>
 <48176576-e1d2-4c45-967a-91cabb982a21@lunn.ch>
 <DM8PR11MB5751469FAA2B01EB6CEB7B50C1F12@DM8PR11MB5751.namprd11.prod.outlook.com>
 <48673551-cada-4194-865f-bc04c1e19c29@lunn.ch>
 <DM8PR11MB5751194374C75EC5D5889D6AC1F32@DM8PR11MB5751.namprd11.prod.outlook.com>
 <322d8745-7eae-4a68-4606-d9fdb19b4662@linux.intel.com>
In-Reply-To: <322d8745-7eae-4a68-4606-d9fdb19b4662@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?2zfqMfi2/WiMygIREk5pi1V64umL3Sm9lpwosWlMjzpEMDtbAZ2ogmCFm2?=
 =?iso-8859-1?Q?IxCEDCHXU6PV9WMvoJATvz8ULHnCFbVY1Fgx8z9Zc02H3hTNhHdw8mARGb?=
 =?iso-8859-1?Q?bsz9YfpOvcBd9BBFJpBoZRwtIGTWPpdbBWWAY0HKAlazdlz9UqTD+nmcmm?=
 =?iso-8859-1?Q?rKwWTQKHX8XSzbU+d3uRf9Np4C65fr6RalWxS3q/JB5CIYqN8o8PJUrNiw?=
 =?iso-8859-1?Q?aq+GaIbpbSzOnq5JsMwa9tn3u2R0jc3PG/gYl0k0wcUz1DpOZFNDZsqZH6?=
 =?iso-8859-1?Q?AWjrKAa67rPjwhdOt+3wbhVIIOMbyoReDDF+XXH1tK/hWFyBOtRevZ0bvH?=
 =?iso-8859-1?Q?JYqs2+Wfl8pxmrIeTomsaZ0+hDsko+SWV07ypBgxi5Z48ey7MawfoBsPTZ?=
 =?iso-8859-1?Q?vTjW6hin6Oa+IDdcOMH28i6tm8Lav4zA2O6xHSwYuf+S7qrEV05sF3UxUr?=
 =?iso-8859-1?Q?o0HoDVpMdV8y05YLAakD+lpFT2b7pn7s1fphmeaSXXLzQGyLvKH11eEXAy?=
 =?iso-8859-1?Q?6FNV8zk0P92h7UrAcoG17gChdvMhnldrJJH2nxGTUDv7S9Wtkm7LTGkfmf?=
 =?iso-8859-1?Q?Pa9du6hxjxo8FyIsScxbz0hxKHIcstM3dd9k84mXMlMi/p2VHTbHgLCCMy?=
 =?iso-8859-1?Q?3YqvgoRP9z2IIzfrcHQlA9r4DFcqVo7M4upi8Q1ykBimc/9EBna26leLN4?=
 =?iso-8859-1?Q?PRP0bpE+WrtDuJxQCl0U2LoSUlLvE8QNQDet/L3Kpj/da9R1M4Zi+8e5uV?=
 =?iso-8859-1?Q?HjTccUDLP+1Zx5Cs+d6O2WV9ycsrUt4mI98CKm1eRwPjIAPK2kzXkzcMsU?=
 =?iso-8859-1?Q?9hoQGezdC3bCrfHfWXSTxKXqgN+KkrLhz/2X0pnKDimT9ZVKI3gxvBFpdQ?=
 =?iso-8859-1?Q?ZD97c2kvsyn9yrXLmUuvMWFpSKyFAZSPY376P0sqZ0m+fZhmPOcDVdZafU?=
 =?iso-8859-1?Q?6ghWm/2fYIRiywaBiw7D2XgC0jzynsNtoNZkAq+4y3mGaT2DtJQvkn0bID?=
 =?iso-8859-1?Q?rMkS3AXkhsbalYDnWki2bq7l0HCT8SvtlnzP2IIANcWyGk2NC89z0DoUPJ?=
 =?iso-8859-1?Q?tFKkQzbzXyTZzsRL5elGDRpDVVyQv1CGHz/WmfmdL3evRwcJdE/O3wAswb?=
 =?iso-8859-1?Q?0zDncImdUMEARkQbD6KyrNhWBCldNdSYaK6dBVtUGR3o1xbs0qXlmQQDc0?=
 =?iso-8859-1?Q?VeN9u7l8mBT0J7pJV8GCGNAxVorCEGa9EHQKl2FAIzmzHVKm1Sw7vtAwel?=
 =?iso-8859-1?Q?GSbYryAlYwwxYChHgJECfXxLVCDhAv3Fj9STFWnEvcrcuTJ0n0UrqLRhYW?=
 =?iso-8859-1?Q?4GkhCphhxeNsD9zOsgU2Jx5XwYPPxWTpoEZK8v/xnc+Ozz/Gl5ThhnRt8/?=
 =?iso-8859-1?Q?+2XwALUMSBw9NYL6XiZa0UMliY7qjweaTJkiwu1HKKOVehU1qN5e3dP9c+?=
 =?iso-8859-1?Q?VO8AgDyBPRZ5CSoRNY1OvOk5YnSTtq+A7hZvxby2sP/BME/pJes0onW2tr?=
 =?iso-8859-1?Q?k89YCZBY2B/vrdxC0H7KZ8wfxme5PYU+65SlX5xmRKbxhm69PdT6HG46gy?=
 =?iso-8859-1?Q?XgyzjEq4b3v3e30/ieK9AYkzabesTbdy6Cjtxk6FWjUV0xBtBioZDc1a8E?=
 =?iso-8859-1?Q?XHBgbDQ3r4YtsKE1+UFdu+Nv+pgMHENE9N?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB5748.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4705648-a379-40eb-cb4a-08dc845c59e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2024 06:05:35.9656
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jy0Hpa/nLzViUqDND2sZbD/xJ4mnx6dkYA2T5Xx9CJNaDRm5NjbAWA8cOa4UtyTmLqEBP1rhB6SDi8rfJ4x7SA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6165
X-OriginatorOrg: intel.com

=20
> You should generalize the existing functions into some other file within
> stmmac/ folder and call those functions from both dwmac4_core and
> dwxgmac2_core.
> Do the rework of existing function & callers first and add the new bits i=
n
> another patch in the patch series.
>

Hi Ilpo, do you mean I should create a new file for example,
stammc_vlan.c,  and move the common vlan function inside?
so that it can be called either from dwmac4_core, dwxgmac2_core=20
or stmmac_main.c? or maybe I should just consolidate them into
stmmac_main.c?

> Unfortunately, it's hard to catch copy-paste like this from other files w=
hen not
> very familiar with the driver.
>=20
I totally understand that, while I think Andrew has already call them out
In the previous thread.