Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1398818lqj; Mon, 3 Jun 2024 23:21:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXJyVSRTo7qkEOqhdkWfYFKrU6yOhrR1GP7SSVZdK3a+yZ/Lv8Ge8b5cAr7eRdfzyPSF4D70av0LlWtTAigDZp5NX/YtdnxM7RCQL0ffg== X-Google-Smtp-Source: AGHT+IFlFSXGbAZgv4jCyJ36YRVuMmQNkuE669i3BC95uxqEUc3Ty2wDFrKPb0zdy1j/UgRWsoLs X-Received: by 2002:a05:6a20:8406:b0:1a7:8dd9:5fd3 with SMTP id adf61e73a8af0-1b2a2c0e63fmr2546121637.18.1717482066310; Mon, 03 Jun 2024 23:21:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717482066; cv=pass; d=google.com; s=arc-20160816; b=TUrr5wS6oXx/SOlCk8USx0FaXXGJShzvUxxuJv5aM37LpTgT82bbcbc1FVBYYyUy1G yCVA5VPy9n/YffaefqVEqrPpcGo21629T0rsnRxlFVnMAPRvxPxITC1Z8GF97SB38LlL Xt7eIq4LcGB1xBKAQX/ORA9Ju8MMMMUqf43shzpOhDgRsDBeHxQr2WvQgnvYjMxZO9QE hTCW1cKB7P/C9TwR4ih1csdH939QgZejbBmB4Hn5FQecfMMjZ5JDmGUY5H/SXoe5lhoI yhB2+DsN98CLVbVmkxzQwZNp5XaDa1MmHgD4KkoOtzeoubw4VVMXIZPiwsE9xXM1+G6f Kwsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=eoLkwxk/1RU/462tDY/iXuQnatyZ8hS3ZWGg9LKvxtw=; fh=hHP9GbRUw04HzHKweyAGstSozql6pRKbI/dRWhxBC3E=; b=J4JwkMGfn7XNpm9deDLpdqDLNOcSfPKKrLv8/0LK2ZkmaZ5C7KhBzfmCQD1w67b2KG 7fNBkou4vSDcVgfyxhtwol41Tt2IUh5oC839TCPoQuUsQnoW7yfaX6W79vVchMjI5pcH B1iaeuHvvqdVZh9I+VZrum193OOjfTCgTNIlTZ8S6cP3YYvrXGK94hH6kg86B4MzOBez wgMyMyoxHjBhLBeq25KqTiTEpKu5gPYl+b43AB6z9NQa0uNyGWIHIoricaDMqP/ysCy6 ni8q/TwpfWJPK8Yd51WfzMubbpY2oNGw3Xf7ImMpXP8jqKlbZGEsYqUpHbePyPl9IqPW bfSA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qWMgBupE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-200095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200095-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6c35d59f53esi7601517a12.870.2024.06.03.23.21.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 23:21:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-200095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qWMgBupE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-200095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200095-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 89FD9B23953 for ; Tue, 4 Jun 2024 06:21:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4D1C713E031; Tue, 4 Jun 2024 06:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qWMgBupE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C9D265F; Tue, 4 Jun 2024 06:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717482049; cv=none; b=t6S2XjtmTfs9paNh/T5MVN28nfd8V2TZoyl5ViH9ctv2XIaeWFNYM5UtxS+n/9KvTUCVKjS//Q0RhIfAZBpHx57zi9NpvFhsVbZxlv54zU9JmP5ul/J6YfqMNep5dR4uwWmtdWY1SuvIvy+RW5aS6IGYyrwHClDqqEUPABLEsNQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717482049; c=relaxed/simple; bh=PkcqrMAXbZdOIXCh/dOOZCamoIybPOfYxoA1rbNE88M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=om1/IYq1HEYv6GU+ZmTEl2yNl2Xk/s/aIQ4ZnKVkQH0OxC1k+fWyuHmbtNnHgzKARus0IBrG7OdejXmPERv6HmnMHIQliZKDJHkZjwdl5KDcQkU6+4F657qPLfaKB1s4i4Y9vUiDJEbmSrVX6OyD30HUgpe8xONcKcZ7/t7MIBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qWMgBupE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25E9EC2BBFC; Tue, 4 Jun 2024 06:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717482049; bh=PkcqrMAXbZdOIXCh/dOOZCamoIybPOfYxoA1rbNE88M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qWMgBupEpdF99BXtOszC6ED+NVHBrhxsT/I5aq2QAU++igqCPmsbajWCpldgZWisL c8J7TmnE4hpzlL4dQlNsGoKnNv4k+SOk2xGtEAG9v4v/A406Gae6E1biNkyom6FHe6 poc49FazLBYU5dhnC9IEBGbMXjZ8EsyXSa/UDLIcLZf7mTfjhjT+aV+5TL3PxUncdm 6T3xL4wRFvX+Scx5YIq6liCTCDaaNO3KeyEUD964nSVJdv7qdrsrB5g/YqJV8Zz5Hy mq07iA3AAn8vPnlbypEPmB8hWSQS/qGfFWIDOpiynGk2X71p2lP/mQ0kfYzjZ5OZPy 6wCSDHEQxLTUQ== Message-ID: <1935a30f-b4fd-4240-93f0-e2baf218223d@kernel.org> Date: Tue, 4 Jun 2024 08:20:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] usb: host: xhci-plat: Add support for XHCI_WRITE_64_HI_LO_QUIRK To: Jung Daehwan Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thinh Nguyen , Mathias Nyman , Felipe Balbi , "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <1717135657-120818-1-git-send-email-dh10.jung@samsung.com> <1717135657-120818-6-git-send-email-dh10.jung@samsung.com> <9c9d74c0-72a2-418a-b3c6-a0f9716c943d@kernel.org> <20240603034435.GC23593@ubuntu> <20240603085111.GF23593@ubuntu> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240603085111.GF23593@ubuntu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/06/2024 10:51, Jung Daehwan wrote: >>>>> >>>>> + if (device_property_read_bool(tmpdev, "write-64-hi-lo-quirk")) >>>>> + xhci->quirks |= XHCI_WRITE_64_HI_LO; >>>> >>>> Where is any user of this property (DTS)? Just to clarify: your >>>> downstream does not matter really. >>>> >>> >>> This is set by dwc3 parent node by software node. >>> >>> [PATCH v2 1/5] dt-bindings: usb: snps,dwc3: Add 'snps,xhci-write-64-hi-lo-quirk' quirk >>> https://lore.kernel.org/r/1717135657-120818-2-git-send-email-dh10.jung@samsung.com/ >> >> This is not a patch to DTS. >> >> > > This is set by software node from dwc3. That's why I think this patch doesn't > need DTS patch. I would add DTS patch in dwc3 not xhci if it's needed. > What? I asked you question which upstream SoC (link to DTS) uses it, and you say that "no need for DTS patch"? That's not an answer. Best regards, Krzysztof