Received-SPF: pass (google.com: domain of linux-kernel+bounces-200134-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240603152601.3689319-1-hugo@hugovil.com> <20240603152601.3689319-3-hugo@hugovil.com>
In-Reply-To: <20240603152601.3689319-3-hugo@hugovil.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 4 Jun 2024 09:09:12 +0200
Message-ID: <CAMuHMdUo7yPdkPKHXYiWqsqM9Zs4rr2G1tQbH9mZ=bjNLgKamw@mail.gmail.com>
Subject: Re: [PATCH 2/2] serial: sc16is7xx: re-add Kconfig SPI or I2C dependency
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, hvilleneuve@dimonoff.com, 
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Hugo,

On Mon, Jun 3, 2024 at 5:26=E2=80=AFPM Hugo Villeneuve <hugo@hugovil.com> w=
rote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Commit d49216438139
> ("serial: sc16is7xx: split into core and I2C/SPI parts (core)")
> removed Kconfig SPI_MASTER or I2C dependency for SERIAL_SC16IS7XX (core).
> This removal was done because I inadvertently misinterpreted some review
> comments.
>
> Because of that, the driver question now pops up if both I2C and
> SPI_MASTER are disabled.
>
> Re-add Kconfig SPI_MASTER or I2C dependency to fix the problem.
>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: d49216438139 ("serial: sc16is7xx: split into core and I2C/SPI part=
s (core)")
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Thanks for your patch!

> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1025,6 +1025,7 @@ config SERIAL_SCCNXP_CONSOLE
>
>  config SERIAL_SC16IS7XX
>         tristate "NXP SC16IS7xx UART support"
> +       depends on SPI_MASTER || I2C

You may want to add "|| COMPILE_TEST".

>         select SERIAL_CORE
>         select SERIAL_SC16IS7XX_SPI if SPI_MASTER
>         select SERIAL_SC16IS7XX_I2C if I2C

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds