Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1417787lqj; Tue, 4 Jun 2024 00:15:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUd+W8KcV12zCbMAPGBUiHw60lRWsHsit75gscL8UmnAwcjyXcRW55CPbuNuwhVjF4JKAeVB74U+YkcgdvlvAzY7apTxfdDJfDlqgDE0A== X-Google-Smtp-Source: AGHT+IFBIBTEFgGYumKGscFHFR9DWot/LTen51g2W9ziAwVOYQ1LQ8FSL7TfA20ZgDK5MWoPq2Lg X-Received: by 2002:a17:907:6d21:b0:a69:173:2dc7 with SMTP id a640c23a62f3a-a6901732e95mr378719566b.66.1717485326001; Tue, 04 Jun 2024 00:15:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717485325; cv=pass; d=google.com; s=arc-20160816; b=1IyfETDguToq6+k/nQXRtNf6SgsQGr8VJUj5/92ch3b3/ZOxAhBdRvJEfdI9vzYcMN r2BeBAauB5Ne0hWPJKR012kX3nvZSF/NLQMKCt1+qQWG7croYH2yHnrEUqccUB87qD7t kr/MxUWrO7wDZAdxGu+5ih97WUP8JB9flizo+JgP7YTnZVI0P+snXQiUvfy9T88umxLD qIpgxsAF7oHYI23SyW+C46LJ+Iagb2/O1h1iT7yneRnWWjb+Wf7O13rWeHfZ9OV/L+FO 0JcWIIBtPZEFXJN0BJdobeYKGQoSsd+n/AMbC/BNP/xh4R2rkDYuipCw7zDzj4ccJdme KeXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=xGfwkYu7JVFXZOdUmCyYR2r+fVgJf4gONLr+u0dZ9y0=; fh=pr6AhKz4VvKBZ63ytZFRigp7gXeKEC8syUjKYeGYadU=; b=i7h/F5JKCDWsMwXNuC6i9YSLTDFmePGOoZ8XSixvJXJP7z2STxR7bQGvTJpzQ1gxjy IgRgq24VIQGDNoNYxvItT2fqmVMN0ugowIZiEpKWN8y2ZzbO2PtjlsBE1naUamr9/x+c FTmXHk1X/sgWDjFiPNCnly66w2QoZj2uowLDTaG8tcWebyHJprHbt4Wn4j+PJXFcPIvw 4cO81xAEBDVgzelVK0ZnxINubMVS2VqmFz+qTC5f756kjnEygFAETD6+wQ+zQaV4GO6O QuwzQTtBNdr03HF7t+tBJ4yrOBjGfN24djMG1iBoGqGYtvo+pru0ZXFmmn8uTYTZW6jS hTXQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=YN25Cf9i; arc=pass (i=1 spf=pass spfdomain=rivosinc.com dkim=pass dkdomain=rivosinc-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-200140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200140-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a68b2ed4227si343044366b.858.2024.06.04.00.15.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 00:15:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-200140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=YN25Cf9i; arc=pass (i=1 spf=pass spfdomain=rivosinc.com dkim=pass dkdomain=rivosinc-com.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-200140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200140-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 89E211F22B83 for ; Tue, 4 Jun 2024 07:15:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 167F813FD92; Tue, 4 Jun 2024 07:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="YN25Cf9i" Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44D1F13A253 for ; Tue, 4 Jun 2024 07:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717485315; cv=none; b=IUp3hA6d7GZeQ7xO5yOusHa3RW4qOeJcxH2Wen5nP8JG2/mzZODqOBgCBAAQySbJ3VKWAVuQ6KQSZaUml/vG0weNwYaTQnBdW3Qj912fJNw0zZ5PQITIFP67cMAbtqJgGPmA5TSUwRpaXJqB36U7hip5QLfrQktQwyoKKl3LLIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717485315; c=relaxed/simple; bh=MFsZGziZHFE5D1ndNfPCBePAxVAxx+FpbkEdKVMoKQ4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=GpKEfKSaHUQc6ug9itTcpkzqOkFcyuOTMQATjuh5lfmikF4pk8xcwJxMLp2Q17eZ0QFJEiUeazalxsSKZn1zk0/UQOhnC1WRuVJDgsruZsis4PhGro0vm5Igd/1lIDoetUHBCSx7TEKBp4v5fPVuXBJiat7xnSRNDiYKqjuFsv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=YN25Cf9i; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a68b5f18fc5so310240066b.1 for ; Tue, 04 Jun 2024 00:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1717485311; x=1718090111; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xGfwkYu7JVFXZOdUmCyYR2r+fVgJf4gONLr+u0dZ9y0=; b=YN25Cf9iAgXkXdYA2RaaYeWNHidKR9IKOQxprUHYhIunHol3Ss/qsFtCAa/u/xnB/k pOfnt/M3cuUxTMcILTm/pHGvsx5GXG8pCyWsbFXuwCWAcE0kldUbnAYr+A7pbHGnQ7If Fkf0Jklpg30g8A1fd1OBy102LuWida9yy8JWlWi9jJu5xUGmL6Fov4tTEfTVRq8bULUi mijQAazgJNQipZM8wO7/HzSU5mDWGKeQHbzS1+DURlFKy7gs9MItgCxkaf4HHpWFXyfF 9iFiP+jv6KaUxDa9V8NFimW1QQAjsvtTZW9qxey2eAITkXxmcljx/2j9rGJsveQgZODZ tZFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717485311; x=1718090111; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xGfwkYu7JVFXZOdUmCyYR2r+fVgJf4gONLr+u0dZ9y0=; b=CbWizvdwRsMQnmFgOToa0Rc+zRFg2t+u3i6kDAWwHuZ4mcY6quE8T7O2EieTo2ITkw hFV1bq6mq/cp2NfpjPoXum/o/ia1DGQ/hSSDjrmAiz8RxRmVkd7255Su+FIp0/DJOHcB uoZZ+UP5Uvvmds+zxbDCZYai4kWmVcgydFxK1w89Oe1y24DA0HDtqjSjrIdLwTLM76Fs tqyxl2u4u+e1/dLB/gJ4S7MTGD8g7xr/bRb+VqVnhrUiC6/Yy0xRndsGU0KmhEmUoeLL F9IRaT7ho2nl6La8DjAgcciuHUHoVKoN76z6Kw8mMUCam5CyabdTQKwxsnX3grAmnnvo e/Dg== X-Forwarded-Encrypted: i=1; AJvYcCVwyJpHbyZxOLbNw9iYvfa18Mt6kPQcMi88FeFLS4dbLTq60fyITWv+CzVMlPt/5ioz26NmMcWaoesBveaUSoVRs975Kz4UL3I6UWPt X-Gm-Message-State: AOJu0Yyo+jtjcMsb2+eoB8KSW8qh3g57M68wuMR/6IHbqcCQKXH54yyD SMFiAwq/FPNu3eQue94Fuo73p9MAguJxMV4sUDvikHupctU87tgsO30Q2Mvfgxyl0ks2xNbcFdL WtSpShkdWBLbMKZcwH8F54ikZ0nFtchy1gJYBsg== X-Received: by 2002:a17:906:3656:b0:a68:b8cc:842f with SMTP id a640c23a62f3a-a68b8cc861dmr531801066b.56.1717485311250; Tue, 04 Jun 2024 00:15:11 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240131155929.169961-1-alexghiti@rivosinc.com> <20240131155929.169961-4-alexghiti@rivosinc.com> In-Reply-To: From: Alexandre Ghiti Date: Tue, 4 Jun 2024 09:15:00 +0200 Message-ID: Subject: Re: [External] [PATCH RFC/RFT v2 3/4] riscv: Stop emitting preventive sfence.vma for new vmalloc mappings To: yunhui cui Cc: Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Ved Shanbhogue , Matt Evans , Dylan Jhong , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Yunhui, On Tue, Jun 4, 2024 at 8:21=E2=80=AFAM yunhui cui = wrote: > > Hi Alexandre, > > On Mon, Jun 3, 2024 at 8:02=E2=80=AFPM Alexandre Ghiti wrote: > > > > Hi Yunhui, > > > > On Mon, Jun 3, 2024 at 4:26=E2=80=AFAM yunhui cui wrote: > > > > > > Hi Alexandre, > > > > > > On Thu, Feb 1, 2024 at 12:03=E2=80=AFAM Alexandre Ghiti wrote: > > > > > > > > In 6.5, we removed the vmalloc fault path because that can't work (= see > > > > [1] [2]). Then in order to make sure that new page table entries we= re > > > > seen by the page table walker, we had to preventively emit a sfence= .vma > > > > on all harts [3] but this solution is very costly since it relies o= n IPI. > > > > > > > > And even there, we could end up in a loop of vmalloc faults if a vm= alloc > > > > allocation is done in the IPI path (for example if it is traced, se= e > > > > [4]), which could result in a kernel stack overflow. > > > > > > > > Those preventive sfence.vma needed to be emitted because: > > > > > > > > - if the uarch caches invalid entries, the new mapping may not be > > > > observed by the page table walker and an invalidation may be need= ed. > > > > - if the uarch does not cache invalid entries, a reordered access > > > > could "miss" the new mapping and traps: in that case, we would ac= tually > > > > only need to retry the access, no sfence.vma is required. > > > > > > > > So this patch removes those preventive sfence.vma and actually hand= les > > > > the possible (and unlikely) exceptions. And since the kernel stacks > > > > mappings lie in the vmalloc area, this handling must be done very e= arly > > > > when the trap is taken, at the very beginning of handle_exception: = this > > > > also rules out the vmalloc allocations in the fault path. > > > > > > > > Link: https://lore.kernel.org/linux-riscv/20230531093817.665799-1-b= jorn@kernel.org/ [1] > > > > Link: https://lore.kernel.org/linux-riscv/20230801090927.2018653-1-= dylan@andestech.com [2] > > > > Link: https://lore.kernel.org/linux-riscv/20230725132246.817726-1-a= lexghiti@rivosinc.com/ [3] > > > > Link: https://lore.kernel.org/lkml/20200508144043.13893-1-joro@8byt= es.org/ [4] > > > > Signed-off-by: Alexandre Ghiti > > > > --- > > > > arch/riscv/include/asm/cacheflush.h | 18 +++++- > > > > arch/riscv/include/asm/thread_info.h | 5 ++ > > > > arch/riscv/kernel/asm-offsets.c | 5 ++ > > > > arch/riscv/kernel/entry.S | 84 ++++++++++++++++++++++++= ++++ > > > > arch/riscv/mm/init.c | 2 + > > > > 5 files changed, 113 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/riscv/include/asm/cacheflush.h b/arch/riscv/inclu= de/asm/cacheflush.h > > > > index a129dac4521d..b0d631701757 100644 > > > > --- a/arch/riscv/include/asm/cacheflush.h > > > > +++ b/arch/riscv/include/asm/cacheflush.h > > > > @@ -37,7 +37,23 @@ static inline void flush_dcache_page(struct page= *page) > > > > flush_icache_mm(vma->vm_mm, 0) > > > > > > > > #ifdef CONFIG_64BIT > > > > -#define flush_cache_vmap(start, end) flush_tlb_kernel_ra= nge(start, end) > > > > +extern u64 new_vmalloc[NR_CPUS / sizeof(u64) + 1]; > > > > +extern char _end[]; > > > > +#define flush_cache_vmap flush_cache_vmap > > > > +static inline void flush_cache_vmap(unsigned long start, unsigned = long end) > > > > +{ > > > > + if (is_vmalloc_or_module_addr((void *)start)) { > > > > + int i; > > > > + > > > > + /* > > > > + * We don't care if concurrently a cpu resets this = value since > > > > + * the only place this can happen is in handle_exce= ption() where > > > > + * an sfence.vma is emitted. > > > > + */ > > > > + for (i =3D 0; i < ARRAY_SIZE(new_vmalloc); ++i) > > > > + new_vmalloc[i] =3D -1ULL; > > > > + } > > > > +} > > > > #define flush_cache_vmap_early(start, end) local_flush_tlb_ker= nel_range(start, end) > > > > #endif > > > > > > > > diff --git a/arch/riscv/include/asm/thread_info.h b/arch/riscv/incl= ude/asm/thread_info.h > > > > index 5d473343634b..32631acdcdd4 100644 > > > > --- a/arch/riscv/include/asm/thread_info.h > > > > +++ b/arch/riscv/include/asm/thread_info.h > > > > @@ -60,6 +60,11 @@ struct thread_info { > > > > void *scs_base; > > > > void *scs_sp; > > > > #endif > > > > + /* > > > > + * Used in handle_exception() to save a0, a1 and a2 before = knowing if we > > > > + * can access the kernel stack. > > > > + */ > > > > + unsigned long a0, a1, a2; > > > > }; > > > > > > > > #ifdef CONFIG_SHADOW_CALL_STACK > > > > diff --git a/arch/riscv/kernel/asm-offsets.c b/arch/riscv/kernel/as= m-offsets.c > > > > index a03129f40c46..939ddc0e3c6e 100644 > > > > --- a/arch/riscv/kernel/asm-offsets.c > > > > +++ b/arch/riscv/kernel/asm-offsets.c > > > > @@ -35,6 +35,8 @@ void asm_offsets(void) > > > > OFFSET(TASK_THREAD_S9, task_struct, thread.s[9]); > > > > OFFSET(TASK_THREAD_S10, task_struct, thread.s[10]); > > > > OFFSET(TASK_THREAD_S11, task_struct, thread.s[11]); > > > > + > > > > + OFFSET(TASK_TI_CPU, task_struct, thread_info.cpu); > > > > OFFSET(TASK_TI_FLAGS, task_struct, thread_info.flags); > > > > OFFSET(TASK_TI_PREEMPT_COUNT, task_struct, thread_info.pree= mpt_count); > > > > OFFSET(TASK_TI_KERNEL_SP, task_struct, thread_info.kernel_s= p); > > > > @@ -42,6 +44,9 @@ void asm_offsets(void) > > > > #ifdef CONFIG_SHADOW_CALL_STACK > > > > OFFSET(TASK_TI_SCS_SP, task_struct, thread_info.scs_sp); > > > > #endif > > > > + OFFSET(TASK_TI_A0, task_struct, thread_info.a0); > > > > + OFFSET(TASK_TI_A1, task_struct, thread_info.a1); > > > > + OFFSET(TASK_TI_A2, task_struct, thread_info.a2); > > > > > > > > OFFSET(TASK_TI_CPU_NUM, task_struct, thread_info.cpu); > > > > OFFSET(TASK_THREAD_F0, task_struct, thread.fstate.f[0]); > > > > diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S > > > > index 9d1a305d5508..c1ffaeaba7aa 100644 > > > > --- a/arch/riscv/kernel/entry.S > > > > +++ b/arch/riscv/kernel/entry.S > > > > @@ -19,6 +19,78 @@ > > > > > > > > .section .irqentry.text, "ax" > > > > > > > > +.macro new_vmalloc_check > > > > + REG_S a0, TASK_TI_A0(tp) > > > > + REG_S a1, TASK_TI_A1(tp) > > > > + REG_S a2, TASK_TI_A2(tp) > > > > + > > > > + csrr a0, CSR_CAUSE > > > > + /* Exclude IRQs */ > > > > + blt a0, zero, _new_vmalloc_restore_context > > > > + /* Only check new_vmalloc if we are in page/protection faul= t */ > > > > + li a1, EXC_LOAD_PAGE_FAULT > > > > + beq a0, a1, _new_vmalloc_kernel_address > > > > + li a1, EXC_STORE_PAGE_FAULT > > > > + beq a0, a1, _new_vmalloc_kernel_address > > > > + li a1, EXC_INST_PAGE_FAULT > > > > + bne a0, a1, _new_vmalloc_restore_context > > > > + > > > > +_new_vmalloc_kernel_address: > > > > + /* Is it a kernel address? */ > > > > + csrr a0, CSR_TVAL > > > > + bge a0, zero, _new_vmalloc_restore_context > > > > + > > > > + /* Check if a new vmalloc mapping appeared that could expla= in the trap */ > > > > + > > > > + /* > > > > + * Computes: > > > > + * a0 =3D &new_vmalloc[BIT_WORD(cpu)] > > > > + * a1 =3D BIT_MASK(cpu) > > > > + */ > > > > + REG_L a2, TASK_TI_CPU(tp) > > > > + /* > > > > + * Compute the new_vmalloc element position: > > > > + * (cpu / 64) * 8 =3D (cpu >> 6) << 3 > > > > + */ > > > > + srli a1, a2, 6 > > > > + slli a1, a1, 3 > > > > + la a0, new_vmalloc > > > > + add a0, a0, a1 > > > > + /* > > > > + * Compute the bit position in the new_vmalloc element: > > > > + * bit_pos =3D cpu % 64 =3D cpu - (cpu / 64) * 64 =3D cpu -= (cpu >> 6) << 6 > > > > + * =3D cpu - ((cpu >> 6) << 3) << 3 > > > > + */ > > > > + slli a1, a1, 3 > > > > + sub a1, a2, a1 > > > > + /* Compute the "get mask": 1 << bit_pos */ > > > > + li a2, 1 > > > > + sll a1, a2, a1 > > > > + > > > > + /* Check the value of new_vmalloc for this cpu */ > > > > + REG_L a2, 0(a0) > > > > + and a2, a2, a1 > > > > + beq a2, zero, _new_vmalloc_restore_context > > > > + > > > > + /* Atomically reset the current cpu bit in new_vmalloc */ > > > > + amoxor.w a0, a1, (a0) > > > > + > > > > + /* Only emit a sfence.vma if the uarch caches invalid entri= es */ > > > > + ALTERNATIVE("sfence.vma", "nop", 0, RISCV_ISA_EXT_SVVPTC, 1= ) > > > > + > > > > + REG_L a0, TASK_TI_A0(tp) > > > > + REG_L a1, TASK_TI_A1(tp) > > > > + REG_L a2, TASK_TI_A2(tp) > > > > + csrw CSR_SCRATCH, x0 > > > > + sret > > > > + > > > > +_new_vmalloc_restore_context: > > > > + REG_L a0, TASK_TI_A0(tp) > > > > + REG_L a1, TASK_TI_A1(tp) > > > > + REG_L a2, TASK_TI_A2(tp) > > > > +.endm > > > > + > > > > + > > > > SYM_CODE_START(handle_exception) > > > > /* > > > > * If coming from userspace, preserve the user thread point= er and load > > > > @@ -30,6 +102,18 @@ SYM_CODE_START(handle_exception) > > > > > > > > .Lrestore_kernel_tpsp: > > > > csrr tp, CSR_SCRATCH > > > > + > > > > + /* > > > > + * The RISC-V kernel does not eagerly emit a sfence.vma aft= er each > > > > + * new vmalloc mapping, which may result in exceptions: > > > > + * - if the uarch caches invalid entries, the new mapping w= ould not be > > > > + * observed by the page table walker and an invalidation = is needed. > > > > + * - if the uarch does not cache invalid entries, a reorder= ed access > > > > + * could "miss" the new mapping and traps: in that case, = we only need > > > > + * to retry the access, no sfence.vma is required. > > > > + */ > > > > + new_vmalloc_check > > > > + > > > > REG_S sp, TASK_TI_KERNEL_SP(tp) > > > > > > > > #ifdef CONFIG_VMAP_STACK > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > > > index eafc4c2200f2..54c9fdeda11e 100644 > > > > --- a/arch/riscv/mm/init.c > > > > +++ b/arch/riscv/mm/init.c > > > > @@ -36,6 +36,8 @@ > > > > > > > > #include "../kernel/head.h" > > > > > > > > +u64 new_vmalloc[NR_CPUS / sizeof(u64) + 1]; > > > > + > > > > struct kernel_mapping kernel_map __ro_after_init; > > > > EXPORT_SYMBOL(kernel_map); > > > > #ifdef CONFIG_XIP_KERNEL > > > > -- > > > > 2.39.2 > > > > > > > > > > > > > > Can we consider using new_vmalloc as a percpu variable, so that we > > > don't need to add a0/1/2 in thread_info? > > > > At first, I used percpu variables. But then I realized that percpu > > areas are allocated in the vmalloc area, so if somehow we take a trap > > when accessing the new_vmalloc percpu variable, we could not recover > > from this as we would trap forever in new_vmalloc_check. But > > admittedly, not sure that can happen. > > > > And how would that remove a0, a1 and a2 from thread_info? We'd still > > need to save some registers somewhere to access the percpu variable > > right? > > > > > Also, try not to do too much > > > calculation logic in new_vmalloc_check, after all, handle_exception i= s > > > a high-frequency path. In this case, can we consider writing > > > new_vmalloc_check in C language to increase readability? > > > > If we write that in C, we don't have the control over the allocated > > registers and then we can't correctly save the context. > > If we use C language, new_vmalloc_check is written just like do_irq(), > then we need _save_context, but for new_vmalloc_check, it is not worth > the loss, because exceptions from user mode do not need > new_vmalloc_check, which also shows that it is reasonable to put > new_vmalloc_check after _restore_kernel_tpsp. > > Saving is necessary. We can save a0, a1, a2 without using thread_info. > We can choose to save on the kernel stack of the current tp, but we > need to add the following instructions: > REG_S sp, TASK_TI_USER_SP(tp) > REG_L sp, TASK_TI_KERNEL_SP(tp) > addi sp, sp, -(PT_SIZE_ON_STACK) > It seems that saving directly on thread_info is more direct, but > saving on the kernel stack is more logically consistent, and there is > no need to increase the size of thread_info. You can't save on the kernel stack since kernel stacks are allocated in the vmalloc area. > > As for the current status of the patch, there are two points that can > be optimized: > 1. Some chip hardware implementations may not cache TLB invalid > entries, so it doesn't matter whether svvptc is available or not. Can > we consider adding a CONFIG_RISCV_SVVPTC to control it? > > 2. .macro new_vmalloc_check > REG_S a0, TASK_TI_A0(tp) > REG_S a1, TASK_TI_A1(tp) > REG_S a2, TASK_TI_A2(tp) > When executing blt a0, zero, _new_vmalloc_restore_context, you can not > save a1, a2 first Ok, I can do that :) Thanks again for your inputs, Alex > > > > > Thanks for your interest in this patchset :) > > > > Alex > > > > > > > > Thanks, > > > Yunhui > > Thanks, > Yunhui