Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1431731lqj; Tue, 4 Jun 2024 00:55:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUNm8Yr1viENmYKl2q4MjM3dTwlIg3HjlJOs4eI0IuGC3z84WC1YNAqOknWuRVtQiUt6QUIK+2J4njCKtrYFRy6k4nBJ4WUuNVfR4KuUQ== X-Google-Smtp-Source: AGHT+IHJE6h7HAnut4p/ZSgiZR2JJmNpeuUsOgCh2P5O/p5Vsd50q/JHuUezgaSO4dp44j79vDDK X-Received: by 2002:a2e:9e54:0:b0:2ea:7e39:bd38 with SMTP id 38308e7fff4ca-2ea951de2damr87560471fa.34.1717487730319; Tue, 04 Jun 2024 00:55:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717487730; cv=pass; d=google.com; s=arc-20160816; b=gAJDFgq50woDH0tXZnE110ppHucAUAzAIrsYDNOsre+Zi5Tx/eloDTsjb32HjlBuXi QurA8XHGY5mmDf+Pb+5RVLJvNlkxzlMB2kFzxIWzcyNzmf5SEwSimBe4v0s0V+nrgck7 wBlf203WrPRJwaeRDEMl9mwCkezLTw/lHspPoEPfYnWCL8DKrjnGsJZOdkOaOYVj4QfF MprpOC0nSkvt46spG9LXgekoYmuX8qs+HkuGC7CRVaBXVeH3/Z8d7A1fYcGd/lbTfVWf qfYXvqpVtMHdrRYWQvbbgBloKW6r3LlMB6Mpzzf0FVCndtZ/BtGqYoGN+VQjHiO109eO MyFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=miZ4bOt7QzO27dfJlR2oUMJp0bhbw3eic8qlGuOLk7E=; fh=M5i0JoBjfpZRJwrrqw8OL4wtvn4VxEPAsOclaS2GHig=; b=BJMp5sVUKOlZRCafNmlclZQ9gy6ObKHHwx5AC958i0xduxzCdllxBfQWInzVuCBIWk eaHh+h485CTEbIW35rAra1iQSd0f9oF0fOp/IMNoxg2IHLSOGX4R+ycb/3Bbrf/FJMB5 ch+3F/DeUKGsp2MUylvtqm1+nNMFOoBmURlFQbyTAY48Budf8iZZQX+FsY6nZFLv2JE8 GBu7rtKsHRGiAycUd0rFRwpxzk9RQQQi0qkijR81hzauTyTwA4VIUoGEivJlZzyQNXiN +7GaaR6Dn7XXYT4iIWl18xQF1oDuCf5Nca8j5c912KbmS9eoiQ8Xddy6M5Nctkb+TIMb 71OA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K0anHRPw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-200194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200194-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a68f6c80055si228474066b.138.2024.06.04.00.55.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 00:55:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-200194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K0anHRPw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-200194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200194-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 07BF21F21CAF for ; Tue, 4 Jun 2024 07:55:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5DD351422B4; Tue, 4 Jun 2024 07:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K0anHRPw" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801091420D1 for ; Tue, 4 Jun 2024 07:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487696; cv=none; b=rV7V09eCfyuqgxXWvRSYof56Dgx559VtfxcnLOAFZkbFSCUSOAfqoxbh14MAEysnhQWOkLI93BdK+4SWZ6sicnpgvDwjsx/QTdUt6fgYs9WpBOEZDGlc2rIR/v7eDmDdSWgJ5DCNjpY53emGWWLa740QjxaZRUsMGuG+p7kd4HQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717487696; c=relaxed/simple; bh=2tHtFwFoGoH4ZkoJGvDew8nZKC/G8KnGEPLCqw9Jtuw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=Glz0jt7m3X5A/j8n70CKBATZxgoT6jsvmPuAZUh8xZRSfAf0iFEv9MrUz3bLcnQoYT4sfkiQFrsW2CYGYKVJZRRI8zQtCmnRUj1q4XTFxG0ncwp/xPKKjlaDgmCX62ifn/NRh+CWtouuaxlo8alItt8VCrk/UOww+xafZzquKPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K0anHRPw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AADDFC2BBFC; Tue, 4 Jun 2024 07:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717487696; bh=2tHtFwFoGoH4ZkoJGvDew8nZKC/G8KnGEPLCqw9Jtuw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=K0anHRPwZZJ9yhPag8x0MBgedU8UWdwWipStocGIHVncgp+yyy2mEWUMNun0BfiEh o0lxvPdjHhoD0AtQeisMWfsEm+fVcN197QTeu6g2ZQlGCo5Kd2PAIkKODWjTaW5btx //kDKkgQZblGWmAa9ZDj8oywi+FHjlTH+WeGol5AEWeEtBFi1onCAWZX9I4NiFbfMy R0yrG4rMKv0Uw+cBJT7EEkx17PeNUGZPf/UCbgEPY/HVuPKSHTcTOLpwnSHcB00tn+ OndBeo8aFOMXOpFxzekJ/qotx9Rts3psuD0or03Th65uv3laLN8hMTEQfJ8R1GNgAc uhhLXLXzoOiZw== Date: Tue, 4 Jun 2024 09:54:52 +0200 (CEST) From: Jiri Kosina To: Paul Dino Jones cc: anssi.hannula@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] Interpret 0 length ff effects as infinite (0xffff) length effects In-Reply-To: <20240521220719.niwhskc473he5r5o@zitz> Message-ID: References: <20240521220719.niwhskc473he5r5o@zitz> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 21 May 2024, Paul Dino Jones wrote: > Greetings, > > More and more vendors are entering the force feedback wheel space, and > many are supported well by this driver. Unfortunately a lot of new users > are hitting this issue. > > It would be nice to have this merged. > > I think we all agree a 0 length effect makes no sense, and this change > wouldn't break anything that sends 0xffff. Could you please make the changelog a little bit more structured, namely what is the user-visible problem this patch is fixing, and how / why it is a proper fix. Thanks, -- Jiri Kosina SUSE Labs