Received-SPF: pass (google.com: domain of linux-kernel+bounces-200208-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 4 Jun 2024 10:00:04 +0200
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Andi Shyti <andi.shyti@kernel.org>, Hans Hu <hanshu@zhaoxin.com>, 
	Arnd Bergmann <arnd@arndb.de>, Wentong Wu <wentong.wu@intel.com>, linux-i2c@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: viai2c: turn common code into a proper module
Message-ID: <bi3lwgeh5egvd4g6aspwvefibk3cviwuzinvgkmnwy4f3bvua4@nf5a6w77cr7v>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	Arnd Bergmann <arnd@kernel.org>, Andi Shyti <andi.shyti@kernel.org>, Hans Hu <hanshu@zhaoxin.com>, 
	Arnd Bergmann <arnd@arndb.de>, Wentong Wu <wentong.wu@intel.com>, linux-i2c@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <20240528120710.3433792-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="hzrqra7phcm27hy4"
Content-Disposition: inline
In-Reply-To: <20240528120710.3433792-1-arnd@kernel.org>


--hzrqra7phcm27hy4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 28, 2024 at 02:06:30PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The i2c-viai2c-common.c file is used by two drivers, but is not a proper
> abstraction and can get linked into both modules in the same configuratio=
n,
> which results in a warning:
>=20
> scripts/Makefile.build:236: drivers/i2c/busses/Makefile: i2c-viai2c-commo=
n.o is added to multiple modules: i2c-wmt i2c-zhaoxin
>=20
> The other problems with this include the incorrect use of a __weak functi=
on
> when both are built-in, and the fact that the "common" module is sprinked
> with 'if (i2c->plat =3D=3D ...)' checks that have knowledge about the dif=
ferences
> between the drivers using it.
>=20
> Avoid the link time warning by making the common driver a proper module
> with MODULE_LICENCE()/MODULE_AUTHOR() tags, and remove the __weak function
> by slightly rearranging the code.
>=20
> This adds a little more duplication between the two main drivers, but
> those versions get more readable in the process.
>=20
> Fixes: a06b80e83011 ("i2c: add zhaoxin i2c controller driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Andi, I am tempted to include this in my for-current pull request this
week. Are you okay with this or do you want to review it more closely?


--hzrqra7phcm27hy4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmZeyYQACgkQFA3kzBSg
KbYxrhAAjGLtahAsSRKZR0KV4UQzJCnGB4IHLqh5jGCTvKMNxQxfdvTSUg23MCi/
4MmtcLezzjSmCbd6Z6Apk4za6PxzLRyeSw+rpp7imXh6RSII2QkWAodG7wyU7jir
szjfA58A2pHdCIFcGcNziygwVx+W8kNcn2GRVNMn2NJP2EuyXS+hkMvYh6CdjOVK
VYwkh5jeRjlUt8c2jQ5uMufQvsFF0tuYI87awEiRUSSUU1TjrJDdMfo3+L4wTusi
9y+fNVGfaA4Bsd1bdB3Ex7K/tUCkqh+1QsStMWKiLEr/kfmvTtG7p3wsFZOvU+Rd
dvJ5jYJ34j2aN8XsrFlf7huuNd3TFdDbAPjUV2+ty+ZznqsRi+YCmsjWticWCFs3
nna9B05vIHjcM/4ZU2WRR3NbHJAzhtxjnxOg2HVRvE0RRPVhlTy6C86H1bUnaatK
4KKKT7Xeh/Ounx1XenE0PAsWkOYyoLGM/TDJI67SQI3KS1rL7P2I5wycEc26CfOx
YzRr8d7UZ0gi0jYXvEFsuNUw/kW59PcBUspGAOfqZ7gmuUafWjsAQeFHBCe6iQ0Z
xVR/1O48JqD6neGR8VM6aNhvhSuNzTb5C9APPSAqzut2nJbY29Bj/gtvbodlejUQ
neZtHetUCiGwmXiIW0t1xz+w3FPvD1JgwcCVYz4dfznJmZHmz14=
=mOV+
-----END PGP SIGNATURE-----

--hzrqra7phcm27hy4--