Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp1436844lqj; Tue, 4 Jun 2024 01:07:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVJgr3yLV0XpqIDQmVCHQHwoD5YxYfiJkSwgYGiPLoMa9PHz7K2vVe721BpDmccGo1jTWbrIgzdQwZGtZVjhRAazkHwptPX2Xj3L4XdOw== X-Google-Smtp-Source: AGHT+IFKabaxvUKleRfqBc1xrYajJESMaK/F4dTJjLb6hUh13Kbw7YPPrFaSCwkSxnz4cSc53xwI X-Received: by 2002:a05:6a21:33a1:b0:1b0:58e:1b93 with SMTP id adf61e73a8af0-1b26f0ef87bmr12951232637.1.1717488472916; Tue, 04 Jun 2024 01:07:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717488472; cv=pass; d=google.com; s=arc-20160816; b=FHFoWxvIAggmHC35gL9kh6V4mpRHkD9CrGCy05G4vanptLavfWlVMA5Zqkdwj91oEM 5S0br9R3wFusAiaC0pYtGx3a5ldi4JIUcB9nnnTLBzdcdCXVtsejWfHqiJZxfyM3OdeO B/dAMnMxaiwRIKgCCxFayWjri6oKhHAdx3qMeqSI+J2LciKiX4EMJlWkRizZm4rlKXI9 VGbcNSN3RJUDJBU6eDbK0ggztBIonnNiiT1mLewyzwWhnqprmGmlqARUkCu50N7oqNqi g4JZDqzyURoKhXlpSC5YhIdeOgEGjlhEnxl1DbP/BdVP0X4b8dKlzBUCkQRhZkV2be0Y EI6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=ly4p1bO5fTYf1D2HUojjOEVvzZSKtVu8aHZjMR200Kg=; fh=nJXSD+qTnPC21U/ur9yvLEcgn1GVjah1IBo9kdRh3Zc=; b=YPvxKaJVdthsPKBYd/WKqnm7R/rZONJ2KbcvHDChbOwDfTJ06AaXn9oMASaJZq6oUR lHS8UxBin69JiZEAxXGeZR/4ssl5Gk03X/f4Q06FzP2A59nf42sH/os2x1WhBnq6xMsx qCgy+8mzzNEyA6/Bgbq9ZGkhynNO31XIq5Zs4770MzSWamLQSvTPDHh5q5WjWXiqA2jo /wFYBDMoZ2WT+EkCTiNocQTHt/yhn8HrvvIiyh9y9kkQ3xB/D8WaXXGTJ2upGCTe1sF4 bYkI1i0LFuOL50Pyinshmm5A1/FhYwwJTAEEu/7Td7veSaBSEJtjnUrdAiIzXJI+qWrG fYOQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TGmz9GiK; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-200216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200216-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-702423e011dsi1498707b3a.58.2024.06.04.01.07.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 01:07:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-200216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TGmz9GiK; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-200216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200216-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D6BF5B210B0 for ; Tue, 4 Jun 2024 08:07:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6DA311419A9; Tue, 4 Jun 2024 08:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TGmz9GiK" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D95D14037D for ; Tue, 4 Jun 2024 08:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717488461; cv=none; b=XS8ukKBrp4pa1aXmxahrmh8LRj37UKRSIeA241gjCKZJ4HHoc26fegEshQK0yR9QWYLtnkqjUtz5YJhvGqacfJML1ut98AAbD40EiOrfxZcBnpKdNLjGkswRAwXD5XSw5pBxeWfyru6zZpkOt5sVmeXitT+fgJdbbzrSuQhKi6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717488461; c=relaxed/simple; bh=6VvwTmL/3EypXRA4BAhEkXWksAeExpK4qbL7mEpPVes=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=g387eiEx2oQqOlD3HlGP8l7weIGkGU/B+ID+gP8z79tnXO8wd8erIDPGIRU5k8wDDPNbg5bff3kXuX/Sa8zYcNMG/NmV/1lVU0rL/AEU5KWi33T4eJkabj8rAX1Sq/5qM/i1zHB4tqSbtpYQYwN1DmLCRx7PDcTzw2KVogMvu+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TGmz9GiK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717488458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ly4p1bO5fTYf1D2HUojjOEVvzZSKtVu8aHZjMR200Kg=; b=TGmz9GiKPbSC8iZn9IwIvS7lm/yypiROb/R+8O3yW6CQ16m2rEH4yffuV5yGcXQnXctUf/ xsHujWN2Fli5ZO6GPSi2XizWNI137FIgE7mjbL26kqhZ/BEneoL3VWeFlJHBFlvEgaoikk g2+nCIMjWe/0O736GgpvWWWudQY/c/M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-jusTqdGuN8qYs_T3L9Ct-Q-1; Tue, 04 Jun 2024 04:07:36 -0400 X-MC-Unique: jusTqdGuN8qYs_T3L9Ct-Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42129affd18so25450795e9.1 for ; Tue, 04 Jun 2024 01:07:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717488455; x=1718093255; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ly4p1bO5fTYf1D2HUojjOEVvzZSKtVu8aHZjMR200Kg=; b=KEUq9ZATIF+px93oNyM7l8DUDkJAfLFMu+CvssGCkAgvQ6YYoM2c59IOWnxShympF6 c1d5ZkpTs4rN0nIefs4PhHAP5wF1rQpniP07xkV+CFw/PjYNpVQAKVNi//gJWSyw7wAI 1L5akGC5s4MiYJ6c7tNsuqtz0WNBDhMvBDzh/qHg5iq3/qS6NTmtumtd3cCt/lOCdNVW /2bIx9ffIfPyYePBD+wL42+0tGO+SM0cGr1ZeG+dhxtElylKTGzXWGRuUVgHTvrn7xpy 8NY8xwfOjqKzH/oF3QJ2PUmyiRR46bva8l4EK+BKEy4NfBvd6VDOkAUyKcI1kK/plZU0 +jwg== X-Forwarded-Encrypted: i=1; AJvYcCWWsQDypbGLoUUYi7Ju1QvgGjaAnTFZKL97DsABnuPQFjQy7BUghifMcUOPsii+I4CYmAz90gx/c1MVeOvmaQnO63RCH1p0AKkXBntR X-Gm-Message-State: AOJu0YzABD82BCZSRZzkBu4sEj+M7eK8nCbCJ6FU220qeqex8gvD/UUZ GzqVEWr5dIChOWkd+9Vm8ckuItNFTh1T0gQ848Y81lb6NOVAfYPo6kTJBGrjwuMRB/ZjpSTdOcq 9ga9sSRY5ELmDxXW4rkqOGTshiCwDpoEI7SJ3nvrsBaGiRRzEqnMLdW6L0Tv2dA== X-Received: by 2002:a05:600c:46d3:b0:41f:e4ad:9ae4 with SMTP id 5b1f17b1804b1-4212e076433mr84478855e9.23.1717488455233; Tue, 04 Jun 2024 01:07:35 -0700 (PDT) X-Received: by 2002:a05:600c:46d3:b0:41f:e4ad:9ae4 with SMTP id 5b1f17b1804b1-4212e076433mr84478705e9.23.1717488454812; Tue, 04 Jun 2024 01:07:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42135fea176sm106380295e9.24.2024.06.04.01.07.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 01:07:34 -0700 (PDT) Message-ID: <9ca730ce-2b2f-42d2-8c7a-78735a995c64@redhat.com> Date: Tue, 4 Jun 2024 10:07:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] mm/ksm: reduce the flush action for ksm merging page To: alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-2-alexs@kernel.org> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240604042454.2012091-2-alexs@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04.06.24 06:24, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > We can put off the flush action util a merging is realy coming. That > could reduce some unmerge page flushing. > BTW, flushing only do at arm, mips and few other archs. > I'm no expert on that flushing, but I thought we would have to do the flushing before accessing page content -- before calculating the checksum etc. Now you would only do it before the pages_identical() check, but not when calculating the checksum. -- Cheers, David / dhildenb