Received-SPF: pass (google.com: domain of linux-kernel+bounces-200233-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 4 Jun 2024 10:16:41 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
To: =?ISO-8859-15?Q?Jos=E9_Exp=F3sito?= <jose.exposito89@gmail.com>
cc: bentiss@kernel.org, lains@riseup.net, linux-input@vger.kernel.org, 
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-dj: Fix memory leak in
 logi_dj_recv_switch_to_dj_mode()
In-Reply-To: <20240524130600.275577-1-jose.exposito89@gmail.com>
Message-ID: <nycvar.YFH.7.76.2406041016330.16865@cbobk.fhfr.pm>
References: <20240524130600.275577-1-jose.exposito89@gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 24 May 2024, Jos=C3=A9 Exp=C3=B3sito wrote:

> Fix a memory leak on logi_dj_recv_send_report() error path.
>=20
> Fixes: 6f20d3261265 ("HID: logitech-dj: Fix error handling in logi_dj_rec=
v_switch_to_dj_mode()")
> Signed-off-by: Jos=C3=A9 Exp=C3=B3sito <jose.exposito89@gmail.com>
> ---
>  drivers/hid/hid-logitech-dj.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.=
c
> index 3c3c497b6b91..37958edec55f 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1284,8 +1284,10 @@ static int logi_dj_recv_switch_to_dj_mode(struct d=
j_receiver_dev *djrcv_dev,
>  =09=09 */
>  =09=09msleep(50);
> =20
> -=09=09if (retval)
> +=09=09if (retval) {
> +=09=09=09kfree(dj_report);
>  =09=09=09return retval;
> +=09=09}
>  =09}

Applied, thanks.

--=20
Jiri Kosina
SUSE Labs