Received-SPF: pass (google.com: domain of linux-kernel+bounces-200242-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 4 Jun 2024 10:21:21 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
cc: "Daniel J. Ogorchock" <djogorchock@gmail.com>, 
    Benjamin Tissoires <bentiss@kernel.org>, 
    Martino Fontana <tinozzo123@gmail.com>, 
    Ryan McClelland <rymcclel@gmail.com>, linux-kernel@vger.kernel.org, 
    kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: nintendo: Fix an error handling path in
 nintendo_hid_probe()
In-Reply-To: <9e599978852f9a2f30f9523edfd220dd1e25aa63.1716735907.git.christophe.jaillet@wanadoo.fr>
Message-ID: <nycvar.YFH.7.76.2406041021130.16865@cbobk.fhfr.pm>
References: <9e599978852f9a2f30f9523edfd220dd1e25aa63.1716735907.git.christophe.jaillet@wanadoo.fr>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sun, 26 May 2024, Christophe JAILLET wrote:

> joycon_leds_create() has a ida_alloc() call. So if an error occurs after
> it, a corresponding ida_free() call is needed, as already done in the
> .remove function.
> 
> This is not 100% perfect, because if ida_alloc() fails, then
> 'ctlr->player_id' will forced to be U32_MAX, and an error will be logged
> when ida_free() is called.
> 
> Considering that this can't happen in real life, no special handling is
> done to handle it.
> 
> Fixes: 5307de63d71d ("HID: nintendo: use ida for LED player id")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs