Received-SPF: pass (google.com: domain of linux-kernel+bounces-200275-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Wu, Wentong" <wentong.wu@intel.com>
To: Hans de Goede <hdegoede@redhat.com>
CC: "Rafael J . Wysocki" <rafael@kernel.org>, Sakari Ailus
	<sakari.ailus@linux.intel.com>, "Winkler, Tomas" <tomas.winkler@intel.com>,
	Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, "linux-acpi@vger.kernel.org"
	<linux-acpi@vger.kernel.org>, Kate Hsuan <hpa@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mei: vsc: Fix wrong invocation of ACPI SID method
Thread-Topic: [PATCH] mei: vsc: Fix wrong invocation of ACPI SID method
Thread-Index: AQHatffIyjLwaCewn0OVu05BGV798rG3TAKA
Date: Tue, 4 Jun 2024 08:50:07 +0000
Message-ID: <MW5PR11MB57872D175B07988AF791E7558DF82@MW5PR11MB5787.namprd11.prod.outlook.com>
References: <20240603205050.505389-1-hdegoede@redhat.com>
In-Reply-To: <20240603205050.505389-1-hdegoede@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uGg0yP64WIFdsn8pg8KJk4gWdAg10wkRS66i+VQvcEhYyyLKjDJqpU60z9Na?=
 =?us-ascii?Q?E4J71lTJxwUUBph8gPmc67HvFsqbEamhw86xQD2jhbUujn6Ka5oiVREbLiOz?=
 =?us-ascii?Q?eSNl3RyRCZjxrKYeG9VPNPfRHqsY29P6EWS5fXGHLOFc8WhNm6Rihrwvf0ZU?=
 =?us-ascii?Q?7pvXGspnB9l94WjYGbH6OoX/ft124SYOm77v4lkAMsSOK6s1fHfmVpgeDHsx?=
 =?us-ascii?Q?qpA2oT1oc+eTaYM/DST0TAK4LhuN6Kkx/XZQNsfn1QbRGZBDxv+n1FMKiR9b?=
 =?us-ascii?Q?csbKM1K3v73YRNDLxKgFBpjGDS+K0NxUr34Dmis2YdugYMmxqyxrHadz0zNQ?=
 =?us-ascii?Q?KUlEWobN0XJeFSRhU1FykmI0h/Thg0TgGdvh9gboS4Mr8UvidV9xZSZ+wmiP?=
 =?us-ascii?Q?IdRE9dcOEJPblGonAkaw8oscy51r4xZcED9FPxxTbN9jsbKzSZF3bUmb65t7?=
 =?us-ascii?Q?o4PQIdmduqeuLgXSiMC6Xr2K0Cq1QgyzhNwH4PkLZqqQ5n1ct+6CRuuGSLMY?=
 =?us-ascii?Q?kzA3+V9Yp7kFJzCHhOPpDbKCCPRtujelw0oEVSJlQQ/zTaJ1GD2o/rR/vpLk?=
 =?us-ascii?Q?0TGpzY7OLgeyIj5uGKFM3XnZ6uNb/7VZ/z3ioctTo9XDyHmbLKKrZUec/n8b?=
 =?us-ascii?Q?W4zsBBeXMujVyYkw7gfo9OVbepu9Ft7TqiQe6sgkvVyy0+aPVwgaXxEMEiID?=
 =?us-ascii?Q?WJqJPmg7vFRAMokHvoGxgQcou51P11eHUBQBfeMFeHmcLvEUfP7Gu8yi5XVs?=
 =?us-ascii?Q?EZ1SrqNcqEh/IkXwNfqkqk8DfaywgDWrqP4kwWnXGWr7XhTXPN4/xx5WCnFr?=
 =?us-ascii?Q?AEVEgpJtIxFXQb0m/3GYD1ZZ+i1heorZdNhVrCDAvtAIeid7SLBpDD1cNBx3?=
 =?us-ascii?Q?ffNmCosV3ggiL17thXTtlV0vBYVOll5mVPVpvZSvKJHpHgEWODNLCwjCTZuJ?=
 =?us-ascii?Q?QJhCy5IzEm7uTcq4KSV7UhmbZoaA/K7UqfdbBQvNIEIOrOl1KYRMcGhCdkBV?=
 =?us-ascii?Q?U7nP76PVSYEjzIfEID8q5x+1e8RkpmnLNb2zRP8WYxk5+/YZtA7UCeZb5YI7?=
 =?us-ascii?Q?sfmM9Q5whQZNhF3eegUDi3pFNvglDym0iNPU8RGkRezRYYggdqVx+gr6NZwc?=
 =?us-ascii?Q?C8EdfS1xbSu5KHFDmFvA233tHh/UvOJ8gz4IHO590eZEVnzrDM5L7+8epsYM?=
 =?us-ascii?Q?6pN0S3LI9U0X7jnFAuiWvTWpOKX9pQ/pkgByiActGUujYoan0IFkiOA6SAv7?=
 =?us-ascii?Q?qybnRzTHE2xRyt2ob+/MRns5xnNHg9MnKJmkCXBRBTUuBHxaY8e5Nk6PXQhs?=
 =?us-ascii?Q?54ngxIzSo0qhI/NHPMFAKdT/nq6+0O6Ycvp+VFtq0cy5EdGk6eciDMcLMj1Q?=
 =?us-ascii?Q?d9/cAGfeJrM/6mnaRh+7seiUrty08pFDhK0y7YNd0lm+cAZXJEShX7QkRpjp?=
 =?us-ascii?Q?L8ujTwjgKFUPTCf8qefOKzbpkfxWHX5GUfUAGT/wgpFrgCD9/lnpo9aVnUeW?=
 =?us-ascii?Q?9WrRTECg7vACjkfJFUoAoMqqqTmyrPwaRIZVImldtarN8DpV8PuJilCHlI+Z?=
 =?us-ascii?Q?ZVvmLfZhU7hfV4f1H2bp2AwWR4se5xPEBhRQkOhL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5787.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8095b5d3-e219-4285-e841-08dc847355b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2024 08:50:07.3462
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X7H92P0bFCwIjmkx1TvTbaQNvv8qdg0G8sfs0ZCLeEFleseT5hWLbVAuSFWDj+ZtkRtOHxlSRxM5p2OindaKQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8733
X-OriginatorOrg: intel.com

> From: Hans de Goede <hdegoede@redhat.com>
>=20
> When using an initializer for a union only one of the union members must
> be initialized. The initializer for the acpi_object union variable passed=
 as
> argument to the SID ACPI method was initializing both the type and the
> integer members of the union.
>=20
> Unfortunately rather then complaining about this gcc simply ignores the f=
irst
> initializer and only used the second integer.value =3D 1 initializer. Lea=
ving type
> set to 0 which leads to the argument being skipped by acpi
> acpi_ns_evaluate() resulting in:
>=20
> ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Call=
er
> passed 0, method requires 1 (20240322/nsarguments-232)
>=20
> Fix this by initializing only the integer struct part of the union and in=
itializing
> both members of the integer struct.
>=20
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Reviewed-by: Wentong Wu <wentong.wu@intel.com>

> ---
> Even though this is a one-liner, figuring out what was actually going wro=
ng
> here took quite a while.

Thanks a lot

BR,
Wentong
> ---
>  drivers/misc/mei/vsc-fw-loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/misc/mei/vsc-fw-loader.c b/drivers/misc/mei/vsc-fw-
> loader.c
> index ffa4ccd96a10..596a9d695dfc 100644
> --- a/drivers/misc/mei/vsc-fw-loader.c
> +++ b/drivers/misc/mei/vsc-fw-loader.c
> @@ -252,7 +252,7 @@ static int vsc_get_sensor_name(struct vsc_fw_loader
> *fw_loader,  {
>  	struct acpi_buffer buffer =3D { ACPI_ALLOCATE_BUFFER };
>  	union acpi_object obj =3D {
> -		.type =3D ACPI_TYPE_INTEGER,
> +		.integer.type =3D ACPI_TYPE_INTEGER,
>  		.integer.value =3D 1,
>  	};
>  	struct acpi_object_list arg_list =3D {
> --
> 2.45.1