Received-SPF: pass (google.com: domain of linux-kernel+bounces-200303-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1a27c18a-e500-434f-b3ca-af1d3dedba41@intel.com>
Date: Tue, 4 Jun 2024 11:05:26 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 net-next] net: hsr: Send supervisory frames to HSR
 network with ProxyNodeTable data
To: Lukasz Majewski <lukma@denx.de>, Jakub Kicinski <kuba@kernel.org>,
	<netdev@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>
CC: Eric Dumazet <edumazet@google.com>, Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>, Oleksij Rempel
	<o.rempel@pengutronix.de>, <Tristram.Ha@microchip.com>, "Sebastian Andrzej
 Siewior" <bigeasy@linutronix.de>, Ravi Gunasekaran <r-gunasekaran@ti.com>,
	Simon Horman <horms@kernel.org>, Nikita Zhandarovich
	<n.zhandarovich@fintech.ru>, Murali Karicheri <m-karicheri2@ti.com>, "Arvid
 Brodin" <Arvid.Brodin@xdin.com>, Dan Carpenter <dan.carpenter@linaro.org>,
	"Ricardo B. Marliere" <ricardo@marliere.net>, Casper Andersson
	<casper.casan@gmail.com>, <linux-kernel@vger.kernel.org>, Hangbin Liu
	<liuhangbin@gmail.com>, Geliang Tang <tanggeliang@kylinos.cn>, Shuah Khan
	<shuah@kernel.org>, Shigeru Yoshida <syoshida@redhat.com>
References: <20240604084348.3259917-1-lukma@denx.de>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240604084348.3259917-1-lukma@denx.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkxGd0g4blhqMkIwUzI1NXl4bGd0NHVjU0N6ZUJTLzA4d2VrWEhZZFpKekVF?=
 =?utf-8?B?V3BuU1djdnVDTzM0SW84OGxqZE1KM0lKUjZXRWRPNXdpN3IzQzlEeEZ1VFUy?=
 =?utf-8?B?V20vd1pZY3BFRlQ5YzlmaW5yK2ZrdzlaMUwzYVNEaWYyR1dOaS95aElvY2ta?=
 =?utf-8?B?WmtRbVFKL2RjY0JOYUh0bmJjZW5tdXV3Y0svU21zT0hlK1NXM3cwWDFaN1ht?=
 =?utf-8?B?VW5tSFV0OHh3ZW8vSDFnZCtnd3h0TVNRSFk5Z1NacnlKWitOenZCSEthMnlq?=
 =?utf-8?B?N3oydmh3MXNpQm5yWFM5Rmg2cWVaMlYzaDNzeWN4VHdJK3B6bnN6cVl4NGlE?=
 =?utf-8?B?c2JSOTFEY0xZVGMyY1FsSWhqTDZQN3c1RDdRNEVESUcvelJVMWJRc2pQUVBX?=
 =?utf-8?B?bmMzNEVBUTY3VVJIeURYenk5SnpyOVRVWmtUY2t2RzBlMFRHZXFhVnQvd0w1?=
 =?utf-8?B?RFFJOEt3MmoraHA2NlJERkFWZ2Q3NzM5dURqcnEwbWFwWVhVd255K0g1dnd4?=
 =?utf-8?B?cmdIcFF4U2t4VkpWNm4xRUxoZk9heEV0d2FURkJWWHEzMFV0SjljU1RWOVRM?=
 =?utf-8?B?cVIzRHZkbHN1a1l2dGZibU5XVzhNY3VYL2FQcnRnMm9QTmFOV3g2U05ZRnFG?=
 =?utf-8?B?ajRlNzZ4ZFptWkVWSUFpMnpZMy9rVEx6cUFFcU9zclFlYkZKYVlVcjI0bHVX?=
 =?utf-8?B?N3ZxaWtZK2kxN3BVZDJmd1VBTm5CbVZkWXJSTWNNc1g0UW94VW9Qb1hPZ29J?=
 =?utf-8?B?dmVMMzVWWXE2Ni9HTWdxNE1DZlRyVG40c0Zmd0JtOXpGT0g2VXlVMStOVU54?=
 =?utf-8?B?WEZCUVhMdXJYYnpERzJHbk9GdmFSbHR2bm43YVYvWGJWMGZocEhUZWYvOTZm?=
 =?utf-8?B?N096Uiswd0RUTDJKQXkvTHJDSjVmbS9FbDFtakY5N0ExNDl2ZVUrbHVrenlM?=
 =?utf-8?B?TC9iTC9TL1M0S0pVOEY5MWNJRkorYmlIZU9veFVEaWVLOWNFeVRoVzB1TkVG?=
 =?utf-8?B?anJybU50UjFFeW9ZSTB0WEI4VERiQlJUV05pSTVsdWI3SkFUUUxMYmRnNHBi?=
 =?utf-8?B?a3NqM05uQkkvRytzNkR2UVFZL1hHWnA2djlkdWtuYWRWbXkzRGZybFFmN1hu?=
 =?utf-8?B?WFJONFRCRlN5dmZ6MmdKK2J6eTduQk5IdE5pWjhnSGVtNmxxYXFPN09uTm9m?=
 =?utf-8?B?dkhzSVRiT3lXY0pQQloyUG1RYmcvZk55K3E5aDg2ZGNVb1E2Vi9BZ2licjdF?=
 =?utf-8?B?cHZHazBCTG8rZnZOWThLWE1ObXpVV2tPbnFxVC9uVE40TEVJdElrZDZTaGZB?=
 =?utf-8?B?blF2aTJuZTFMUlZocHJVWXpzQklLRUtNajBFZlc4NnUrOEV3WUVVTzRjVEt3?=
 =?utf-8?B?SHhHZXlYQmVONWlpUEFHb0pGd2JrL2ZXWFRkb3lXa0g3emtHVi9aMWw1clhW?=
 =?utf-8?B?SEF4VGpTeHlnYngwdmFmL3hGK3R5Q0pFcXBjVFJQNmFnV1drc3M5REsyOTZp?=
 =?utf-8?B?cFZVc2lkTGRuYld6bHEzR0J3VjlKamcrQS9uWERJS2d3aFdoVTkvMllwTEhK?=
 =?utf-8?B?NGdoUXFZT2VOb2ptbzJjaEt5YU0zcUwzWUNWVDRYYWVScHNMLzhnMWlEZXBr?=
 =?utf-8?B?WVY1WU56V2k2S3JSQWFwd2xqY0x1ZTZxOUZhajIwWXp5c0t5cTJWcVFUZmln?=
 =?utf-8?B?bFRuaHRUVDJUWDJINGVpeXhxKy83UGo5dFlHQXRRWGtEbmV6WGF6UWw0ZGxs?=
 =?utf-8?B?d002UmxpbStFallXM2lJMnpIeTFIcXR6MmVabmh5ZmlKS2VCdWRkQmRoRUJ6?=
 =?utf-8?B?VStMYUp4bXFTcVhFVThRaHdiM0lJam9TMUlyM3NVanVUL3Y5K2R3SGtSaXdT?=
 =?utf-8?B?YUpMUXlDeEo0V09Nb2Z2VE9mdG1STXArRjladHo1UjVWbWdOZ1JXNjNCQVZp?=
 =?utf-8?B?RWRJN1FidWhNV2FWemUwc3B0R2NRR2g4ZnRDTUVsV0NsV01aNDFLQWJ1V1V5?=
 =?utf-8?B?WU91ekhRSXI5SzFzVi8wQ0ZsRisyOVdHOFA5MzJ0K3B3aEtsSjE3VlUxelFz?=
 =?utf-8?B?N1pqRlUvQ0sxVE96cFppU3F0aEI1TE0vOHJrQVo2ak42NkljQzJGRWFWMXJs?=
 =?utf-8?Q?bf6j7ONzb9EYTUamSuaNKCcgr?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a2f7d222-0083-44a4-981e-08dc84757f2d
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 09:05:36.2207
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7NhcesMWzzFrGHhyyZJw9+4VVjbAYRBxzNLY5xS3jz154Rc1gwgpHyDL15aOOy8w8Iq6+SQuLv7Pe9X3M6JWfzbMu2S4LtVyNONaLfL69cc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6210
X-OriginatorOrg: intel.com


On 04.06.2024 10:43, Lukasz Majewski wrote:
> This patch provides support for sending supervision HSR frames with
> MAC addresses stored in ProxyNodeTable when RedBox (i.e. HSR-SAN) is
> enabled.
> 
> Supervision frames with RedBox MAC address (appended as second TLV)
> are only send for ProxyNodeTable nodes.
> 
> This patch series shall be tested with hsr_redbox.sh script.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> 
> Changes for v2:
> - Fix the Reverse Christmas Tree formatting
> - Return directly values from hsr_is_node_in_db() and ether_addr_equal()
> - Change the internal variable check
> ---

Thx,
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  net/hsr/hsr_device.c   | 63 ++++++++++++++++++++++++++++++++++--------
>  net/hsr/hsr_forward.c  | 37 +++++++++++++++++++++++--
>  net/hsr/hsr_framereg.c | 12 ++++++++
>  net/hsr/hsr_framereg.h |  2 ++
>  net/hsr/hsr_main.h     |  4 ++-
>  net/hsr/hsr_netlink.c  |  1 +
>  6 files changed, 105 insertions(+), 14 deletions(-)
> 

<...>