Received-SPF: pass (google.com: domain of linux-kernel+bounces-200346-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 4 Jun 2024 11:24:55 +0200
From: Johan Hovold <johan@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Johan Hovold <johan+linaro@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Sanyog Kale <sanyog.r.kale@intel.com>, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] soundwire: bus: drop redundant probe debug message
Message-ID: <Zl7dZ-4ysKC-jSA6@hovoldconsulting.com>
References: <20240604075213.20815-1-johan+linaro@kernel.org>
 <20240604075213.20815-5-johan+linaro@kernel.org>
 <e1c63097-b628-4c97-add6-40fa479a7806@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e1c63097-b628-4c97-add6-40fa479a7806@linux.intel.com>

On Tue, Jun 04, 2024 at 10:37:17AM +0200, Pierre-Louis Bossart wrote:
> On 6/4/24 02:52, Johan Hovold wrote:
> > Drop the redundant probe debug message which is already provided by
> > driver core. Whether probe succeeded can also be determined through
> > sysfs.

> > @@ -152,8 +152,6 @@ static int sdw_drv_probe(struct device *dev)
> >  
> >  	mutex_unlock(&slave->sdw_dev_lock);
> >  
> > -	dev_dbg(dev, "probe complete\n");
> > -
> >  	return 0;
> >  }
> 
> I don't see the point of removing this, we've used it for the last 5
> years to figure out when the probe complete vs. when the device becomes
> attached. It's a simple log that helped us immensely with race
> conditions, etc.

Fair enough. Soundwire probing is indeed a bit of a mess.

Johan