Received-SPF: pass (google.com: domain of linux-kernel+bounces-200336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240523211437.2839942-1-jwylder@google.com> <ZlwfQ3ERbo5snLcK@surfacebook.localdomain>
 <37abbb4e-cac4-4278-98fb-0af75e5b3ef4@sirena.org.uk>
In-Reply-To: <37abbb4e-cac4-4278-98fb-0af75e5b3ef4@sirena.org.uk>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 4 Jun 2024 12:15:33 +0300
Message-ID: <CAHp75Vfgu0eXXJ_FTgMC-VUzTRSo7zoA4C9j3WsevPzhajpDSA@mail.gmail.com>
Subject: Re: [PATCH v2] regmap-i2c: Subtract reg size from max_write
To: Mark Brown <broonie@kernel.org>
Cc: Jim Wylder <jwylder@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, kernel-team@android.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 3, 2024 at 3:08=E2=80=AFPM Mark Brown <broonie@kernel.org> wrot=
e:
>
> On Sun, Jun 02, 2024 at 10:29:07AM +0300, Andy Shevchenko wrote:
>
> > >                 (bus->max_raw_write =3D=3D 0 || bus->max_raw_write > =
quirks->max_write_len))
> > > -                   max_write =3D quirks->max_write_len;
> > > +                   max_write =3D quirks->max_write_len -
> > > +                           (config->reg_bits + config->pad_bits) / B=
ITS_PER_BYTE;
>
> > Interesting. regmap-spi does this slightly differently, i.e. reg/8 + pa=
d/8.
> > I'm wondering which one is more correct (potential off-by-one I suppose=
).
>
> The above seems more correct if we have less than a full byte of padding.

Hmm... So, if we have

bits    pad  x/8+y/8 (x+y)/8
4..7    0..3    0      0  // x + y from 4 up to 7
4..7    4..7    0      1  // x + y from 8 up to 11
4..7   8..11    1      1 // x + y from 12 up to 15
8..15   0..7    1      1 // x + y from 8 up to 15
8..15  8..15    2      2 // x + y from 16 up to 23

The only difference AFAICS is the case 2.
Do we need to patch regmap SPI for that?

I think SPI just works since we don't really have devices that use
less than 8 bits per register, and hence we never enter into such a
case (while I2C is naturally using 7-bit addresses).

--=20
With Best Regards,
Andy Shevchenko