Received-SPF: pass (google.com: domain of linux-kernel+bounces-200389-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To: Ricky Wu <en-wei.wu@canonical.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@intel.com>
CC: "pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
	"michal.swiatkowski@linux.intel.com" <michal.swiatkowski@linux.intel.com>,
	"Drewek, Wojciech" <wojciech.drewek@intel.com>,
	"intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
	"rickywu0421@gmail.com" <rickywu0421@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"edumazet@google.com" <edumazet@google.com>, "Lien, Cyrus"
	<cyrus.lien@canonical.com>, "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, "kuba@kernel.org"
	<kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net, v2] ice: avoid IRQ collision to fix
 init failure on ACPI S3 resume
Thread-Topic: [Intel-wired-lan] [PATCH net, v2] ice: avoid IRQ collision to
 fix init failure on ACPI S3 resume
Thread-Index: AQHaspy+X31HbyaOiUixyJ0gaZlPy7G3ZF7g
Date: Tue, 4 Jun 2024 09:55:27 +0000
Message-ID: <CYYPR11MB842939BAE38A750C13775B17BDF82@CYYPR11MB8429.namprd11.prod.outlook.com>
References: <20240530142131.26741-1-en-wei.wu@canonical.com>
In-Reply-To: <20240530142131.26741-1-en-wei.wu@canonical.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N0HLWEr9Zk/RTMa7dAUavjlfntm4h+OsTgBMWHq2KqxYAOwfathYsWBThAkp?=
 =?us-ascii?Q?esO7h67QXSU7Rzk5rY6Qe1KBqwe9+WC4yXyS+KC3LSCZJuh7d6+pSlgLq7tt?=
 =?us-ascii?Q?ty1LCJzpOoFgMysxhJRfURGB7fzgFhPwd/O19SVjPtQ+Q57p0Qt91ZDXeRkF?=
 =?us-ascii?Q?v9opJUgNZeudIIdpnH1ka1xgyFxmVRarobuZz2ohG5qUT1UuWIYsiP96xL16?=
 =?us-ascii?Q?VZZCgqJpX7atmm9gwrpDXAMS8RAJxaikQJZ55gjKqcRb77JzdlUvSODNR9PH?=
 =?us-ascii?Q?kFQvQ0pv7TPO4TRplVTQIjklIXogj4sRgnSTrd3MaUEPVOcUaW9WMijK8b7I?=
 =?us-ascii?Q?II/64GIDXVCLOVo8ifolriw6Hcb+Yr3OLqj2t5/9FOseE2tXorhWlskj0Kfu?=
 =?us-ascii?Q?v/ndEwRly0LcTmH+iBjO1sjq2I04D7CecKLwJJxCYkjY/dPCL+6cg2YjG28g?=
 =?us-ascii?Q?9ouCBFtW6jI8XKceyYlHX5WnY83P1+8GyHl9nUVtUzlv0u4qyS94bCbPnk7n?=
 =?us-ascii?Q?L71IJABCBJEcwStuCNbbWXI3VI70gzQfTY4ddpPX0AmOTf7YuHv3JKso8RIY?=
 =?us-ascii?Q?2E1z54lFi2uUaipyo0faT/cOSNvgvT1fQ9wJMiskxdqo7kg3cIxqqN23RqEQ?=
 =?us-ascii?Q?EDwpkp5/H1zkzkYwEbqGtdQoU0cynaRwQbIKG1dDPAmvxuPMQZ5ycJupDmPM?=
 =?us-ascii?Q?RULfz3eRCMkaFljyPncj8dfL69w6XWY8ioZtqPzd5pAPhLZBqI60mUrAfKmW?=
 =?us-ascii?Q?e4DYvB1MYyO0F3eYE5kHYm5FcpKog7roDapRplDkdyCLLrSoPJdJ7Up7TaPl?=
 =?us-ascii?Q?8WGHrtB1dzaAsuw7TJehY6V+liP2CkRcdegD8C7LBHSAeDZcAqpNT0+d0KYS?=
 =?us-ascii?Q?SgWJ2AeCjRT8vAq/XC3hH2LwfdFdvlByXomYeCdbC+CUburVT+rOAnNIohAl?=
 =?us-ascii?Q?vqZwUGnGksg9XsdIzTuh4Wimfuw2rXcX/1JuzfBduXnP6h8wyfGu8WGesKAG?=
 =?us-ascii?Q?SsA9MH30/NTKbRTDjoRIUGgM3hWolf0MWLmqjZMvIwek1+UUb+BhmBYF+210?=
 =?us-ascii?Q?PCEHfgVva7f5vcHC+3QPebtyRn2HzJ3trUwZwSYY/2CuGvbpCopiZZnG4tDX?=
 =?us-ascii?Q?cWoG+GR6lCn8r07T9q0l9GxmXLDl74tZC22Fn2Fi1/o+mEjZ1CeT0dyDrwqo?=
 =?us-ascii?Q?AshzB54/vi2BNRKDCNzTCB5TSWG0AtUtKIt2gPk70zl7PmG7XLwopTQgzNyB?=
 =?us-ascii?Q?56vU/8/91YwLwYfP83UrAzqTAXwhCTloMXSL5zBPiz4RnzZwoisYSku89zJX?=
 =?us-ascii?Q?E3JALmvS88h0CvK+/jtlW12vkC9EE9EK5ZkPEyc2GNS/ZYL3w0GZb6oGLXw9?=
 =?us-ascii?Q?WYbPm8bFRPC6z5l5fIHZp0x5nJgvtYwk2MbcWKyi3dXqvYJhj8nnmeZVO6fc?=
 =?us-ascii?Q?Blas8tTw+29VpLSSORgA/AHcbg0e4av/XoNR6gWInQnVBTUBzr/H8r03acs1?=
 =?us-ascii?Q?Q1Y7DEaD3C8KlFCqUxiDGe4bF+3aanM/2E2A7fvfoCnPXVXjylBvAU7uyO1g?=
 =?us-ascii?Q?bpOWI5d0k48WFrEM4nNncZ7G1smUL9TbiTsuVKr8uC/xV9ZVeSjWwrNg3W3F?=
 =?us-ascii?Q?/g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CYYPR11MB8429.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 078b721b-b3ab-416b-12a1-08dc847c7659
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2024 09:55:27.5675
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hIV6TAXxFWRIU2FQqeMUsBpalErTBtKDrXYVBEmbHcnohtGdaVBTsF5PtzVLYxOYqfnbztOzb62A1HnBGGLGnsIBunX5TVYsAetIJGXoAjZ83UIboRrTL+rPQg4WMUGn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6813
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of R=
icky Wu
> Sent: Thursday, May 30, 2024 7:52 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>
> Cc: pmenzel@molgen.mpg.de; michal.swiatkowski@linux.intel.com; Drewek, Wo=
jciech <wojciech.drewek@intel.com>; intel-wired-lan@lists.osuosl.org; ricky=
wu0421@gmail.com; linux-kernel@vger.kernel.org; en-wei.wu@canonical.com; ed=
umazet@google.com; Lien, Cyrus > <cyrus.lien@canonical.com>; Nguyen, Anthon=
y L <anthony.l.nguyen@intel.com>; netdev@vger.kernel.org; kuba@kernel.org; =
pabeni@redhat.com; davem@davemloft.net
> Subject: [Intel-wired-lan] [PATCH net, v2] ice: avoid IRQ collision to fi=
x init failure on ACPI S3 resume
>
> A bug in https://bugzilla.kernel.org/show_bug.cgi?id=3D218906 describes t=
hat irdma would break and report hardware initialization failed after suspe=
nd/resume with Intel E810 NIC (tested on 6.9.0-rc5).
>
> The problem is caused due to the collision between the irq numbers reques=
ted in irdma and the irq numbers requested in other drivers after suspend/r=
esume.
>
> The irq numbers used by irdma are derived from ice's ice_pf->msix_entries=
 which stores mappings between MSI-X index and Linux interrupt number.
> It's supposed to be cleaned up when suspend and rebuilt in resume but it'=
s not, causing irdma using the old irq numbers stored in the old ice_pf->ms=
ix_entries to request_irq() when resume. And eventually collide with other =
drivers.
>
> This patch fixes this problem. On suspend, we call ice_deinit_rdma() to c=
lean up the ice_pf->msix_entries (and free the MSI-X vectors used by irdma =
if we've dynamically allocated them). On resume, we call
> ice_init_rdma() to rebuild the ice_pf->msix_entries (and allocate the MSI=
-X vectors if we would like to dynamically allocate them).
>
> Fixes: f9f5301e7e2d ("ice: Register auxiliary device to provide RDMA")
> Tested-by: Cyrus Lien <cyrus.lien@canonical.com>
> Signed-off-by: Ricky Wu <en-wei.wu@canonical.com>
> ---
> Changes in v2:
> - Change title
> - Add Fixes and Tested-by tags
> - Fix typo
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)