Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754198AbYBEDx7 (ORCPT ); Mon, 4 Feb 2008 22:53:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752059AbYBEDxu (ORCPT ); Mon, 4 Feb 2008 22:53:50 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:58933 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbYBEDxt (ORCPT ); Mon, 4 Feb 2008 22:53:49 -0500 Date: Mon, 4 Feb 2008 19:53:18 -0800 From: Andrew Morton To: Rusty Russell Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Whine about suspicious return values from module's ->init() hook Message-Id: <20080204195318.bf653285.akpm@linux-foundation.org> In-Reply-To: <200802051443.31783.rusty@rustcorp.com.au> References: <20080204154215.GA26618@localhost.sw.ru> <200802051443.31783.rusty@rustcorp.com.au> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 658 Lines: 16 On Tue, 5 Feb 2008 14:43:31 +1100 Rusty Russell wrote: > On Tuesday 05 February 2008 02:42:15 Alexey Dobriyan wrote: > > One head-scratching session could be noticeably shorter with this patch... > > > > Signed-off-by: Alexey Dobriyan > > If we want to prevent > 0 returns, let's just BUG_ON(). > That risks killing previously-working setups. WARN_ON is sufficient. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/