Received-SPF: pass (google.com: domain of linux-kernel+bounces-199720-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 3 Jun 2024 23:06:27 +0200
From: Borislav Petkov <bp@alien8.de>
To: John Allen <john.allen@amd.com>
Cc: linux-edac@vger.kernel.org, tony.luck@intel.com, yazen.ghannam@amd.com,
	linux-kernel@vger.kernel.org, avadhut.naik@amd.com,
	muralidhara.mk@amd.com
Subject: Re: [PATCH v4 4/4] RAS/AMD/ATL: Implement DF 4.5 NP2 denormalization
Message-ID: <20240603210627.GMZl4wUy3RKS9a0Jzo@fat_crate.local>
References: <20240506154605.71814-1-john.allen@amd.com>
 <20240506154605.71814-5-john.allen@amd.com>
 <20240528102344.GGZlWwsJzibnQfuNYW@fat_crate.local>
 <Zl4vIkNNzP+cKSYF@AUS-L1-JOHALLEN.amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Zl4vIkNNzP+cKSYF@AUS-L1-JOHALLEN.amd.com>

On Mon, Jun 03, 2024 at 04:01:22PM -0500, John Allen wrote:
> > No lazy definitions pls:
> > 
> > drivers/ras/amd/atl/internal.h:37:#define INVALID_SPA ~0ULL
> > drivers/ras/amd/fmpm.c:119:#define INVALID_SPA  ~0ULL
> > 
> > Unify them.
> 
> Is there a particular existing header that you suggest we pull this into
> or just create a new one under drivers/ras/amd?

internal.h looks good.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette