Received-SPF: pass (google.com: domain of linux-kernel+bounces-200504-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <edb66fe8c2722e600179b1f9a0d81242d84582a0.camel@gmail.com>
Subject: Re: [PATCH 2/5] iio: adc: ad7266: use
 devm_regulator_get_enable_read_voltage
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: David Lechner <dlechner@baylibre.com>, Jonathan Cameron
 <jic23@kernel.org>
Cc: Marcelo Schmitt <marcelo.schmitt1@gmail.com>, Nuno =?ISO-8859-1?Q?S=E1?=
 <nuno.sa@analog.com>, Michael Hennerich <Michael.Hennerich@analog.com>,
 Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 linux-iio@vger.kernel.org,  linux-kernel@vger.kernel.org
Date: Tue, 04 Jun 2024 13:19:30 +0200
In-Reply-To: <20240531-iio-adc-ref-supply-refactor-v1-2-4b313c0615ad@baylibre.com>
References: 
	<20240531-iio-adc-ref-supply-refactor-v1-0-4b313c0615ad@baylibre.com>
	 <20240531-iio-adc-ref-supply-refactor-v1-2-4b313c0615ad@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.1 (3.52.1-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-05-31 at 16:19 -0500, David Lechner wrote:
> This makes use of the new devm_regulator_get_enable_read_voltage()
> function to reduce boilerplate code.
>=20
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> =C2=A0drivers/iio/adc/ad7266.c | 37 ++++++++++---------------------------
> =C2=A01 file changed, 10 insertions(+), 27 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c
> index 353a97f9c086..026db1bedc0a 100644
> --- a/drivers/iio/adc/ad7266.c
> +++ b/drivers/iio/adc/ad7266.c
> @@ -25,7 +25,6 @@
> =C2=A0
> =C2=A0struct ad7266_state {
> =C2=A0	struct spi_device	*spi;
> -	struct regulator	*reg;
> =C2=A0	unsigned long		vref_mv;
> =C2=A0
> =C2=A0	struct spi_transfer	single_xfer[3];
> @@ -377,11 +376,6 @@ static const char * const ad7266_gpio_labels[] =3D {
> =C2=A0	"ad0", "ad1", "ad2",
> =C2=A0};
> =C2=A0
> -static void ad7266_reg_disable(void *reg)
> -{
> -	regulator_disable(reg);
> -}
> -
> =C2=A0static int ad7266_probe(struct spi_device *spi)
> =C2=A0{
> =C2=A0	struct ad7266_platform_data *pdata =3D spi->dev.platform_data;
> @@ -396,28 +390,17 @@ static int ad7266_probe(struct spi_device *spi)
> =C2=A0
> =C2=A0	st =3D iio_priv(indio_dev);
> =C2=A0
> -	st->reg =3D devm_regulator_get_optional(&spi->dev, "vref");
> -	if (!IS_ERR(st->reg)) {
> -		ret =3D regulator_enable(st->reg);
> -		if (ret)
> -			return ret;
> -
> -		ret =3D devm_add_action_or_reset(&spi->dev, ad7266_reg_disable, st-
> >reg);
> -		if (ret)
> -			return ret;
> -
> -		ret =3D regulator_get_voltage(st->reg);
> -		if (ret < 0)
> -			return ret;
> -
> -		st->vref_mv =3D ret / 1000;
> -	} else {
> -		/* Any other error indicates that the regulator does exist */
> -		if (PTR_ERR(st->reg) !=3D -ENODEV)
> -			return PTR_ERR(st->reg);
> -		/* Use internal reference */
> +	/*
> +	 * Use external reference from vref if present, otherwise use 2.5V
> +	 * internal reference.
> +	 */

Not sure the comment brings any added value. The code is fairly self explan=
atory
IMO...

> +	ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "vref");
> +	if (ret =3D=3D -ENODEV)
> =C2=A0		st->vref_mv =3D 2500;
> -	}
> +	else if (ret < 0)
> +		return ret;
> +	else

I think it would be better (as that is the typical pattern) to first check =
for
errors. Also the 'return' in the middle of the else if () is a bit weird to=
 me...
Maybe something like this?

if (ret < 0 && ret !=3D -ENODEV)
	return ret;
if (ret =3D=3D -ENODEV)
	st->vref_mv =3D 2500;
else
	st->vref_mv =3D ret / 1000;

or even replacing the if() else by
st->vref_mv =3D ret =3D=3D -ENODEV ? 2500 : ret / 1000;

- Nuno S=C3=A1