Received: by 2002:a05:6500:1b41:b0:1fb:d597:ff75 with SMTP id cz1csp42425lqb; Tue, 4 Jun 2024 04:41:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV/13+Qvkxxa41sHAxDOvE+zaDPAULE+OwUnMqgjtHXYsDPFUNY7OnyRF6K2A+aTccQXBh6E9vJtRqjzIbdnZNVtDVhaGcSx/Ytei0fwg== X-Google-Smtp-Source: AGHT+IGjJ4K6x7xnG/rV4fUrVugFYHMU5U1NI12Q3mPRrmArVXR8ccfnZCQO+VTQCp+eyBIXCYoi X-Received: by 2002:ac8:7d43:0:b0:43b:1472:1685 with SMTP id d75a77b69052e-43ff52ab204mr136202351cf.51.1717501263176; Tue, 04 Jun 2024 04:41:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717501263; cv=pass; d=google.com; s=arc-20160816; b=cmfwPffIdAqTcGj1PyMrE/KJCTZzghHiOF4wybBo4lVzQk7YJbrKPks+ZfWqcoYYpo 729cT6Plbb6f0I1LKfAJdrXG0mxxss9G5hrDthAc7MaFWCLcATDd3mQh8SRDBdFU7OvX wGJ4TleE2z2uK/rLWoqwd5Qyk0algiDwE9h+eIgEFLg9MtJbQa8VUz4ufXdLmE0KepOW SA0KOvRCeXOuOziLI96Y/fYccox7rj+m70fhTH52yTzOMrcZtJl1GxV6YlOTwFNjbSZN mwirwC8aTDj98jJB6k61aKMJcMTTM91FZLV+NeZ3jixp9XfB/0vThNdav32LMhQxg5/R H10g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NlAtV130JyTJ6QOBtKIWy1nDLHZTOUAYQSl58pHkopk=; fh=osE0jxG/zlMAe+qxeQk6QBXW9kugVDwPvWmSYTJbm70=; b=bOlBVBjPI8CW4JMPydQsECSAFIw5+wvgr+n0Y0eVK3R4nklM4XPz7PHPyfl0ji0fZz XfNrgPYo49UQt7WjSh8Q/ikHDKEdImjOGehx9oppINjjKnl1FNv/PhbFvUepfr0k2y27 SWMJhsVSXhycpR/CHZD4XoLGV3RB9AiBlP8UF3qTwdNwK9gsZThcXLbWkgWh1t6iVw33 jbUpRIoWc2qN0SmFb6s/Avl+NwGQUFjYbKjpDrKY8KmLmlR5gwIWrXsIaS+Hi5U1Dbe8 KqI392aY1FG2u8cRka84zWgW78y1L1P7RMHbEWfELOVtJRNxu2oe+vfyrBgiYG/oQiQg 72Jw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LrE22qBx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-200525-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200525-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-4401e12d84bsi15011591cf.735.2024.06.04.04.41.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 04:41:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-200525-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LrE22qBx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-200525-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200525-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E0BCA1C20E5C for ; Tue, 4 Jun 2024 11:41:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3E8A01459F2; Tue, 4 Jun 2024 11:40:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LrE22qBx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64DC038B; Tue, 4 Jun 2024 11:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717501255; cv=none; b=UO8rMU79JhbA7x0P69XZkRFJx0UMTsU8S+RkSrQpreFvlnrKO9QHJnyKRmLB2VZYPxdyYYWxSh+U6QWzSLkZ6s3/GT/5OeLOvSIKfPIxPcFPZRbHIz5xFUiq7KgRIt4xaUjtxWkYAFB79u/5pvsE7hVh/j93WZ8Zvmg2Co3tYRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717501255; c=relaxed/simple; bh=4feFP4oIu4D0szM5Et4kmx5W4FXmncMvQ+moy1FK/do=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gZ8CKz/MOfT46ccT2i5IIHmnQeCaszP3bTtwr7YWdPMSNftD/O0oUQNdKs/0fUFCegh61g8QTc96aWxKlM4yUhNa3o68F5YqIK3sonCKcwARMMCaZU7iRYOlDTNjT2m2nxeS5DIflBOAkZRlBKu5mlvzjXvxnFEEuIG8l92YXRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LrE22qBx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55AF2C2BBFC; Tue, 4 Jun 2024 11:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717501254; bh=4feFP4oIu4D0szM5Et4kmx5W4FXmncMvQ+moy1FK/do=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LrE22qBxO8w9YWROIuXdVpgciovQlvL13X0chPr4M1KZtES74opeqPTDv4ZDvEJLM jj6BSt96TJHhCVGvc+kyFVC+i3VaoG5TdCwijI9FGAsBUHLeFy1//97V+xKjsQbK8o BkS4Cul44PedPQi9yQRCP3s8HP04z2+NgUm4q76+Z7hL+BSDtKE1ZeT/nsjQG/v09m uKzLWuqfz4x8Z97bxUW3RCyDswJySTI7auLk/jS5HJuR+8JmjbctAWT1GA6P8JAhgZ BTj+1a+6tgdNu6avCLFxrE/1rSn+zreDq0IK5fofH+d3le0nZpwdckrG9BRZxKyNJx Ghb+HGjtS6Pfg== Date: Tue, 4 Jun 2024 14:40:50 +0300 From: Leon Romanovsky To: Tejun Heo , Lai Jiangshan Cc: Zqiang , linux-kernel@vger.kernel.org, Gal Pressman , Tariq Toukan , RDMA mailing list Subject: Re: [PATCH -rc] workqueue: Reimplement UAF fix to avoid lockdep worning Message-ID: <20240604114050.GP3884@unreal> References: <4c4f1fb769a609a61010cb6d884ab2841ef716d3.1716885172.git.leon@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c4f1fb769a609a61010cb6d884ab2841ef716d3.1716885172.git.leon@kernel.org> On Tue, May 28, 2024 at 11:39:58AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > The commit 643445531829 ("workqueue: Fix UAF report by KASAN in > pwq_release_workfn()") causes to the following lockdep warning. <...> > As a solution, let's rewrite the commit mentioned in Fixes line to > properly unwind error without need to flash anything. Tejun, If you decide to take this patch, can you please fix typo in the commit message? "flash" -> "flush" Thanks