Received-SPF: pass (google.com: domain of linux-kernel+bounces-200567-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240530153727.843378-1-laura.nao@collabora.com>
 <20240531113534.577055-1-laura.nao@collabora.com> <CAJZ5v0i2g70Bpu5iyUpsspNrHZ67eR82y8iqq+EjWSkpBhmkUg@mail.gmail.com>
In-Reply-To: <CAJZ5v0i2g70Bpu5iyUpsspNrHZ67eR82y8iqq+EjWSkpBhmkUg@mail.gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 4 Jun 2024 14:07:22 +0200
Message-ID: <CAJZ5v0jP4TKojEMcMutptYFC=o0zJLyHfCBVOdcwp4tzSNK_4A@mail.gmail.com>
Subject: Re: [REGRESSION] probe with driver acpi-fan failed with error -22
To: Laura Nao <laura.nao@collabora.com>
Cc: kernel@collabora.com, lenb@kernel.org, linux-acpi@vger.kernel.org, 
	linux-kernel@vger.kernel.org, rafael@kernel.org, regressions@lists.linux.dev
Content-Type: multipart/mixed; boundary="00000000000092f01b061a0f4bed"

--00000000000092f01b061a0f4bed
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 3, 2024 at 8:20=E2=80=AFPM Rafael J. Wysocki <rafael@kernel.org=
> wrote:
>
> Hi,
>
> On Fri, May 31, 2024 at 1:35=E2=80=AFPM Laura Nao <laura.nao@collabora.co=
m> wrote:
> >
> > Hello,
> >
> > On 5/30/24 17:37, Laura Nao wrote:
> > > Hello,
> > >
> > > We have identified a regression in the acpi-fan driver probe between
> > > v6.9-rc7 and v6.10-rc1 on some Intel Chromebooks in the Collabora LAV=
A
> > > lab.
> > >
> > > For the Acer Chromebook Spin 514 (CP514-2H), the following error is
> > > reported in the logs:
> > >
> > > [    0.651202] acpi-fan INTC1044:00: probe with driver acpi-fan faile=
d with error -22
> > >
> > > Similar errors are reported on other devices with fans compatible wit=
h
> > > the same driver.
> > >
> > > On Acer Chromebox CXI4, ASUS Chromebook Flip C436FA and
> > > HP Chromebook x360 14 G1:
> > >
> > > [    0.488001] acpi-fan INT3404:00: probe with driver acpi-fan failed=
 with error -22
> > >
> > > On ASUS Chromebook Vero 514 CBV514-1H:
> > >
> > > [    1.168905] acpi-fan INTC1048:00: probe with driver acpi-fan faile=
d with error -22
> > >
> > > The issue is still present on next-20240529.
> > >
> > > I'm sending this report to track the regression while a fix is
> > > identified. I'll investigate the issue/run a bisection and report bac=
k
> > > with the results.
> > >
> > > This regression was discovered during some preliminary tests with the
> > > ACPI probe kselftest [1] in KernelCI. The config used was the upstrea=
m
> > > x86_64 defconfig with a fragment applied on top [2].
> > >
> > > Best,
> > >
> > > Laura
> > >
> > > [1] https://lore.kernel.org/all/20240308144933.337107-1-laura.nao@col=
labora.com/
> > > [2] https://pastebin.com/raw/0tFM0Zyg
> > >
> > > #regzbot introduced: v6.9-rc7..v6.10-rc1
> >
> > The issue started happening after:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm=
it/drivers/thermal/thermal_core.c?h=3Dv6.10-rc1&id=3D31a0fa0019b022024cc082=
ae292951a596b06f8c
> >
> > Before this commit, get_cur_state() was not called by
> > __thermal_cooling_device_register, so the error was not triggered.
> >
> > After enabling debugging for the acpi-fan driver, I noticed these error=
s
> > in the logs:
> >
> > [    0.682224] acpi INTC1044:00: Invalid control value returned
> > [    0.682635] acpi INTC1044:00: Invalid control value returned
> >
> > The value stored in fst.control is 255, which is indeed not a valid
> > value.
> >
> > I suspect this might be a firmware issue that is now manifesting due to
> > the addition of the extra get_cur_state() call.
> >
> > I'll dig a bit more and report back.
>
> It looks like _FST returns all ones if it is evaluated before _FSL on
> the affected platforms.
>
> It shouldn't do that, but then it is not particularly useful to fail
> cdev registration for this reason.
>
> The attached patch should work around this issue, please try it and repor=
t back.

A !ret check is missing in that patch, so please try the attached new
version of it instead.

Thanks!

--00000000000092f01b061a0f4bed
Content-Type: application/x-patch; name="thermal-cdev-init-2.patch"
Content-Disposition: attachment; filename="thermal-cdev-init-2.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lx0csvlc0>
X-Attachment-Id: f_lx0csvlc0

LS0tCiBkcml2ZXJzL3RoZXJtYWwvdGhlcm1hbF9jb3JlLmMgICAgfCAgIDExICsrKysrKystLS0t
CiBkcml2ZXJzL3RoZXJtYWwvdGhlcm1hbF9kZWJ1Z2ZzLmMgfCAgICA3ICsrKysrKy0KIDIgZmls
ZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCkluZGV4OiBsaW51
eC1wbS9kcml2ZXJzL3RoZXJtYWwvdGhlcm1hbF9jb3JlLmMKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGludXgt
cG0ub3JpZy9kcml2ZXJzL3RoZXJtYWwvdGhlcm1hbF9jb3JlLmMKKysrIGxpbnV4LXBtL2RyaXZl
cnMvdGhlcm1hbC90aGVybWFsX2NvcmUuYwpAQCAtOTY0LDcgKzk2NCw4IEBAIF9fdGhlcm1hbF9j
b29saW5nX2RldmljZV9yZWdpc3RlcihzdHJ1Y3QKIHsKIAlzdHJ1Y3QgdGhlcm1hbF9jb29saW5n
X2RldmljZSAqY2RldjsKIAlzdHJ1Y3QgdGhlcm1hbF96b25lX2RldmljZSAqcG9zID0gTlVMTDsK
LQl1bnNpZ25lZCBsb25nIGN1cnJlbnRfc3RhdGU7CisJdW5zaWduZWQgbG9uZyB2YWw7CisJaW50
IGN1cnJlbnRfc3RhdGU7CiAJaW50IGlkLCByZXQ7CiAKIAlpZiAoIW9wcyB8fCAhb3BzLT5nZXRf
bWF4X3N0YXRlIHx8ICFvcHMtPmdldF9jdXJfc3RhdGUgfHwKQEAgLTEwMDIsOSArMTAwMywxMSBA
QCBfX3RoZXJtYWxfY29vbGluZ19kZXZpY2VfcmVnaXN0ZXIoc3RydWN0CiAJaWYgKHJldCkKIAkJ
Z290byBvdXRfY2Rldl90eXBlOwogCi0JcmV0ID0gY2Rldi0+b3BzLT5nZXRfY3VyX3N0YXRlKGNk
ZXYsICZjdXJyZW50X3N0YXRlKTsKLQlpZiAocmV0KQotCQlnb3RvIG91dF9jZGV2X3R5cGU7CisJ
cmV0ID0gY2Rldi0+b3BzLT5nZXRfY3VyX3N0YXRlKGNkZXYsICZ2YWwpOworCWlmICghcmV0ICYm
IHZhbCA+PSAwICYmIHZhbCA8PSBJTlRfTUFYKQorCQljdXJyZW50X3N0YXRlID0gdmFsOworCWVs
c2UKKwkJY3VycmVudF9zdGF0ZSA9IC0xOwogCiAJdGhlcm1hbF9jb29saW5nX2RldmljZV9zZXR1
cF9zeXNmcyhjZGV2KTsKIApJbmRleDogbGludXgtcG0vZHJpdmVycy90aGVybWFsL3RoZXJtYWxf
ZGVidWdmcy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIGxpbnV4LXBtLm9yaWcvZHJpdmVycy90aGVybWFsL3Ro
ZXJtYWxfZGVidWdmcy5jCisrKyBsaW51eC1wbS9kcml2ZXJzL3RoZXJtYWwvdGhlcm1hbF9kZWJ1
Z2ZzLmMKQEAgLTQyMSw2ICs0MjEsOCBAQCB2b2lkIHRoZXJtYWxfZGVidWdfY2Rldl9zdGF0ZV91
cGRhdGUoY29uCiAJY2Rldl9kYmcgPSAmdGhlcm1hbF9kYmctPmNkZXZfZGJnOwogCiAJb2xkX3N0
YXRlID0gY2Rldl9kYmctPmN1cnJlbnRfc3RhdGU7CisJaWYgKG9sZF9zdGF0ZSA8IDApCisJCWdv
dG8gdW5sb2NrOwogCiAJLyoKIAkgKiBHZXQgdGhlIG9sZCBzdGF0ZSBpbmZvcm1hdGlvbiBpbiB0
aGUgZHVyYXRpb25zIGxpc3QuIElmCkBAIC00NjMsNiArNDY1LDcgQEAgdm9pZCB0aGVybWFsX2Rl
YnVnX2NkZXZfc3RhdGVfdXBkYXRlKGNvbgogCiAJY2Rldl9kYmctPnRvdGFsKys7CiAKK3VubG9j
azoKIAltdXRleF91bmxvY2soJnRoZXJtYWxfZGJnLT5sb2NrKTsKIH0KIApAQCAtNDk5LDcgKzUw
Miw5IEBAIHZvaWQgdGhlcm1hbF9kZWJ1Z19jZGV2X2FkZChzdHJ1Y3QgdGhlcm0KIAkgKiBkdXJh
dGlvbiB3aWxsIGJlIHByaW50ZWQgYnkgY2Rldl9kdF9zZXFfc2hvdygpIGFzIGV4cGVjdGVkIGlm
IGl0CiAJICogcnVucyBiZWZvcmUgdGhlIGZpcnN0IHN0YXRlIHRyYW5zaXRpb24uCiAJICovCi0J
dGhlcm1hbF9kZWJ1Z2ZzX2NkZXZfcmVjb3JkX2dldCh0aGVybWFsX2RiZywgY2Rldl9kYmctPmR1
cmF0aW9ucywgc3RhdGUpOworCWlmIChzdGF0ZSA+PSAwKQorCQl0aGVybWFsX2RlYnVnZnNfY2Rl
dl9yZWNvcmRfZ2V0KHRoZXJtYWxfZGJnLCBjZGV2X2RiZy0+ZHVyYXRpb25zLAorCQkJCQkJc3Rh
dGUpOwogCiAJZGVidWdmc19jcmVhdGVfZmlsZSgidHJhbnNfdGFibGUiLCAwNDAwLCB0aGVybWFs
X2RiZy0+ZF90b3AsCiAJCQkgICAgdGhlcm1hbF9kYmcsICZ0dF9mb3BzKTsK
--00000000000092f01b061a0f4bed--