Received: by 2002:a05:6500:1b41:b0:1fb:d597:ff75 with SMTP id cz1csp58285lqb; Tue, 4 Jun 2024 05:11:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV/8+kj5PZR2UHU4BCLf3apSiCJqY/cGvMEie3+EmDsQtS8yKm/aY24YztV1gYPin6YFU91vdlgf4RERBR4kbbOf/imZ+e7lydSzVGoBw== X-Google-Smtp-Source: AGHT+IEs8LJmemqOt3xG1GQ1j+aZpAgBd330MGcosCvto7/U0hAsMHGHSvl0PC5RMbs9KKcDyxtz X-Received: by 2002:a67:f308:0:b0:47e:f54c:4ba6 with SMTP id ada2fe7eead31-48bc22e3edemr12228590137.27.1717503074864; Tue, 04 Jun 2024 05:11:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717503074; cv=pass; d=google.com; s=arc-20160816; b=otY8stVb54HRCEJOXme6Nhfb6lOMGIWcaVmFp5gVu6yabrWvfaglVxEGrF52f/dWUW L6boorYe7kuBpP26YKn4mBSVGbFFAVW1lsrsCtv8LQW0oumxYRAbimLswVkR4q1fszD4 Rl+pC55pXOsV57veXXwmbdqqtpmlwQ/wiaaF+tM3y+cS4NqEkCoIoaUjCArSKkK30Mup rVhqQWqwNfwVVoJ/3YTLrcPgA4Z7ETU7UP1ndOjSpFu/NZQCbQtdVqrLRTsG1PelbPS9 VzKAhQC9skVudSCq+OVVUPUcYrbJXn+2u5l3fHJfsLUFG79NAaF1K/hjwbJVjst4ZhCF H0kA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wd3MyBFfOQB202CPOKP7GsOQAYwHBrhhzyKsh6sdjdI=; fh=A6tF8swD8BlaDoIEE4QNQMmC0DGqtMtfPjVd4ogYGX8=; b=DgCW8VlrOyQHDKQK9IVE+kYn6cVEhvNIXfKBmNayhN9meA8lxJqIb4SXBP9WCQSA6S nPcRhF9o2YIqkRm337bG81lQ7QuaO0a/mDixaIrflLcsThLjL0NyzxS7ZkFcwOhaHomd gMb0C9jgKeNXkhEbKNwx8z8gvhk3hCEfGeEhKyILCVQ9Uuuh7hnNjAj8dVghIrn2+aW6 WD7+PseqkqX/1ZCq7kDx9R2jjKaxDyrdfgoPIi0ho0W2s41+XtdAz7jXDBeEW82tLTm/ kAorTJD+vESIL2SOyubYcfnGc+4yI5edDAeVZ9oseX+ThPkaju0MTsB0M/AH+9TmXxd5 oo7Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ZnKwfN36; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-200570-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200570-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ada2fe7eead31-48be3c33864si754476137.365.2024.06.04.05.11.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 05:11:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-200570-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ZnKwfN36; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-200570-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200570-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8C1981C222B9 for ; Tue, 4 Jun 2024 12:11:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2497B145B2D; Tue, 4 Jun 2024 12:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ZnKwfN36" Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD86FBE7F for ; Tue, 4 Jun 2024 12:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.142 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717503069; cv=none; b=ZkXdX0PFOn4TNGbc08N/irFhiOVQy27XkQpAcp9xoohO6TfKnk88rKQJUnsoVEcoC08G5AJ9/Ny5KG/AYzPduFPF83RZt1mu/rBgUE9wZLixg3R4oOKjPMcvGfCug5PQQMn4oBAiiWY30VhoV0Vj7nxMKo12bQvuDkyrUyW+ZtU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717503069; c=relaxed/simple; bh=cYoCw0cWrDBA71x9+7VlnNNbqsna+8WEUar3FnpAabo=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QzBMEQOXmPsNAfOPvGwUHmUS19e1kHLVWOIII+CPKCkXjWTQaqU5X3ZRZaYE4iIu83pzIVsla61UYbiEeGOuTej6UrZo5WkHFJY2HcgsOJ9rnW+HdZGHoMpu35F8f+jhyB0gRIOuSicUT8eqFJC+NLPxxri+cpLd9uDiWQ/qLGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ZnKwfN36; arc=none smtp.client-ip=198.47.19.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 454CAtO3104651; Tue, 4 Jun 2024 07:10:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1717503055; bh=wd3MyBFfOQB202CPOKP7GsOQAYwHBrhhzyKsh6sdjdI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=ZnKwfN36qdlzvl71Qr17+5gXO0YOQFoMIPWcE232shscCICP8qqUSdVDl0dMnQRlj ZMOTfrJC6fBlVtBwR4Bh/ZV5yfxutlMUvbCZ/bb/Zdr+VZt4/rGTMdLVz4gi0IvPCJ EVrw4WprXgC+ITzjDzByp3Kn1aFISqXfWYqDsnXQ= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 454CAtFn105087 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 4 Jun 2024 07:10:55 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 4 Jun 2024 07:10:55 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 4 Jun 2024 07:10:55 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 454CAt1L060606; Tue, 4 Jun 2024 07:10:55 -0500 Date: Tue, 4 Jun 2024 07:10:55 -0500 From: Nishanth Menon To: Thomas Richard CC: , , , , , , , , Subject: Re: [PATCH] regulator: tps6594-regulator: Fix the number of irqs for TPS65224 and TPS6594 Message-ID: <20240604121055.lztvn2wu62qqrla6@maximize> References: <20240603170100.2394402-1-thomas.richard@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240603170100.2394402-1-thomas.richard@bootlin.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 On 19:01-20240603, Thomas Richard wrote: > The number of irqs is computed to allocate the right amount of memory for > the irq data. An array of struct tps6594_regulator_irq_data is allocated > one time for all the irqs. Each irq uses one cell of the array. > > If the computed number of irqs is not correct, not allocated memory could > be used. > > Fix the values used in the calculation for TPS6594 and TPS65224. > > Fixes: 00c826525fba (regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators) > Signed-off-by: Thomas Richard > --- Thanks a ton for fixing this - this solved a bunch of random regressions we were tracking: am62axx_sk, am69_sk, j721e-idk, j721s2-evm in addition to J7200 evm as well. Tested-by: Nishanth Menon This was definitely a 6.10 regression, could we fast track it in? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D