Received-SPF: pass (google.com: domain of linux-kernel+bounces-200589-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 4 Jun 2024 14:26:42 +0200
From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Abel Vesa <abel.vesa@linaro.org>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy:
 Document the X1E80100 QMP PCIe PHY Gen4 x4
Message-ID: <Zl8IAqTehDrVUJ4k@hovoldconsulting.com>
References: <20240531-x1e80100-phy-add-gen4x4-v1-0-5c841dae7850@linaro.org>
 <20240531-x1e80100-phy-add-gen4x4-v1-1-5c841dae7850@linaro.org>
 <Zl26Y0VklPmiirem@hovoldconsulting.com>
 <8e5610de-8091-4a08-a3b8-a0eecdc89438@kernel.org>
 <Zl73xRo7JpAZ5ViO@hovoldconsulting.com>
 <2626e3b0-a407-4e05-9c86-6d7cd40b9307@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2626e3b0-a407-4e05-9c86-6d7cd40b9307@kernel.org>

On Tue, Jun 04, 2024 at 01:37:46PM +0200, Krzysztof Kozlowski wrote:
> On 04/06/2024 13:17, Johan Hovold wrote:
> > On Tue, Jun 04, 2024 at 01:00:35PM +0200, Krzysztof Kozlowski wrote:
> >> On 03/06/2024 14:43, Johan Hovold wrote:
> >>> On Fri, May 31, 2024 at 07:06:44PM +0300, Abel Vesa wrote:
> >>>> The PCIe 6th instance from X1E80100 can be used in both 4-lane mode or
> >>>
> >>> nit: s/PCIe 6th/sixth PCIe/
> >>> nit: s/from/on/
> >>> nit: s/both/either/
> >>
> >> That's really nit-picking and not helpful in getting things merged.
> > 
> > Writing proper commit messages with correct grammar is in no way to be
> > asking too much (especially from experienced kernel devs).
> 
> Well, many of us are not native English speakers, so when the commit msg
> is 100% understandable, pointing out grammar mistakes or style
> (6th->sixth) issues is nit-picking and is asking for unnecessary work.

Well I did use a "nit:" prefix for a reason. And I hope people are still
interested in improving their English even if it's not their first
language.

Johan