Received-SPF: pass (google.com: domain of linux-kernel+bounces-200660-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <95c7f055-667a-4a56-8cb8-a4a8a83b8cfe@amd.com>
Date: Tue, 4 Jun 2024 18:30:33 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] perf/x86/amd: check event before enable to avoid GPF
To: George Kennedy <george.kennedy@oracle.com>
Cc: harshit.m.mogalapalli@oracle.com, peterz@infradead.org, mingo@redhat.com,
 acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com,
 alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com,
 adrian.hunter@intel.com, kan.liang@linux.intel.com, tglx@linutronix.de,
 bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
 ravi.bangoria@amd.com
References: <1716990659-2427-1-git-send-email-george.kennedy@oracle.com>
 <75f6aba1-8ed6-4ef8-8811-de40ae40be90@amd.com>
 <1e14ca4b-6e3e-4d57-acec-bc3ee2bed6ed@oracle.com>
Content-Language: en-US
From: Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <1e14ca4b-6e3e-4d57-acec-bc3ee2bed6ed@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NXFORUVza1dMd3pSdXRaNTZKYUtiS1gybVJtZkwvdC92OUREWVUyOUppc096?=
 =?utf-8?B?dmNjK1VsQjRVSVVRRVJYWitmcWJ2VEhmd3RlRG1MTkErOTU5MjhQdkZ6KzZm?=
 =?utf-8?B?NGVtenB6QjlYYU1IUkNFQmI0SHZmUEZhOE1uSW14RGFXQ0VqeXVIemVWWnA3?=
 =?utf-8?B?akdyZWlCM2lrQk5OdHlocDRUNXVMUXJoSEIrYWw4a3QraC9DMGs2S21CSndM?=
 =?utf-8?B?eGViVWgvZTBvWlZyNTZ6cDFRRURmRnQ0UkNDRWdEdnh4aGNFSDFxdy9kMTMz?=
 =?utf-8?B?NGF1NUFUdE0zaWJWUDBCeVpnRFZJdnN2S0o3bHA2cnp2ZDA5OGRIK0JvZDZn?=
 =?utf-8?B?Q0kwQU4vZDBWR0x3ZVN2bWtUY1M3Qy9OZEFURXZucnBxbkc5VE1OZjBXWG8x?=
 =?utf-8?B?Qm9XS3hhRG43K3A0d1Z6WDJ3WGFLdjNqZm00TVc2dFZzMWRnWHMwZHJMSEpZ?=
 =?utf-8?B?RXVvYzhaYmErSlA1UGJ4bUo3TjBWcTVER0g3YjhvQVZ6MHk1WDE5SmNlSXFZ?=
 =?utf-8?B?UWpUL0J4aU80ZEttd2NXcXd4S0JNc0ZwaFY5NjR0WENNU1hpdzVFOUdvaWpP?=
 =?utf-8?B?RWlVYmpNL05rZ2I3Rk9lUVhXQzhIUmovMlZLcFY1ZVB6MjV5cjhkNllwYVZn?=
 =?utf-8?B?d09wWEFIQzZJZmVBU21ydHVRd1hFdTVCMXZlRDFBOWMreHUrTWwweFM0QTdU?=
 =?utf-8?B?RE1VNFdjOHBndmEyMVF0dHRMb2VnOFdYWW1KZXgvaHJKUTlGQmFOZ2JUNzBw?=
 =?utf-8?B?enJNMHlwZ2x0U1kvQ2QwL20zLzJPWmN2Uk9qMHcvNEh1cmVMYm50ckdNNFFj?=
 =?utf-8?B?Ry9lbjVTMFluSU9GaC9LeXExQkdwaXBuMHVzelNWR0RZU0dDM0ZHTkFiS2lE?=
 =?utf-8?B?WnJ0M21XZHlwTGp0bWY0MThoM0NyNTNUS0xUNTNENkpFZlI1MWJkbGg2YTl2?=
 =?utf-8?B?ZzBrYUU3NWZLRmdMUk43VzkzaUhmMW9GZkFVcSt5aG5qODYwM0Z4SVB1MkVt?=
 =?utf-8?B?V2ZZcXRGdHV0SDFzdTdiS1paRmlBTzF3UXZybG41Z2FjUytoejRMa01VZTlI?=
 =?utf-8?B?Ujk2cXdibWZZQnN0N3ZUSFVIaEFnR2gvTnlWTFhxZWpnQjYrcW1CSUlUUEhJ?=
 =?utf-8?B?K1YrL0xoUlFPOXd3MHR0UWpBL2ptc3V4bXRUYjErd1RvL2duOTZHK0VZb3hE?=
 =?utf-8?B?OElFVXZiODhFb3RPanoyMnV0U1lyVHJhN1JxUUI3L2ZzekhUQ3Y0VlZUSjVD?=
 =?utf-8?B?UFlaZFhBQmE5SFJ3S2sreDZxVGxFRzNjdTRHdXhJajhrdjBUNUlRTUovcnlp?=
 =?utf-8?B?bm1BamcyenZ0K2p6YU9CcVJQWW9udEd3OVowZHgzZkN0OWFLODdOa0YwZ0JE?=
 =?utf-8?B?RXg1aUJESUdxczRHS3RFNG0zT2RXcDRUQnVxMHozY1dzWkMydUdYQ3F1d1lF?=
 =?utf-8?B?NVFCQTVaZkVHdTRyV05hMjIza2tmelptTXc1d1ErSURHdE50NnlWM0l0NFdI?=
 =?utf-8?B?R3VjRVdlVTZOM2xyUjNxTC9VdmtxSktWcHlSa3UvTXFHc1hkc000VHV1UE5s?=
 =?utf-8?B?eS9JM0pvaVlmbjBPQ3ZpQktaR1J3VHFScExtTjlZWktGZUJLM3FJU3h3Kzky?=
 =?utf-8?B?U1BLQjBGaW1objQvWDM0NU9nSjhZQ1BpdjkyOTMxcjJuR1lhMmlQS2dlaG82?=
 =?utf-8?B?QWQ0VDFrOEFWdW04MVlwb3dDdDNTa1ZEem9TY2hpOGxyblhUTWFrZFhpOGhm?=
 =?utf-8?B?UnNlajRYeTFtN2pneHVoOWRWLzhERDBDR0czSFo3SUpMQ2Z4RjRZTzNIM2Yv?=
 =?utf-8?B?bmN0OGNJSE9ydzA4eXVKbXZvazIwdkZVc1VrcFpzaEhxaWlrNDlsV2hDRjEw?=
 =?utf-8?B?bGFXSlJMQjQ1T1ZPVWNUUDFOVUtFc2JjbUZVV1hDVFcwaS9tcHBDanRpS1hR?=
 =?utf-8?B?RGxhRGlGR3NuVzZtUFd3T1d2NFgvdEI1VlhBbjUxK0VidzQ5UGIzOUtJQmND?=
 =?utf-8?B?NW1uQzhFZzNxUEVyNXorS3djSlBxV3ZLaDczcTNneEtjbXJCK1FsY1Y3aHJG?=
 =?utf-8?B?Ym1KV0ZhWXNRV0JXY1IwVkFMODV5SFRBS2llTXdFaHN2d2JReGFCcy9pTU81?=
 =?utf-8?Q?Ud4w6Ya8DAjuVA6ztmODgAil3?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb43fe11-424d-4eca-6916-08dc84965a3b
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 13:00:47.7209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3tEW7ZlchKdyqEtBaTmMtICdzoKQZh3yi/25VQ6m8Fzvck4zPpkuJ8a0PZevEv7uU82L8VmOpbTRDaj34jHTHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4044

>>> Events can be deleted and the entry can be NULL.
>> Can you please also explain "how".
> It looks like x86_pmu_stop() is clearing the bit in active_mask and setting the events entry to NULL (and doing it in the correct order) for the same events index that amd_pmu_enable_all() is trying to enable.

Right, so how can it disable the exact same event which it's about to
enable?

If it's happening because of some race condition, we need to find and fix
it. For ex: https://git.kernel.org/torvalds/c/baa014b9543c8

>>> Check event for NULL in amd_pmu_enable_all() before enable to avoid a GPF.
>>> This appears to be an AMD only issue.
>>>
>>> Syzkaller reported a GPF in amd_pmu_enable_all.
>> Can you please provide a bug report link? Also, any reproducer?
> The Syzkaller reproducer can be found in this link:
> https://lore.kernel.org/netdev/CAMt6jhyec7-TSFpr3F+_ikjpu39WV3jnCBBGwpzpBrPx55w20g@mail.gmail.com/T/#u
>>
>>> @@ -760,7 +760,8 @@ static void amd_pmu_enable_all(int added)
>>>           if (!test_bit(idx, cpuc->active_mask))
>>>               continue;
>>>   -        amd_pmu_enable_event(cpuc->events[idx]);
>>> +        if (cpuc->events[idx])
>>> +            amd_pmu_enable_event(cpuc->events[idx]);
>> What if cpuc->events[idx] becomes NULL after if (cpuc->events[idx]) but
>> before amd_pmu_enable_event(cpuc->events[idx])?
> Good question, but the crash has not reproduced with the proposed fix in hours of testing. It usually reproduces within minutes without the fix.

It does not reproduce with the patch because that if() condition makes the
race window smaller?

Thanks,
Ravi