Received-SPF: pass (google.com: domain of linux-kernel+bounces-200664-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 4 Jun 2024 16:03:30 +0300
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, sharmaajay@microsoft.com, longli@microsoft.com,
	jgg@ziepe.ca, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] RDMA/mana_ib: ignore optional access flags for MRs
Message-ID: <20240604130330.GS3884@unreal>
References: <1717502162-4161-1-git-send-email-kotaranov@linux.microsoft.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1717502162-4161-1-git-send-email-kotaranov@linux.microsoft.com>

On Tue, Jun 04, 2024 at 04:56:02AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> Ignore optional ib_access_flags when an MR is created.
> 
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> ---
>  drivers/infiniband/hw/mana/mr.c | 1 +
>  1 file changed, 1 insertion(+)

Please add Fixes line.

Thanks

> 
> diff --git a/drivers/infiniband/hw/mana/mr.c b/drivers/infiniband/hw/mana/mr.c
> index 4f13423..887b09d 100644
> --- a/drivers/infiniband/hw/mana/mr.c
> +++ b/drivers/infiniband/hw/mana/mr.c
> @@ -112,6 +112,7 @@ struct ib_mr *mana_ib_reg_user_mr(struct ib_pd *ibpd, u64 start, u64 length,
>  		  "start 0x%llx, iova 0x%llx length 0x%llx access_flags 0x%x",
>  		  start, iova, length, access_flags);
>  
> +	access_flags &= ~IB_ACCESS_OPTIONAL;
>  	if (access_flags & ~VALID_MR_FLAGS)
>  		return ERR_PTR(-EINVAL);
>  
> -- 
> 2.43.0
>