Received-SPF: pass (google.com: domain of linux-kernel+bounces-200663-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fe76301e-9835-4b7a-9da4-fceb372d9cbf@amd.com>
Date: Tue, 4 Jun 2024 18:32:36 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] perf/x86/amd: check event before enable to avoid GPF
To: George Kennedy <george.kennedy@oracle.com>
Cc: harshit.m.mogalapalli@oracle.com, peterz@infradead.org, mingo@redhat.com,
 acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com,
 alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com,
 adrian.hunter@intel.com, kan.liang@linux.intel.com, tglx@linutronix.de,
 bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
 ravi.bangoria@amd.com
References: <1716990659-2427-1-git-send-email-george.kennedy@oracle.com>
 <75f6aba1-8ed6-4ef8-8811-de40ae40be90@amd.com>
 <1e14ca4b-6e3e-4d57-acec-bc3ee2bed6ed@oracle.com>
 <61e23449-d77e-4f2c-929c-1cf0f32832a8@amd.com>
 <57bcb95d-8a1c-4903-af8c-b4b08d1270c3@oracle.com>
Content-Language: en-US
From: Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <57bcb95d-8a1c-4903-af8c-b4b08d1270c3@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b2w1THkxZEd6ZlMzNW83YVMxN2JQMW1IUGxHb2xiK21xakMyM2JCd3NVbzY5?=
 =?utf-8?B?ODRsT0tPM0FRSWVsTFFONWhvTEk2SnMxRjZha2UvSWQ1SXduTURFS0hzdDFt?=
 =?utf-8?B?MmJCNDZDZ2I1bXVhQUFPQ2pZbTRZK2liNGFEd0xVd3V6QlRpL1JOWUhzOTN1?=
 =?utf-8?B?bTNjREFIald4WmhRMWhGcEI0OGVkaG5paGo1dkhWcmZpMGtEVmpaNjArZTZD?=
 =?utf-8?B?MUs4eTZKQVVCbFhvdTVJRWttRHk2bFFqVXFQa043TGZ4dDhQaDAxT1hLWDVU?=
 =?utf-8?B?MFlUcVRIbjVkOENPQi9GeUREOEJwR0d1ekttR0Q4RUZCQ1oveUovZi82SDVy?=
 =?utf-8?B?bVVKKzVTa0hEYTJFclBDcnV1ZzJFOWhFN2ZYU2hGWEVHZ2JjMnRSaEp3a0VX?=
 =?utf-8?B?R1dqUGVhdTBTY1U0d3JFV1FFV1FVL3RWM1hjcy9BVms0VmM4YVBsT0Q5T2NG?=
 =?utf-8?B?d3M4YjZMekxZeVZvVkZTWEdTU3V1MmdxRXpLelZ2ZWN6USthZng5STc0K0RS?=
 =?utf-8?B?QzVVV0NFL3JJVFJ2ZzBVRjVKMUEvVDVrZEJKUUdZSVBYQ2o0TG1ZZXZuWjdU?=
 =?utf-8?B?YzNOR292dEhIM0VVWmVXb2ZiWGtoRHZaS1B4UG1qbElneFdSMk4xVnA2RzNz?=
 =?utf-8?B?dmxZUnU3M0dnbEliT3lTNHgxSllHSlBNVVdxSG1vMmp5NW5BVHgxR1JsNlVQ?=
 =?utf-8?B?ZFc4RlJKemxyVmJla0ZuNk9keGk5cjFQR2VsM1ZQSVBqckpZd1Z1MXpjVXNj?=
 =?utf-8?B?dTBST09ENm5PaG1HSUJxT1NWWnlIVnRBcDJMR002ZWxwZ2RacjNMeTJZT3lQ?=
 =?utf-8?B?b0tkeHhKUnMwT0hqZEFyb1J5a0wvekVQNWsxQXNtbExYdnZlU2t6S2hQMERF?=
 =?utf-8?B?QWhrS1VQaUNqeFEyVnlReHZFTVdhQlk1TkZyZXpEMlp3dmszblJhK1RBNS9H?=
 =?utf-8?B?QWpUSTA5dHFjMmhjL293aDF6V3J5ZXZxaFZFUkJlL05HQzVtT2JIMzYyaWhY?=
 =?utf-8?B?MTNmQ2dxK1FnbXl1UU1pc0pBSEFwM1dEcU54aE4wcmhGOVhVSURRQkFRVnFq?=
 =?utf-8?B?MFZEbkJCRExRTEVsTjFnb01NRitPRkczODY2UElNclg0b3FFNUJLMm9zUmEv?=
 =?utf-8?B?a3ZkV1hNS3M0YkE4dkoxZlR6Q1VBUzRzNFRDWFhvK1VVbDRIN29aY293YVlX?=
 =?utf-8?B?bkpnZ1N2TWR4NWV1NFFDTUpSRE03MWg0S0FCMFZWTEhVdjd2Q1JIcWFTRWNi?=
 =?utf-8?B?clQreERFWjZUQXZubW5nWmRIUmFUaklndHBVNHlhdllhczA3MzhaRzZQMTFV?=
 =?utf-8?B?ZmFRV1FwZ0RRL0cxbW40OGlGZmNVMEtyRzFPV3BnbkNMb0pzMjhCQi84ZzFs?=
 =?utf-8?B?Ui95NStzT3NncVVKOWxoeVBNNGN3WXMvT3M5OW5KS2Rsd1FmUi9WYVEwcUpO?=
 =?utf-8?B?U29FaUtzYmF1UEUzYzMrUy9GWlV1b24yUHFUdEI2MnZ3TGJjdWxOZHpuYi9I?=
 =?utf-8?B?UU9yOWdCN0VtZlNqU0xyZjVmUWJBVmp4cEUvZXA3T1dBM2Q3MlE1RTkxY24w?=
 =?utf-8?B?RXJiMnZWVlBVL2hLQnFWY3I4L3dnblNyZlZLUzFuR0NlbkRnTE9OM2gzS0dC?=
 =?utf-8?B?d2NsT3ZKNFNnUGZmTVRsazlyUEVuVjFmNkZQamIwRWhTb2JtU1Q3UitMNTF6?=
 =?utf-8?B?ZWxSNWswSHp4ZjFEQ1l5YzFETDRaR3ZGQ3pUMXJwN0prbmZKVS9abStid3Vk?=
 =?utf-8?B?bk5rWEZRM2I0SURCRng5OUtRWUhadUs3eWJ3OFN4ZWNkVzhEeXNCZWt0aEZZ?=
 =?utf-8?B?d2tCOHc3Y0xCMDkzcmhGcDdiakVWaklQRWliZGV0N3VQL2xvWm93elVpUlJi?=
 =?utf-8?B?MmFhTHdwRlF1TUtYdmNCRjdreDBrZmtOVi9TdlFRbDlOd0dvZGxYZmhPeWZw?=
 =?utf-8?B?bjVVS3V6V0xQMkVhajEwTkhqd29wc0U2S1V2ZVRLOWd6RWxCUUlKb2cweGJY?=
 =?utf-8?B?SFVKZVJNZGpzVUovSTBkSEM0aGVXQlN5dkhvdjhkeTlRZDZEYVM2bitPV1Ra?=
 =?utf-8?B?eHBVQ2l4THp0NE5xek1SZVEvMjNrUUdyazZ3S2pqREZQbFpPRUdkSHV2elRn?=
 =?utf-8?Q?k5hADZ/FQDsrPxk3FDVk/JTNh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8deb9780-9b6b-4290-e7e3-08dc8496a20c
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 13:02:48.1502
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QOpNA9BZPc25pGsDp4ZqjgpGbUksNe50K+dsDqOajFk5jMQsGLfVxBPQn2ojCe+NSrFiGZhSIyIoDvr3+xJVsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4052

>>>>> Syzkaller reported a GPF in amd_pmu_enable_all.
>>>> Can you please provide a bug report link? Also, any reproducer?
>>> The Syzkaller reproducer can be found in this link:
>>> https://lore.kernel.org/netdev/CAMt6jhyec7-TSFpr3F+_ikjpu39WV3jnCBBGwpzpBrPx55w20g@mail.gmail.com/T/#u
>> I'm _not_ able to reproduce the issue with this syzkaller reproducer. I ran
>> it for more than 12 hours. Here is my setup.
>>
>> - EYPC Zen3 Milan _host_
>> - Fedora 40
>> - v6.9 vanilla kernel with attached config
>> - Syzkaller command running as a root
>>    # ./syz-execprog -executor=./syz-executor -threaded=1 -repeat=0 -procs=8 2-repro.prog
>> - Also tried with C program generated using:
>>    # ./syz-prog2c -procs=8 -repeat=0 -threaded=1 -tmpdir=1 -segv=true -prog=2-repro.prog > 2-repro.c
> processor    : 0
> vendor_id    : AuthenticAMD
> cpu family    : 23
> model        : 1
> model name    : AMD EPYC 7551 32-Core Processor
> stepping    : 2
> microcode    : 0x800126e
> cpu MHz        : 2000.000
> cache size    : 512 KB
> physical id    : 0
> siblings    : 64
> core id        : 0
> cpu cores    : 32
> apicid        : 0
> initial apicid    : 0
> fpu        : yes
> fpu_exception    : yes
> cpuid level    : 13
> wp        : yes
> flags        : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht sysca
> ll nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid amd_dcm aperfmperf rapl pni
>  pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_le
> gacy abm sse4a misalignsse 3dnowprefetch osvw skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb hw
> _pstate ssbd ibpb vmmcall fsgsbase bmi1 avx2 smep bmi2 rdseed adx smap clflushopt sha_ni xsaveopt xsavec xgetbv1 nt_good clz
> ero irperf xsaveerptr arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshol
> d avic v_vmsave_vmload vgif overflow_recov succor smca
> bugs        : div0 sysret_ss_attrs null_seg spectre_v1 spectre_v2 spec_store_bypass retbleed smt_rsb srso
> bogomips    : 3992.29
> TLB size    : 2560 4K pages
> clflush size    : 64
> cache_alignment    : 64
> address sizes    : 48 bits physical, 48 bits virtual
> power management: ts ttp tm hwpstate cpb eff_freq_ro [13] [14]
> 
> Try these repro steps instead:
> syz-prog2c -prog repro.prog -threaded -repeat 0 -procs 8 -slowdown 1 -sandbox none -sandbox_arg 0 -enable net_reset -enable net_dev -enable cgroups -tmpdir -enable binfmt_misc -enable close_fds -enable sysctl -segv >repro.c
> 
>>
>> Can you please provide your config and system detail in case you are able
>> to reproduce it.
> 
> See attached for repro C and config.
No luck with your reproducers as well :(. My kernel config is almost same as
yours:

$ ./scripts/diffconfig 2-config.repro .config
-CC_HAS_AUTO_VAR_INIT_PATTERN y
-CC_HAS_AUTO_VAR_INIT_ZERO y
-CC_HAS_AUTO_VAR_INIT_ZERO_BARE y
-CC_HAS_KASAN_MEMINTRINSIC_PREFIX y
-INIT_STACK_ALL_PATTERN n
-INIT_STACK_ALL_ZERO y
-TOOLS_SUPPORT_RELR y
 AS_VERSION 24000 -> 23502
 CC_VERSION_TEXT "gcc (GCC) 13.1.1 20230614 (Red Hat 13.1.1-43..0.1)" -> "gcc (GCC) 11.4.1 20231218 (Red Hat 11.4.1-3)"
 GCC_VERSION 130101 -> 110401
 INIT_STACK_NONE n -> y
 LD_VERSION 24000 -> 23502
 LOCALVERSION "" -> "-ravi"
 PAHOLE_VERSION 0 -> 125
+PAHOLE_HAS_LANG_EXCLUDE y
+PAHOLE_HAS_SPLIT_BTF y

And I'm trying on Zen1 test machine:

processor       : 0
vendor_id       : AuthenticAMD
cpu family      : 23
model           : 1
model name      : AMD EPYC 7601 32-Core Processor
stepping        : 2
microcode       : 0x800126e
cpu MHz         : 2692.575
cache size      : 512 KB
physical id     : 0
siblings        : 64
core id         : 0
cpu cores       : 32
apicid          : 0
initial apicid  : 0
fpu             : yes
fpu_exception   : yes
cpuid level     : 13
wp              : yes
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid amd_dcm aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb hw_pstate ssbd ibpb vmmcall fsgsbase bmi1 avx2 smep bmi2 rdseed adx smap clflushopt sha_ni xsaveopt xsavec xgetbv1 xsaves clzero irperf xsaveerptr arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif overflow_recov succor smca sev sev_es
bugs            : sysret_ss_attrs null_seg spectre_v1 spectre_v2 spec_store_bypass retbleed smt_rsb srso div0
bogomips        : 4391.65
TLB size        : 2560 4K pages
clflush size    : 64
cache_alignment : 64
address sizes   : 43 bits physical, 48 bits virtual
power management: ts ttp tm hwpstate cpb eff_freq_ro [13] [14]