Received-SPF: pass (google.com: domain of linux-kernel+bounces-200682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <238b128d-0577-42e4-9623-1ab500bc1362@nvidia.com>
Date: Tue, 4 Jun 2024 16:16:07 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH -rc] workqueue: Reimplement UAF fix to avoid lockdep
 worning
To: Leon Romanovsky <leon@kernel.org>, Tejun Heo <tj@kernel.org>,
 Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Zqiang <qiang.zhang1211@gmail.com>, linux-kernel@vger.kernel.org,
 Gal Pressman <gal@nvidia.com>, RDMA mailing list <linux-rdma@vger.kernel.org>
References: <4c4f1fb769a609a61010cb6d884ab2841ef716d3.1716885172.git.leon@kernel.org>
 <20240604114050.GP3884@unreal>
Content-Language: en-US
From: Tariq Toukan <tariqt@nvidia.com>
In-Reply-To: <20240604114050.GP3884@unreal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TERpYmZ2MUsvN1FxYXJaSG1sQjhxMDF6eGZZblVaMk14Q1JOSnBvb2hsWE5W?=
 =?utf-8?B?T0d0dUJ3a3F0RUpqVERzTWVNd2dPeHdmeGw5ZHRQT2VkZDd0K2wyZmQ0SkVE?=
 =?utf-8?B?MlFLZlNmZnoxY2xpbFFMeWowNkZxckZWaWtXbFZ5OFFGc2d1QVgyUWdkd21L?=
 =?utf-8?B?bkp6dzRaTkhlKzNXSU5va0EvS0FSQWJxRkZodXVQUVFWcWE0TTUzZDIzU0Zu?=
 =?utf-8?B?Wmt5UG9leGg5REE2N1kwYjRtV2U4ZVRTUE1BbUZUTFNMMlBPOVJOMVUxSDFP?=
 =?utf-8?B?cWR6TUs5TENaV3RPUXBMZjFCYXE2Q1dSbnJndmhiekxQWTVlK3l6YzlRUk9S?=
 =?utf-8?B?a2RPVTNQcmI1ZXBsOTUyajdxWElFTHdOVkUvQ1RwVnJhNk1uODVIQXZZOTlX?=
 =?utf-8?B?WjA1YVExQ3FibEV1RWdtUFM4Z2FPQko3NnhNQUVuUk9FQW1uelc1MkdNQ0J4?=
 =?utf-8?B?cEZJbFhCbHFhNERCMGlzRjAwTEtWQ1hVM1BwSGJldEJGQTBFdE1Cd1crbkdY?=
 =?utf-8?B?MHlTMGJtajNOcHdNbUJuUXNtSkZIWHAxN0U5bGVVaHdIMFBWOTNyS0xZY1E4?=
 =?utf-8?B?SnZza3ZIRmhYUHZ0cEQwaW9pV1RLelJKNkYrQUlFMEJHMWlGcklLU1kxdGhk?=
 =?utf-8?B?djM2VjJoaUVTS2VFVEpLNzRERnM5VUN5akkvRUozOHE0alpTMnhrOFIwUlZa?=
 =?utf-8?B?Y282Wm1hYnpWaktXNkJFUXZSZnVPWG5EN2t6aklQaHQvWWZ2VEMwZ0p0eVdh?=
 =?utf-8?B?VmdocmVKOG5jNkl0a1pzLzlRdFpHTS80Nk41MjFMVjlpY0VQWTg4TUhKS1RX?=
 =?utf-8?B?WUlQQnphQ3ErbWZYaE1JTzVWSi95c1hSQ0xST0pYeExESDVYV3dCbFVDSU5Y?=
 =?utf-8?B?dFp4Nzg5dWdCVkhoN0NRNW9GOWVMcmM0S0Joa1VRazBuVUc2M0FCMjNHVVRv?=
 =?utf-8?B?UkRuaU8xMXZ5REtpKzlja1hVM2JwRmtDSlozQU4yam4vNXdtYW1DTXdpSVJG?=
 =?utf-8?B?eEh4QUlIclVCaUlPTCtheFVDVmtIaFVrbUpwSzFISTc1SWdyd0ZDalhIdDBJ?=
 =?utf-8?B?azQxNkRpMXRIZy95NVZCSlZZTGpXQmlmY3VnZFhtbE9BRzZjWjhIaHJoY1Vz?=
 =?utf-8?B?MFRZUEtKMVo1aWkvQksyNnhsYjJnVXdGOXMySERhV1JOSzd6dUZFc2RLcHRV?=
 =?utf-8?B?aGZ4VzZWU20vUDd2QzVkN3grVmYwVFhSbWJDVXMwTmxpRVkrdytaUk1jaWQ3?=
 =?utf-8?B?bW1FMmpNWGhmUHdYNC9RSjdLSVIyUTBoa1M2dkx1c0ppUEpBVTN3aGpoUlU0?=
 =?utf-8?B?a0VRWU5yUHJ0SllTcDU4RDBMUGc1em9rZHNIUUZKaWg2dzBZRG50MFJudStv?=
 =?utf-8?B?ak5KSFVTNE1CcC9jY2Y4SWtYZGtEWHJLRXdWTkQ4dk5HWUp0Qy9qSXJOcUQw?=
 =?utf-8?B?YzB5ZGdwMTVXTGkrTHpzTUZzd0ZMVnFDSk51QWlCNzRjZjArMjNMZTZBanB6?=
 =?utf-8?B?aXB4ak5Vcmk2eXQ4WjNESE9EYUNreHg3aEdMSE1LTkFBNktaeTVNWnVlc2xE?=
 =?utf-8?B?VHpXT3JNdkY0Y1VjVHV5NWk4ckFUNWNLYlNoYUhwTkQrV2toZlVsS040VDhJ?=
 =?utf-8?B?bHdCNkM5dG41eHdQZ2htaW1QTXR2eURmUG1TZkVUbjRKcGo4ZUpBM1FmbXI2?=
 =?utf-8?B?b2lNYnBrSVdseFJxSmR4QWNQSWJVM0xua0Vac09zQVJ5MHRSS1lhVElTWmxU?=
 =?utf-8?B?OVBpUmFPbXQxNm1NQTNRYXRLVVB5Rk1TRmxPa2ZWS3FTSGVUbzFETjBsZmg0?=
 =?utf-8?B?a1RGYW9tY01wM0prb2ZNNkNSWUJmOEhyRW9UM1ZndXcyTHA3cCt0bmJrQkIx?=
 =?utf-8?B?NEZFQ3MvWGNObUVMWUxaYWdUQURpNWsrZXNqWDVSRkcxNUg3aDdKcmNUTkl3?=
 =?utf-8?B?WXliMUUyUTFsVmdEaFBhTGd5SDdMQS9pcFpWbFdLRmM4MEl5ajcrTXNSZys3?=
 =?utf-8?B?bGtVQXFKUUFIT1hQTWVZT3c0ZldwMmdub2FqOFRHMytWN0lJcmxiZUVSU2xO?=
 =?utf-8?B?bVJ0aXZ0VG15bWJHa3A2V01XQ3JTWkIycGtNVDVBY2wrY0FGVlFBSG5kbnNW?=
 =?utf-8?Q?Xv5h5cW9KtnIJ0WyxqujxTCsj?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e72e99b3-5f5b-4199-03b0-08dc849882bb
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6018.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 13:16:14.5006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P13NWd2SDv3rTX7zfTVq49fyd8w6ZJHO1Z1JlJakxk4UXDbkkwbIQ5bouDvFiupnSDSttxX+KT5nFppPoTwKaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4167


On 04/06/2024 14:40, Leon Romanovsky wrote:
> On Tue, May 28, 2024 at 11:39:58AM +0300, Leon Romanovsky wrote:
>> From: Leon Romanovsky <leonro@nvidia.com>
>>
>> The commit 643445531829 ("workqueue: Fix UAF report by KASAN in
>> pwq_release_workfn()") causes to the following lockdep warning.
> 
> <...>
> 
>> As a solution, let's rewrite the commit mentioned in Fixes line to
>> properly unwind error without need to flash anything.
> 
> Tejun,
> 
> If you decide to take this patch, can you please fix typo in the commit message? "flash" -> "flush"
> 
> Thanks
> 

Also "worning" -> "warning" in subject.