Received-SPF: pass (google.com: domain of linux-kernel+bounces-200708-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 4 Jun 2024 14:29:41 +0100
From: Mark Brown <broonie@kernel.org>
To: "Liao, Chang" <liaochang1@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>, catalin.marinas@arm.com,
	will@kernel.org, maz@kernel.org, oliver.upton@linux.dev,
	james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com,
	tglx@linutronix.de, ardb@kernel.org, anshuman.khandual@arm.com,
	miguel.luis@oracle.com, joey.gouly@arm.com, ryan.roberts@arm.com,
	jeremy.linton@arm.com, ericchancf@google.com,
	kristina.martsenko@arm.com, robh@kernel.org,
	scott@os.amperecomputing.com, songshuaishuai@tinylab.org,
	shijie@os.amperecomputing.com, akpm@linux-foundation.org,
	bhe@redhat.com, horms@kernel.org, mhiramat@kernel.org,
	rmk+kernel@armlinux.org.uk, shahuang@redhat.com,
	takakura@valinux.co.jp, dianders@chromium.org, swboyd@chromium.org,
	sumit.garg@linaro.org, frederic@kernel.org, reijiw@google.com,
	akihiko.odaki@daynix.com, ruanjinjie@huawei.com,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	kvmarm@lists.linux.dev
Subject: Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate
 versions of MSR ALLINT
Message-ID: <9868a5ac-ae23-4481-afe6-ba3cd8dbfa47@sirena.org.uk>
References: <20240415064758.3250209-1-liaochang1@huawei.com>
 <20240415064758.3250209-2-liaochang1@huawei.com>
 <ZjUKMWPknEhLYoK8@FVFF77S0Q05N>
 <Zjjz-tzLRC2nH51A@finisterre.sirena.org.uk>
 <cde4d448-dc9d-eaad-4a2d-a6d34bda4449@huawei.com>
 <ZjpALOdSgu-qhshR@finisterre.sirena.org.uk>
 <e632a9ed-7659-9336-6e7f-a43c4759a7a3@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kZyx21bZX9W6NfCv"
Content-Disposition: inline
In-Reply-To: <e632a9ed-7659-9336-6e7f-a43c4759a7a3@huawei.com>


--kZyx21bZX9W6NfCv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 03, 2024 at 11:26:39AM +0800, Liao, Chang wrote:

> Mark, Is your concern is that the series of pstate related macro name in
> sysregs.h are lack of self-explanatory nature, which make it diffuclt to
> understand their functionality and purpose? If so, I daft some alternative
> macro names in the code below, looking forward to your feedback, or if you
> have any proposal for making these helpers discoverable.

...

> -#define SET_PSTATE(x, r)               __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift))
> +#define MSR_PSTATE_ENCODE(x, r)                __emit_inst(0xd500401f | PSTATE_ ## r | ((!!x) << PSTATE_Imm_shift))

Possibly, yes?  TBH I was thinking of a comment but that does have "MSR"
in it so might come up in greps.  Not sure what others would prefer.

--kZyx21bZX9W6NfCv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZfFsUACgkQJNaLcl1U
h9DBTAf/QbAdz0gZPoB6cZv3uCTSDvYO1cYiTX9u5Ejd4CgUJCcfU6JhTZi9lL01
Vrn3Nd5SlPmKVrPWMb6HMbvC/GNW6Nc0gE196nDRdaMz6o29RD0B5j+BPWiQ99Ia
MEXAs+lQD/nbf9JhLqto1ANTrc0Mf8gfWmFTt/MzoKJ7Ourujm6X//Tc8VxH3sdU
nNEPqG9/rA0b+pjIrmAFmdglZyrsr6z79A7gYvBsaf525R95FiFOv8xh3uAHNpKj
37MUhZ7YmJXCe/Ljy+MEUcrO/8+uljx7PWtBuROurQLnitvVF5eTLzunON9mkhmx
IEOifj6i0UEzDv2QKT948bHcgn+kNA==
=aRgu
-----END PGP SIGNATURE-----

--kZyx21bZX9W6NfCv--