Received-SPF: pass (google.com: domain of linux-kernel+bounces-200724-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <17b23723-d0d0-4744-9828-cef316cf3fb7@gmail.com>
Date: Tue, 4 Jun 2024 16:38:28 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/3] MAINTAINERS: Add maintainer for ROHM BH1745
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
 Mudit Sharma <muditsharma.info@gmail.com>, ivan.orlov0322@gmail.com,
 jic23@kernel.org, lars@metafoo.de, krzk+dt@kernel.org, conor+dt@kernel.org,
 robh@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org
References: <20240603162122.165943-1-muditsharma.info@gmail.com>
 <20240603162122.165943-3-muditsharma.info@gmail.com>
 <a628db76-a48a-4492-a3cc-f93c0f67ad04@gmail.com>
 <961fa617-a76b-4b79-956b-795a55fec959@gmail.com>
 <f241957f-6f4b-424c-9ea2-d7eb564daa4e@gmail.com>
Content-Language: en-US, en-GB
From: Matti Vaittinen <mazziesaccount@gmail.com>
In-Reply-To: <f241957f-6f4b-424c-9ea2-d7eb564daa4e@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 6/4/24 15:53, Javier Carrasco wrote:
> On 04/06/2024 12:44, Mudit Sharma wrote:
>> On 03/06/2024 23:37, Javier Carrasco wrote:
>>> On 03/06/2024 18:21, Mudit Sharma wrote:
>>>> Add myself as maintainer for ROHM BH1745 colour sensor driver.
>>>>
>>>
>>> is there any special reason to have a separate patch for this? The
>>> addition to MAINTANERS for new drives is usually included in the patch
>>> that provides the driver itself.
>>
>> Adding this in a separate commit was just a pattern I notices with some
>> other drivers, for instance 3b4e0e9.
>>
>> If necessary and/or considered good practice, I can squash this in the
>> patch that brings in the driver.
> 
> Although there might be some cases where it was added separately, it is
> much more common that it is added to the patch that provides the driver.
> Some perfectionists even include the entry in the dt-bindings patch, and
> then add the link to the driver code in the driver patch. I believe that
> a simple squash would be ok, though.

I believe there is a notable case where having MAINTAINERS updates as a 
separate patch makes sense. When one creates drivers for a device which 
touches multiple subsystems, typically a set of MFD drivers. This is 
usually done as a set of subsystem specific patches, each adding 
subsystem specific file(s). In this case adding MAINTAINER info 
separately for each sub-driver will create unnecessary churn in the 
MAINTAINERS file - which I believe is already now a major source of 
merge conflicts. I am not sure of this is a reason to have MAINTAINERS 
updates in own patch though.

Furthermore, I've been instructed by Rob (AFAIR) to omit the dt-binding 
files from the MAINTAINERS because the maintainer information is already 
contained in the bindings itself.

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~