Received-SPF: pass (google.com: domain of linux-kernel+bounces-200725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Jens Axboe <axboe@kernel.dk>
To: asml.silence@gmail.com, nathan@kernel.org, ndesaulniers@google.com, 
 morbo@google.com, justinstitt@google.com, Su Hui <suhui@nfschina.com>
Cc: haoxu@linux.alibaba.com, io-uring@vger.kernel.org, 
 linux-kernel@vger.kernel.org, llvm@lists.linux.dev, 
 kernel-janitors@vger.kernel.org
In-Reply-To: <20240604121242.2661244-1-suhui@nfschina.com>
References: <20240604121242.2661244-1-suhui@nfschina.com>
Subject: Re: [PATCH] io_uring/io-wq: avoid garbge value of 'match' in
 io_wq_enqueue()
Message-Id: <171750832792.373240.8767021460699358833.b4-ty@kernel.dk>
Date: Tue, 04 Jun 2024 07:38:47 -0600
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


On Tue, 04 Jun 2024 20:12:43 +0800, Su Hui wrote:
> Clang static checker (scan-build) warning:
> o_uring/io-wq.c:line 1051, column 3
> The expression is an uninitialized value. The computed value will
> also be garbage.
> 
> 'match.nr_pending' is used in io_acct_cancel_pending_work(), but it is
> not initialized. Change the order of assignment for 'match' to fix
> this problem.
> 
> [...]

Applied, thanks!

[1/1] io_uring/io-wq: avoid garbge value of 'match' in io_wq_enqueue()
      commit: e87863ed45a1c36b0d8a5b70134caf8c794d8d57

Best regards,
-- 
Jens Axboe