Received-SPF: pass (google.com: domain of linux-kernel+bounces-200726-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Jens Axboe <axboe@kernel.dk>
To: Hagar Hemdan <hagarhem@amazon.com>
Cc: Maximilian Heyne <mheyne@amazon.de>, 
 Norbert Manthey <nmanthey@amazon.de>, 
 Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org, 
 linux-kernel@vger.kernel.org
In-Reply-To: <20240604130527.3597-1-hagarhem@amazon.com>
References: <20240604130527.3597-1-hagarhem@amazon.com>
Subject: Re: [PATCH] io_uring: fix possible deadlock in
 io_register_iowq_max_workers()
Message-Id: <171750832945.373240.5340875250569409350.b4-ty@kernel.dk>
Date: Tue, 04 Jun 2024 07:38:49 -0600
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


On Tue, 04 Jun 2024 13:05:27 +0000, Hagar Hemdan wrote:
> The io_register_iowq_max_workers() function calls io_put_sq_data(),
> which acquires the sqd->lock without releasing the uring_lock.
> Similar to the commit 009ad9f0c6ee ("io_uring: drop ctx->uring_lock
> before acquiring sqd->lock"), this can lead to a potential deadlock
> situation.
> 
> To resolve this issue, the uring_lock is released before calling
> io_put_sq_data(), and then it is re-acquired after the function call.
> 
> [...]

Applied, thanks!

[1/1] io_uring: fix possible deadlock in io_register_iowq_max_workers()
      commit: a59035de589f31f195ed1fff97007d332552a72b

Best regards,
-- 
Jens Axboe