Received-SPF: pass (google.com: domain of linux-kernel+bounces-200799-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <fa6c0e29-8baf-46ec-b462-0a093b6f530e@intel.com>
Date: Tue, 4 Jun 2024 16:19:31 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 1/3] net: ti: icssg-prueth: Enable PTP
 timestamping support for SR1.0 devices
To: Diogo Ivo <diogo.ivo@siemens.com>, MD Danish Anwar <danishanwar@ti.com>,
	Roger Quadros <rogerq@kernel.org>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, Richard Cochran <richardcochran@gmail.com>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, "Tero
 Kristo" <kristo@kernel.org>, Rob Herring <robh@kernel.org>, "Krzysztof
 Kozlowski" <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, "Jan
 Kiszka" <jan.kiszka@siemens.com>, Jacob Keller <jacob.e.keller@intel.com>,
	Simon Horman <horms@kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
References: <20240604-iep-v2-0-ea8e1c0a5686@siemens.com>
 <20240604-iep-v2-1-ea8e1c0a5686@siemens.com>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240604-iep-v2-1-ea8e1c0a5686@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXZ0OFNxTXhZcXpUWXFheEY4T2ZtUU44cWpDeUZZT0dERkRuK0RobVRTM04z?=
 =?utf-8?B?Y3BoVk1WcHFrVSttOWNJTVE5NHdVcHFReDFjMURZdFlkWTFYU20zYnhVM1ZT?=
 =?utf-8?B?cVZiV1E4ZkFrNThXM1l1d1N1bytVMVVMekVkcWhKRDdadUJjaDdzTzJ1OUda?=
 =?utf-8?B?bkUzL09OazZ3cXhBc3c4WWdKU0xKckd5dnNIa25peE94Q2ZzbkdwT2t5ajhz?=
 =?utf-8?B?bUtYMUVLTXdVUWtJUFNEaUdiZkFWTjZ4eFcyZlNValQ5L2tMZWRvZ3lnSVNW?=
 =?utf-8?B?STNnQTJxajh4a2MrNWZmTnZiZk9yZUFCRjM0STk4Umx1czFxd1hPWUN5dnhx?=
 =?utf-8?B?YXpkUzBUZTdyMzJlczRHTGk3Y3Frd3ZBdmp0bktMUit0RUlSS290YmN6YU1K?=
 =?utf-8?B?cWFWNDF5S0MvdWZTSlNOYjFEa0xPYkhOSjI4WEhyUEdXdE90Y2NrUkRUSExa?=
 =?utf-8?B?b0tvNUdmT2NtdEIwK3RUY3E0VGlXZU5UZmczQ25UVGlFb0dPSVJIRTJjZytV?=
 =?utf-8?B?MDkxLzJwNmF1Q2V6NGl5WWFZd1VqeU9kM3RVbEtzZTcwelIvSGRISEhCQVFu?=
 =?utf-8?B?dnpKTzNKNE5ib05ET08zcGFBK2QrcGZqUnZIRExjeHowbnJZS0NFM3VscjNm?=
 =?utf-8?B?aFJqZ2pnS00rSWF2TE15WFRvOGpHMEFhZlJJbk50UlZ1SlpqdXJSWENOencz?=
 =?utf-8?B?TXd3SVNTV0tEMlo0YmY0MHBZb2NjQ1Q2M0lVZkdOVmR3OEhzSlhXdUFYSUk3?=
 =?utf-8?B?S3VZL3VOS3RUeGVpSVUrMVpjR3VZdXJqajZhSmlmU1dFcHVFbGFoeXI4SXEy?=
 =?utf-8?B?QmpMdFFacDQwOW9HejRLeXpUaGV3cGtKbUs0bDBIU3BTY3V5RktiZVI5L2Ir?=
 =?utf-8?B?RjNKZVR2VEgxY2xnRlRST0kvWVM1VFNEM2lPUVE2K3F1dHFBNXlPT3Y0blNJ?=
 =?utf-8?B?KzdySndidE5qOXBadWtlVS9KNnBJSnFuNCsvajZTcUNIbTdSRjhUYmo4bS92?=
 =?utf-8?B?VlRtVlVpcnlGcTJhUlBQc0tVSUZTVDQ4TkhXckszaHJGMlhCTWxmbmZKbmRi?=
 =?utf-8?B?eW1GQzhRaVhhM0dNQWpyaW5jYVgxSCtXQW01T0FBaTZGdVpBcFpvWHZwT25I?=
 =?utf-8?B?Qnd3bkxsVjJJNUY1cTY2Nm51elRtK1FjOHVNR2dOL1d5bWFjTnBqK2syVzNU?=
 =?utf-8?B?cDBsZ1RVdWF3VmhKNU02Q0ZVbWRnbUJmd3o5OThoR1Bld3hNRzY2d21OMDBO?=
 =?utf-8?B?YjdYZUozeU16RGt1RTBvbmxNQUpqMmJ2UW1JcWZiMW84czVQREJtclRLbVB5?=
 =?utf-8?B?dlFGWFYxak16bzN1NDVCbTlFbXNha2Z5c2JXWk5Wb0dTd0lKQ2c4Z1VuVUNy?=
 =?utf-8?B?ZldQNmh2WitZQUdwbkcvd0c0RUJpV3J1dzFSTFF3b0s4RE44UTZjMXdaUkt3?=
 =?utf-8?B?NnJ6QXJMQ1RacDBGcVBLaFVHWVJ6aUwyandrSG4vNXdrMEFyYm9UT21LS3Va?=
 =?utf-8?B?dlFoRHQ3MG9mV1pYeGRrSzFLY25TWFpwQmVlL1R2eDBpQll4dksra1prZUgw?=
 =?utf-8?B?ancreURKUUlLSXQ3NmY3cyt2aFFUL3Q5eU05UnNPdE5TSXhRTkRpZE9STUJx?=
 =?utf-8?B?Y2doSnA2NEo1dWk3dHJsR0p4RURuTitOTWc2K0YzWFBNMmdkdlNWaVRWVzZk?=
 =?utf-8?B?M0xHRVNUK0ZYSDN0T2drVG5BRjkyeS9RU3hsdUFGVE1lc1ZCckJSVng3bjBz?=
 =?utf-8?B?TjJrcmhscDZyT21tU05WNGpnS3NWbm4ydktlaG0zLzd5RFhsWU1YUkxKQnhB?=
 =?utf-8?B?b3BCSTBzZjFadlBrUHhOcnN3NzNEeE1XSy9CdzYvN1ZMUFlJZ1ExMjk4UWxp?=
 =?utf-8?B?K0l6TWpmbFpwREJhRUJjcHVUQTIxcm5YMEhwbVBpRGZWS3dNYmhiQTlzUTlp?=
 =?utf-8?B?YlM4UTYyOFdLVVEzWW91N1hpYUljTlkwT3FwZm5TdzlTYUl2ZGUwNFZSMm1Q?=
 =?utf-8?B?SWZlNjVlWVl5R0crUUJEN1Y1U1lhMVZNMmM5dTJJS09WZWo0aDlhaXdHS2ha?=
 =?utf-8?B?ZzFTUHc3STMwTmVwc1hvWE1qMXJyTzdHWmxDS0pHQ1B3a1BNWlhjcEZYQ3o1?=
 =?utf-8?Q?B/3DSGrDzIAGpP7RYpwJgQevk?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fac1d8b-6d16-422f-d60c-08dc84a15f7c
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 14:19:40.9323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: plVKYJQr9UClfid278coaM5N64lo9LRLfIOI/lfcWYLwY0CmUuoKhRMS4ES4hg57zJ6uou/F206V8hLL2Qqqy2vhXd965CUX9tzFRVYy63o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7753
X-OriginatorOrg: intel.com


On 04.06.2024 15:15, Diogo Ivo wrote:
> Enable PTP support for AM65x SR1.0 devices by registering with the IEP
> infrastructure in order to expose a PTP clock to userspace.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c | 51 +++++++++++++++++++++++-
>  1 file changed, 50 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> index 7b3304bbd7fc..fa98bdb11ece 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
> @@ -1011,16 +1011,44 @@ static int prueth_probe(struct platform_device *pdev)
>  	dev_dbg(dev, "sram: pa %llx va %p size %zx\n", prueth->msmcram.pa,
>  		prueth->msmcram.va, prueth->msmcram.size);
>  
> +	prueth->iep0 = icss_iep_get_idx(np, 0);
> +	if (IS_ERR(prueth->iep0)) {
> +		ret = dev_err_probe(dev, PTR_ERR(prueth->iep0),
> +				    "iep0 get failed\n");
> +		goto free_pool;
> +	}
> +
> +	prueth->iep1 = icss_iep_get_idx(np, 1);
> +	if (IS_ERR(prueth->iep1)) {
> +		ret = dev_err_probe(dev, PTR_ERR(prueth->iep1),
> +				    "iep1 get failed\n");
> +		goto put_iep0;
> +	}
> +
> +	ret = icss_iep_init(prueth->iep0, NULL, NULL, 0);
> +	if (ret) {
> +		dev_err_probe(dev, ret, "failed to init iep0\n");
> +		goto put_iep;
> +	}
> +
> +	ret = icss_iep_init(prueth->iep1, NULL, NULL, 0);
> +	if (ret) {
> +		dev_err_probe(dev, ret, "failed to init iep1\n");
> +		goto exit_iep0;
> +	}
> +
>  	if (eth0_node) {
>  		ret = prueth_netdev_init(prueth, eth0_node);
>  		if (ret) {
>  			dev_err_probe(dev, ret, "netdev init %s failed\n",
>  				      eth0_node->name);
> -			goto free_pool;
> +			goto exit_iep;
>  		}
>  
>  		if (of_find_property(eth0_node, "ti,half-duplex-capable", NULL))
>  			prueth->emac[PRUETH_MAC0]->half_duplex = 1;
> +
> +		prueth->emac[PRUETH_MAC0]->iep = prueth->iep0;
>  	}
>  
>  	if (eth1_node) {
> @@ -1033,6 +1061,8 @@ static int prueth_probe(struct platform_device *pdev)
>  
>  		if (of_find_property(eth1_node, "ti,half-duplex-capable", NULL))
>  			prueth->emac[PRUETH_MAC1]->half_duplex = 1;
> +
> +		prueth->emac[PRUETH_MAC1]->iep = prueth->iep1;
>  	}
>  
>  	/* register the network devices */
> @@ -1091,6 +1121,19 @@ static int prueth_probe(struct platform_device *pdev)
>  		prueth_netdev_exit(prueth, eth_node);
>  	}
>  
> +exit_iep:
> +	icss_iep_exit(prueth->iep1);
> +exit_iep0:
> +	icss_iep_exit(prueth->iep0);
> +
> +put_iep:
> +	icss_iep_put(prueth->iep1);
> +
> +put_iep0:
> +	icss_iep_put(prueth->iep0);
> +	prueth->iep0 = NULL;
> +	prueth->iep1 = NULL;
> +
>  free_pool:
>  	gen_pool_free(prueth->sram_pool,
>  		      (unsigned long)prueth->msmcram.va, msmc_ram_size);
> @@ -1138,6 +1181,12 @@ static void prueth_remove(struct platform_device *pdev)
>  		prueth_netdev_exit(prueth, eth_node);
>  	}
>  
> +	icss_iep_exit(prueth->iep1);
> +	icss_iep_exit(prueth->iep0);
> +
> +	icss_iep_put(prueth->iep1);
> +	icss_iep_put(prueth->iep0);
> +
>  	gen_pool_free(prueth->sram_pool,
>  		      (unsigned long)prueth->msmcram.va,
>  		      MSMC_RAM_SIZE_SR1);
>