Received-SPF: pass (google.com: domain of linux-kernel+bounces-200807-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <00dab591-0521-4165-a5a5-216dc9aa8d08@intel.com>
Date: Tue, 4 Jun 2024 16:23:18 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 2/3] net: ti: icss-iep: Enable compare events
To: Diogo Ivo <diogo.ivo@siemens.com>, MD Danish Anwar <danishanwar@ti.com>,
	Roger Quadros <rogerq@kernel.org>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, Richard Cochran <richardcochran@gmail.com>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, "Tero
 Kristo" <kristo@kernel.org>, Rob Herring <robh@kernel.org>, "Krzysztof
 Kozlowski" <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, "Jan
 Kiszka" <jan.kiszka@siemens.com>, Jacob Keller <jacob.e.keller@intel.com>,
	Simon Horman <horms@kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
References: <20240604-iep-v2-0-ea8e1c0a5686@siemens.com>
 <20240604-iep-v2-2-ea8e1c0a5686@siemens.com>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240604-iep-v2-2-ea8e1c0a5686@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3ZEc1dQd0lEVjlhSjdxNXNnYjFIcTdNY3ZvOWdtV1pDYjA0MHBBTlRSTjN0?=
 =?utf-8?B?Mnd4YWNFWVowNHZOU2NFUzNiNytkVzZ0cEFXVW4wMWZjSmlkMzRQUzlVQ0hC?=
 =?utf-8?B?bTJpdEhTYUlpWWxQODNVUHg0dmR4R1doL0xubmcvTUJ3WDc2OStLUitaYXhO?=
 =?utf-8?B?ZDlFT3M2YjdTbXJvMlF5SFBJeDlOWG5BUkNybHFpS1ZhdWtBRWpyY1VDcEtv?=
 =?utf-8?B?RURPUzVhWXQyRndnS1hvZ0ZJVFVldjRHWDNxelF6ZmswN1ZKUG40V09vNUpn?=
 =?utf-8?B?WWpKNWJENEdHK2Z0OE9HOXd6SnlBUjdvTm8rU0dVZkJoT3AxRlkzQmhvd3Qy?=
 =?utf-8?B?OGlsei9jMzF1VnVhQktWZ08wRmpHSlE2YnhTRzF1S2RMQWFyOXpVSng0VG92?=
 =?utf-8?B?cWVxTUVFTENkcWRXVlZseXM0WGt1ZTVGQlM3cDJGRGZzSkNhbWNpZkZSSS8x?=
 =?utf-8?B?djFGMzhzOUEvZE1ZN3RBUytFdFZRN2Q2SGRZRVl0QkhIR0RMWktCNm9sSzVw?=
 =?utf-8?B?SFVtRWI0UVZrdlk0aDhQVWx0Y0RZZm9wMnlWNGxMZk0vd29pQW9Oa3psWG1u?=
 =?utf-8?B?WjNDdVRUZXZqUXFvejRUSXRWWFN3TnBWRzRaOEhoVHJpcGs1OTVReThoOFZh?=
 =?utf-8?B?WmpCOGdMOGNMcjkzbSttVW16OEtVbWdHTkVLZjYxVlVmT3dTWnVwcHJ3V09l?=
 =?utf-8?B?MUMxcmpYTUpkdmdJSG5CQkVVejRlZ0NMeWp3Tkp3S0w1Mk1pQXlSd0VBUFgv?=
 =?utf-8?B?dFFhM21zM2ZOdmFmUWh5cEtlbStrd2IwamREUW4rUmhQRzlORERMZGZSWHpP?=
 =?utf-8?B?RjZBL3NDRzYvMEVwTGlyclZnbjFVWjBmNWhubjh1ZXZEeEZ0K2FJWVIwaFAw?=
 =?utf-8?B?YlVjNEh0Y0RsbXBZdXhBS1BodWVmYmk5NkF6bDhJQWRRVm9oMkxRcHhJUTFW?=
 =?utf-8?B?bkhoV3BZS2tFZjVMcktrWVUwQ0dlUUJYWjArWU5ZTFNTSTF0NTJrQWlKUE5h?=
 =?utf-8?B?NlU0OENPM1ZHUHZZbXpVQlp5SVVtN29pQjc0VSt6Y0xDdjRDcVpVSzZWZUJS?=
 =?utf-8?B?OFRXNnJLeGQ2M3NSeHRNNVM4VVFJM21TSGpyOFNnc1FsUkdCVnBhNHZ1REgy?=
 =?utf-8?B?QU1IUXVDOUZHRi9PZ3MzVDRFelFIQ3lsdFA3bm1HckZyVWkvMUhpazlIcUlm?=
 =?utf-8?B?RHpUdm02RkZGR2s0bHhQT2VTVGU3ZWJQcmdEMzQvaTJOcTFTWkZFMlVvWFA1?=
 =?utf-8?B?OU5JMHd3VlFTZC9zSUx1MmYwZEhYNXlCRjRNNmJ2RkxpMEtCdUt4OGFWcGw4?=
 =?utf-8?B?WFU1anVWRWFmTURWZTlRTmEyUWtTcE4wSHBkRFRaOGlyZkFHMXh5aHZJSTZK?=
 =?utf-8?B?T3NBcGlacGNRbHB6QW5KNHBmYUhGQUxpQzlnRk0zaStoSGdHQVBuLzc0TU9y?=
 =?utf-8?B?V3Fqb05GZUp2OWxYdkRPZU95azU5YjQ1ZjlzN3dhMlg4UlMyVUU0ZzcrSms1?=
 =?utf-8?B?NmpTZGk5dFBJSnBEUHFyT05mODF0bHNLdERqY2tsSVQ4c2VhRGlJbjRicWJM?=
 =?utf-8?B?cko4dityTnc0QXBGekVIOHBaYUlVZjhWQ1BpamZXWUI0Uld0V0I3N21UQldU?=
 =?utf-8?B?cnVibXZZVFV0cGFwUHo1cXIxY21uMFptbHBBaGJOR3dOMmYzZDlLQURhMG0y?=
 =?utf-8?B?N0o3ZFV1YzBWTE9UMHgvSWM1bkl5eFZkdmRHWkM5cVp3RlRyUW9ZZVRtR3ll?=
 =?utf-8?B?dkJ6emZabXFzdlFRbUdxTGZtYjZvL0VhazQvM2FralZoYlRsb0NCU3R1QUQw?=
 =?utf-8?B?QVJyamhpU3pGNlFUd0lwTFBNZlpVTnZMaWJVcUJCQVNrL2tqQlA4U25KR0d5?=
 =?utf-8?B?RzBlb29iR2ttUFhLVzhQOUNRa3FOc3ArbFhlNGtCN2QwTUp1NEM3Zy9zYmZC?=
 =?utf-8?B?UGQ3bmJCSG5xWGE4eXBhR3o5Z09OQXpiMHpVS0VyWEV3M2VkT1NoZ0c1eEMy?=
 =?utf-8?B?UU8yQ09EbmRMa0t4V3pGa2pybFAzbVZUTUk3MXBmeXF0VWJlaEpKeHpCTjMw?=
 =?utf-8?B?bU51aGJtdWxwU2dYMnczUFh0WUJ6c09aTXN6OXVLdGtMaVY4d3EvaTNIcW9w?=
 =?utf-8?Q?rkl2PNUEwbNKNjLD+paKN+gXN?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b98ba8a4-2d8a-4951-8cb1-08dc84a1e71b
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 14:23:28.4453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C9pgeQJq3moXixZ8sB0XkiwzKKCIO9uilL9vH/7M0xLOQKeK3OlGitF2piEwmLBg364AUxB/snziJ6s4S9WevxqbTSnFdLjyto0G+Lj4wjM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7594
X-OriginatorOrg: intel.com


On 04.06.2024 15:15, Diogo Ivo wrote:
> The IEP module supports compare events, in which a value is written to a
> hardware register and when the IEP counter reaches the written value an
> interrupt is generated. Add handling for this interrupt in order to
> support PPS events.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/ethernet/ti/icssg/icss_iep.c | 74 ++++++++++++++++++++++++++++++++
>  1 file changed, 74 insertions(+)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icss_iep.c b/drivers/net/ethernet/ti/icssg/icss_iep.c
> index 3025e9c18970..b076be9c527c 100644
> --- a/drivers/net/ethernet/ti/icssg/icss_iep.c
> +++ b/drivers/net/ethernet/ti/icssg/icss_iep.c
> @@ -17,6 +17,7 @@
>  #include <linux/timekeeping.h>
>  #include <linux/interrupt.h>
>  #include <linux/of_irq.h>
> +#include <linux/workqueue.h>
>  
>  #include "icss_iep.h"
>  
> @@ -122,6 +123,7 @@ struct icss_iep {
>  	int cap_cmp_irq;
>  	u64 period;
>  	u32 latch_enable;
> +	struct work_struct work;
>  };
>  
>  /**
> @@ -571,6 +573,57 @@ static int icss_iep_perout_enable(struct icss_iep *iep,
>  	return ret;
>  }
>  
> +static void icss_iep_cap_cmp_work(struct work_struct *work)
> +{
> +	struct icss_iep *iep = container_of(work, struct icss_iep, work);
> +	const u32 *reg_offs = iep->plat_data->reg_offs;
> +	struct ptp_clock_event pevent;
> +	unsigned int val;
> +	u64 ns, ns_next;
> +
> +	spin_lock(&iep->irq_lock);
> +
> +	ns = readl(iep->base + reg_offs[ICSS_IEP_CMP1_REG0]);
> +	if (iep->plat_data->flags & ICSS_IEP_64BIT_COUNTER_SUPPORT) {
> +		val = readl(iep->base + reg_offs[ICSS_IEP_CMP1_REG1]);
> +		ns |= (u64)val << 32;
> +	}
> +	/* set next event */
> +	ns_next = ns + iep->period;
> +	writel(lower_32_bits(ns_next),
> +	       iep->base + reg_offs[ICSS_IEP_CMP1_REG0]);
> +	if (iep->plat_data->flags & ICSS_IEP_64BIT_COUNTER_SUPPORT)
> +		writel(upper_32_bits(ns_next),
> +		       iep->base + reg_offs[ICSS_IEP_CMP1_REG1]);
> +
> +	pevent.pps_times.ts_real = ns_to_timespec64(ns);
> +	pevent.type = PTP_CLOCK_PPSUSR;
> +	pevent.index = 0;
> +	ptp_clock_event(iep->ptp_clock, &pevent);
> +	dev_dbg(iep->dev, "IEP:pps ts: %llu next:%llu:\n", ns, ns_next);
> +
> +	spin_unlock(&iep->irq_lock);
> +}
> +
> +static irqreturn_t icss_iep_cap_cmp_irq(int irq, void *dev_id)
> +{
> +	struct icss_iep *iep = (struct icss_iep *)dev_id;
> +	const u32 *reg_offs = iep->plat_data->reg_offs;
> +	unsigned int val;
> +
> +	val = readl(iep->base + reg_offs[ICSS_IEP_CMP_STAT_REG]);
> +	/* The driver only enables CMP1 */
> +	if (val & BIT(1)) {
> +		/* Clear the event */
> +		writel(BIT(1), iep->base + reg_offs[ICSS_IEP_CMP_STAT_REG]);
> +		if (iep->pps_enabled || iep->perout_enabled)
> +			schedule_work(&iep->work);
> +		return IRQ_HANDLED;
> +	}
> +
> +	return IRQ_NONE;
> +}
> +
>  static int icss_iep_pps_enable(struct icss_iep *iep, int on)
>  {
>  	struct ptp_clock_request rq;
> @@ -602,6 +655,8 @@ static int icss_iep_pps_enable(struct icss_iep *iep, int on)
>  		ret = icss_iep_perout_enable_hw(iep, &rq.perout, on);
>  	} else {
>  		ret = icss_iep_perout_enable_hw(iep, &rq.perout, on);
> +		if (iep->cap_cmp_irq)
> +			cancel_work_sync(&iep->work);
>  	}
>  
>  	if (!ret)
> @@ -777,6 +832,8 @@ int icss_iep_init(struct icss_iep *iep, const struct icss_iep_clockops *clkops,
>  	if (iep->ops && iep->ops->perout_enable) {
>  		iep->ptp_info.n_per_out = 1;
>  		iep->ptp_info.pps = 1;
> +	} else if (iep->cap_cmp_irq) {
> +		iep->ptp_info.pps = 1;
>  	}
>  
>  	if (iep->ops && iep->ops->extts_enable)
> @@ -817,6 +874,7 @@ static int icss_iep_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	struct icss_iep *iep;
>  	struct clk *iep_clk;
> +	int ret, irq;
>  
>  	iep = devm_kzalloc(dev, sizeof(*iep), GFP_KERNEL);
>  	if (!iep)
> @@ -827,6 +885,22 @@ static int icss_iep_probe(struct platform_device *pdev)
>  	if (IS_ERR(iep->base))
>  		return -ENODEV;
>  
> +	irq = platform_get_irq_byname_optional(pdev, "iep_cap_cmp");
> +	if (irq == -EPROBE_DEFER)
> +		return irq;
> +
> +	if (irq > 0) {
> +		ret = devm_request_irq(dev, irq, icss_iep_cap_cmp_irq,
> +				       IRQF_TRIGGER_HIGH, "iep_cap_cmp", iep);
> +		if (ret) {
> +			dev_info(iep->dev, "cap_cmp irq request failed: %x\n",
> +				 ret);
> +		} else {
> +			iep->cap_cmp_irq = irq;
> +			INIT_WORK(&iep->work, icss_iep_cap_cmp_work);
> +		}
> +	}
> +
>  	iep_clk = devm_clk_get(dev, NULL);
>  	if (IS_ERR(iep_clk))
>  		return PTR_ERR(iep_clk);
>