Received-SPF: pass (google.com: domain of linux-kernel+bounces-200686-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 4 Jun 2024 16:17:47 +0300
From: Tony Lindgren <tony.lindgren@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	"David S . Miller" <davem@davemloft.net>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Dhruva Gole <d-gole@ti.com>,
	Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Johan Hovold <johan@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Vignesh Raghavendra <vigneshr@ti.com>, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v7 1/7] printk: Save console options for
 add_preferred_console_match()
Message-ID: <Zl8T-0zpTYy5GFau@tlindgre-MOBL1>
References: <20240327110021.59793-1-tony@atomide.com>
 <20240327110021.59793-2-tony@atomide.com>
 <ZlC6_Um4P4b-_WQE@pathway.suse.cz>
 <Zll0Mg-Ovqx0n7Zd@tlindgre-MOBL1>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zll0Mg-Ovqx0n7Zd@tlindgre-MOBL1>

On Fri, May 31, 2024 at 09:54:42AM +0300, Tony Lindgren wrote:
> On Fri, May 24, 2024 at 06:06:21PM +0200, Petr Mladek wrote:
> > A solution might be to store "devname" separately in
> > struct console_cmdline and allow empty "name". We could
> > implement then a function similar to
> > add_preferred_console_match() which would try to match
> > "devname" and set/update "name", "index" value when matched.
> 
> This sounds nice, the empty name can be used to defer consoles that
> are not known early. And on console_setup() we only set the devname
> for such cases.

Yup reserving a slot for a devname console at console_setup() time
in console_commandline[] allows keeping the consoles in the right
order again :)

> To me it seems we additionally still need to save the kernel command
> line position of the console too in struct kernel_cmdline so we can
> set the preferred_console for the deferred cases.

Then with the command line consoles in the right order, there's no need
to save the position separately.

And I think then we can also revert commit b73c9cbe4f1f ("printk: Flag
register_console() if console is set on command line"). But I need to
test the fixes some more before sending out.

Regards,

Tony