Received-SPF: pass (google.com: domain of linux-kernel+bounces-200899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b95de69c-5b49-44af-95d3-fbcc0d75d449@intel.com>
Date: Tue, 4 Jun 2024 16:49:12 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2] net: ti: icssg-prueth: Add multicast
 filtering support
To: MD Danish Anwar <danishanwar@ti.com>, Dan Carpenter
	<dan.carpenter@linaro.org>, Jan Kiszka <jan.kiszka@siemens.com>, Diogo Ivo
	<diogo.ivo@siemens.com>, Andrew Lunn <andrew@lunn.ch>, Paolo Abeni
	<pabeni@redhat.com>, Simon Horman <horms@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>, Vignesh Raghavendra
	<vigneshr@ti.com>, Roger Quadros <rogerq@kernel.org>
References: <20240604114402.1835973-1-danishanwar@ti.com>
Content-Language: en-US
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240604114402.1835973-1-danishanwar@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWZlRWdxYUdJUFNvSU1oaTJLU1NRODJUOWFkUXdNZWo0Yy9QT2ZCbGVOeG4y?=
 =?utf-8?B?ampxd1NIY3ZVTVcrdHRkd2FQTTBXV1dMeEw3Y0xnWGswcGhXQy84Z1M4aytu?=
 =?utf-8?B?eUo5c0tTSHNkSVBJejkyVDcyakVnZ0Y5L3FLVUQySFlHb2hKc095Tm5sT0Z3?=
 =?utf-8?B?TWVJUENBZEpZV2lEeEtxQnVWd2YrcDBhNlV0dVF2OXNaUEpQMDA1eWIwTFho?=
 =?utf-8?B?dzFRVTZBODNmUElHR1htYUtaNlFyZ3NHOEdaK2h1Zy9CZDVYRWNKUWVEVkNK?=
 =?utf-8?B?QjQ2LzVaY295ekNhODJFVktYbXJKb3BBTnlpSXhPTktQanduOVZKZUhjOFMy?=
 =?utf-8?B?TWx0UnlBWG1RZVV5N1RDc3FlSUE0N0REQWFTY0pYK1BrUzBvVUR1dEpSS0tT?=
 =?utf-8?B?dWFocWhXQ2F4YVVIOXJoNDhNRHU2MWZWU0VJVXQ3clFEOGZwVVQ2RXZFUUto?=
 =?utf-8?B?VUliUy9JNmRaeUhPT3g4ckk3alE1WjErUnFud2VGa3JzeEozYUZTNDE1UzRZ?=
 =?utf-8?B?TFFLWlNkVGFZVzZOMVdLZFEwdjE4T3AyRnU1Z0FCSHdQU1dQTm5naDNFNyt6?=
 =?utf-8?B?cmtCRHZRSVpISWpka1Y3dWE1MjVaSllGcGdIT0xSYS8zM1pTQXZ6ZTNtKzFT?=
 =?utf-8?B?eEptN3NaYzBXR3pGQXhnU0ZPais4MzE0cFp6U0lUU3lXbnZnOGVaK3J3T1dS?=
 =?utf-8?B?VG13Mm9wSzhIVm92RUdPcjk4Z3ZhU0lMdXpPeTBYaTdycWVNN2gzd1BhVHFi?=
 =?utf-8?B?dnk4YXlDOHZ3Ti8rL204L2kvR0RBK1BBd2dGYnZNTFM4SW9Wa1pOaDBxVTda?=
 =?utf-8?B?Tzd3VzhHbXErZ05rWDVGRTgvWDJ0bW14enNNMjI2dU5yVWNVT3ZnbDh6ZUMy?=
 =?utf-8?B?YnNwWWdGQXJiU1poUlQrSENQWlppTlVIcG8xTVc2bm5GbGpTTmxON2kzUVJZ?=
 =?utf-8?B?a0kwSUtSVTIvTklaZkxxZXphdXN2NE1lSzAyVzhCRk45V1ZBbFJNQWRic1Qr?=
 =?utf-8?B?RDBia0VDZDZZL2NEUFRvNTE4ak9BUUFodFd4c3JWb21LWGJnUExqdk5uMkxS?=
 =?utf-8?B?U1BsaWdTV0VqTUVDa2JHZ3piWXJOMGE5NW9FeFlKOTBpeDkwRWdXWEN1QlIx?=
 =?utf-8?B?MnpqQXVyQW5FTTJCODRXNENKVTZrNmt1MS8yMEIrbmtnYnNySFBvWUFIVkdH?=
 =?utf-8?B?R2hwWXJkZ3o4UE9WQ1JMWVE5ZUZzcDFMdDIyQk00QVBnSDhWVHQ4aTJsbmJL?=
 =?utf-8?B?YVQ3YVJMY2UxdDAyRzh0SlVtNUs5K284QXhnTStZOTBSbmJoanlRWmtaTm1p?=
 =?utf-8?B?MW1FZWRacUlKZlVyUFdpNFU5Y2pWSVU0WFE2L2hseG9scWNhMGhCdXk5Umdo?=
 =?utf-8?B?bkJCZFlxSjAzZDc0WW5JOC9Mb0xaSkozbitHVFhEOFdOZEFNNXIvN1RaSnBT?=
 =?utf-8?B?MGZzcUwvbU9IM0ZwUW90WHJOVnZoS2FqcTVqQnZTNWlFVEZNbWZOWlZtSU9i?=
 =?utf-8?B?R2g2MkdDb1pKT3FaN2JzVmdJVmEwV2lMWXJCY0U1SjFmVHoyeFVkUWxQVlRK?=
 =?utf-8?B?cGQrelN3bHBPUUFrZ2lHRXhqL2JteVhibFcyZVNiMTJidDhlUGdsWWw4YVNU?=
 =?utf-8?B?TlppaFRVWVJvQjd4NU40Yk9NcVFrOTFrYUFWbWpZbzZKYUQ2RjhIUThieHZG?=
 =?utf-8?B?Q2l3VG9odUx2OGQ2T3MwYVFDcUNZQ2I3U1RqbDluSm9FMjJtUlhsNG1OckFk?=
 =?utf-8?B?S1F4VzJGd2RLTytWaThQb0ptdVZGa08wWDUzZ2lHSHVVWXpaSEI1ZmQ2Rk5h?=
 =?utf-8?B?MnZmVitBV1VaYnU4QXM5c0x1djhpUEFhUGpEd1ZGcENEVlZwZ3dYQm50Vktt?=
 =?utf-8?B?RGVVQlF1WXJ4N0ZUU1JYK1FuZTVMZ3lYWWJNVkdzcEJkWis0UFJPQmxtaWs3?=
 =?utf-8?B?N2JiTGhFMExnSUpFWGVGWHhMS0lWL3VWUDBIdEhlcmtWMGIrcWhXcXRBbVN5?=
 =?utf-8?B?TlJMc084K3BTNmI0cy94NE1nQUEwdWx2YTd1dCtTZElwaWJPU3Y3cUJRcTJx?=
 =?utf-8?B?Q2xjZnNrL25vdURMWmpPWmdJcHpVV096aFo5UkVmRDZMWGphNWVMVzgzWEZp?=
 =?utf-8?Q?5qnhGQB5Isl2Zxj3MrGAy5LZc?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 721c4af0-f8af-4a19-fdd3-08dc84a583fa
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 14:49:20.0962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PFvOh6Bb/ige0HWdCvO1K5foPJkbIuFyF0MrUs0wDKOM5DDowwTJw0Dr3jj+7F0xJa33Iflfr8p5QDHBBbaM3ex0KQnI9p77ZL4KQH6TqBY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7991
X-OriginatorOrg: intel.com


On 04.06.2024 13:44, MD Danish Anwar wrote:
> Add multicast filtering support for ICSSG Driver.
> 
> The driver will keep a copy of multicast addresses in emac->mcast_list.
> This list will be kept in sync with the netdev list and to add / del
> multicast address icssg_prueth_mac_add_mcast / icssg_prueth_mac_del_mcast
> APIs will be called.
> 
> To add a mac_address for a port, driver need to call icssg_fdb_add_del()
> and pass the mac_address and BIT(port_id) to the API. The ICSSG firmware
> will then configure the rules and allow filtering.
> 
> If a mac_address is added to port0 and the same mac_address needs to be
> added for port1, driver needs to pass BIT(port0) | BIT(port1) to the
> icssg_fdb_add_del() API. If driver just pass BIT(port1) then the entry for
> port0 will be overwritten / lost. This is a design constraint on the
> firmware side.
> 
> To overcome this in the driver, to add any mac_address for let's say portX
> driver first checks if the same mac_address is already added for any other
> port. If yes driver calls icssg_fdb_add_del() with BIT(portX) |
> BIT(other_existing_port). If not, driver calls icssg_fdb_add_del() with
> BIT(portX).
> 
> The same thing is applicable for deleting mac_addresses as well. This
> logic is in icssg_prueth_mac_add_mcast / icssg_prueth_mac_del_mcast APIs.
> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> v1 -> v2:
> *) Rebased on latest net-next/main.
> 
> NOTE: This series can be applied cleanly on the tip of net-next/main. This
> series doesn't depend on any other ICSSG driver related series that is
> floating around in netdev.
> 
> v1 https://lore.kernel.org/all/20240516091752.2969092-1-danishanwar@ti.com/
> 
>  drivers/net/ethernet/ti/icssg/icssg_prueth.c | 50 ++++++++++++++++++--
>  drivers/net/ethernet/ti/icssg/icssg_prueth.h |  3 ++
>  2 files changed, 49 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> index 6e65aa0977d4..03dd49f0afb7 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
> @@ -439,6 +439,37 @@ const struct icss_iep_clockops prueth_iep_clockops = {
>  	.perout_enable = prueth_perout_enable,
>  };
>  
> +static int icssg_prueth_mac_add_mcast(struct net_device *ndev, const u8 *addr)
> +{
> +	struct prueth_emac *emac = netdev_priv(ndev);
> +	int port_mask = BIT(emac->port_id);
> +
> +	port_mask |= icssg_fdb_lookup(emac, addr, 0);
> +	icssg_fdb_add_del(emac, addr, 0, port_mask, true);
> +	icssg_vtbl_modify(emac, 0, port_mask, port_mask, true);
> +
> +	return 0;
> +}
> +
> +static int icssg_prueth_mac_del_mcast(struct net_device *ndev, const u8 *addr)
> +{
> +	struct prueth_emac *emac = netdev_priv(ndev);
> +	int port_mask = BIT(emac->port_id);
> +	int other_port_mask;
> +
> +	other_port_mask = port_mask ^ icssg_fdb_lookup(emac, addr, 0);
> +
> +	icssg_fdb_add_del(emac, addr, 0, port_mask, false);
> +	icssg_vtbl_modify(emac, 0, port_mask, port_mask, false);
> +
> +	if (other_port_mask) {
> +		icssg_fdb_add_del(emac, addr, 0, other_port_mask, true);
> +		icssg_vtbl_modify(emac, 0, other_port_mask, other_port_mask, true);
> +	}
> +
> +	return 0;
> +}
> +
>  /**
>   * emac_ndo_open - EMAC device open
>   * @ndev: network adapter device
> @@ -547,6 +578,8 @@ static int emac_ndo_open(struct net_device *ndev)
>  
>  	prueth->emacs_initialized++;
>  
> +	__hw_addr_init(&emac->mcast_list);
> +
>  	queue_work(system_long_wq, &emac->stats_work.work);
>  
>  	return 0;
> @@ -599,6 +632,9 @@ static int emac_ndo_stop(struct net_device *ndev)
>  
>  	icssg_class_disable(prueth->miig_rt, prueth_emac_slice(emac));
>  
> +	__dev_mc_unsync(ndev, icssg_prueth_mac_del_mcast);
> +	__hw_addr_init(&emac->mcast_list);
> +
>  	atomic_set(&emac->tdown_cnt, emac->tx_ch_num);
>  	/* ensure new tdown_cnt value is visible */
>  	smp_mb__after_atomic();
> @@ -675,10 +711,15 @@ static void emac_ndo_set_rx_mode_work(struct work_struct *work)
>  		return;
>  	}
>  
> -	if (!netdev_mc_empty(ndev)) {
> -		emac_set_port_state(emac, ICSSG_EMAC_PORT_MC_FLOODING_ENABLE);
> -		return;
> -	}
> +	/* make a mc list copy */
> +
> +	netif_addr_lock_bh(ndev);
> +	__hw_addr_sync(&emac->mcast_list, &ndev->mc, ndev->addr_len);
> +	netif_addr_unlock_bh(ndev);
> +
> +	__hw_addr_sync_dev(&emac->mcast_list, ndev,
> +			   icssg_prueth_mac_add_mcast,
> +			   icssg_prueth_mac_del_mcast);

Is there a reason __dev_mc_sync can't be used here?
net_device has mc list already, no need to keep your own list
in prueth_emac.

>  }
>  
>  /**
> @@ -767,6 +808,7 @@ static int prueth_netdev_init(struct prueth *prueth,
>  	SET_NETDEV_DEV(ndev, prueth->dev);
>  	spin_lock_init(&emac->lock);
>  	mutex_init(&emac->cmd_lock);
> +	__hw_addr_init(&emac->mcast_list);
>  
>  	emac->phy_node = of_parse_phandle(eth_node, "phy-handle", 0);
>  	if (!emac->phy_node && !of_phy_is_fixed_link(eth_node)) {
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> index 5eeeccb73665..2bfda26b5901 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> @@ -155,6 +155,9 @@ struct prueth_emac {
>  	unsigned int tx_ts_enabled : 1;
>  	unsigned int half_duplex : 1;
>  
> +	/* List for storing multicast addresses */
> +	struct netdev_hw_addr_list mcast_list;
> +
>  	/* DMA related */
>  	struct prueth_tx_chn tx_chns[PRUETH_MAX_TX_QUEUES];
>  	struct completion tdown_complete;
> 
> base-commit: 2589d668e1a6ebe85329f1054cdad13647deac06