Received-SPF: pass (google.com: domain of linux-kernel+bounces-200910-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 4 Jun 2024 16:00:51 +0100
From: Mark Brown <broonie@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Banajit Goswami <bgoswami@quicinc.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	kernel@quicinc.com
Subject: Re: [PATCH] ASoC: qcom: add missing MODULE_DESCRIPTION() macro
Message-ID: <9a6636af-26f4-49b3-bd4c-91f9ccc29322@sirena.org.uk>
References: <20240603-md-snd-soc-qcom-sdw-v1-1-101ea8bcdd38@quicinc.com>
 <0bd0a518-4d85-4251-9bf9-d056dc3d7b08@sirena.org.uk>
 <7a0cde5c-db6f-4de1-9dc2-aa2c21fd0210@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4FjINuUocUrb0j8X"
Content-Disposition: inline
In-Reply-To: <7a0cde5c-db6f-4de1-9dc2-aa2c21fd0210@moroto.mountain>


--4FjINuUocUrb0j8X
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 04, 2024 at 05:46:14PM +0300, Dan Carpenter wrote:
> On Tue, Jun 04, 2024 at 12:56:09PM +0100, Mark Brown wrote:

> > Is anyone getting any value from these MODULE_DESCRIPTION()s?  This all
> > just seems like a huge amount of noise and I'm having trouble thinking
> > of a use case.

> The missing MODULE_DESCRIPTION() warnings are very annoying.  We
> recently missed a link error issue because the warning was drowned out
> in MODULE_DESCRIPTION() warnings.
> https://lore.kernel.org/all/202405182038.ncf1mL7Z-lkp@intel.com/

Yeah, adding the warning seems premature without having first added the
descriptions and I'm not clear in what situation anyone would actually
care given how rare it is for someone to manually interact with module
loading.  The number of cases where anyone would not just look at the
source seems vanishingly small.

--4FjINuUocUrb0j8X
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZfLCMACgkQJNaLcl1U
h9C22QgAhndQ9RATpqJtQSgVZgFEEyID4beRXIYAjMsdhg6/YZUD9FP7c37lw64x
g6ooe2ddBuxvD0qwNV29KW/rPzAJglDv0RXd8JCbC0h753RyR3d7eGDhDYlkqAMc
hHZP0vuZT9bKnbflS7/W333OhG1H9Aj5stiNu60supirROlX4HgjjOCPCg2990Qa
yqZqCJdYywC8i1ZRBYTpAfcuIUX0jGuHas680Do9VR5BTyWyyI/LMaWS/xVJka92
1mQDlsXc6mSEgzrqOC+Zi+Is9lne1DMz5Xrud/srQweNCsoLnOwI5DOwbQ3SVUe+
YDtmyebX2W/Na9jAm7JCAlDcoEOAFg==
=E42r
-----END PGP SIGNATURE-----

--4FjINuUocUrb0j8X--