Received-SPF: pass (google.com: domain of linux-kernel+bounces-200940-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 4 Jun 2024 08:20:53 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Imre Deak <imre.deak@intel.com>, Leon Romanovsky <leon@kernel.org>
CC: Tejun Heo <tj@kernel.org>, Dan Williams <dan.j.williams@intel.com>, "Dave
 Jiang" <dave.jiang@intel.com>, Lai Jiangshan <jiangshanlai@gmail.com>, Zqiang
	<qiang.zhang1211@gmail.com>, Gal Pressman <gal@nvidia.com>, Tariq Toukan
	<tariqt@nvidia.com>, RDMA mailing list <linux-rdma@vger.kernel.org>, "Hillf
 Danton" <hdanton@sina.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -rc] workqueue: Reimplement UAF fix to avoid lockdep
 worning
Message-ID: <665f30d54276e_4a4e629427@dwillia2-xfh.jf.intel.com.notmuch>
References: <4c4f1fb769a609a61010cb6d884ab2841ef716d3.1716885172.git.leon@kernel.org>
 <Zl8k/8/yQLnZcGd3@ideak-desk.fi.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Zl8k/8/yQLnZcGd3@ideak-desk.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+iddlY/ztqR1BVGiY5909X75JwUhmn8d+e/cnMOz3QoBotIGdhhf5abPAuy+?=
 =?us-ascii?Q?/zFoa1SeQgZtwNvuEQynldlFuXvnWKLSdqj8ivUxOUvWGGpep8dtDaLw8CYZ?=
 =?us-ascii?Q?X08b9C1OwOgDKuuJbFm+28sT6Yd0NDSEEm4VOVzw0TYzW8bCxGWgxQB1hOdB?=
 =?us-ascii?Q?VrjXCPrVfpsrY0CTNeFiW6ZQWM2um2lnlwVMT1eNsHYY6iTUvTGVucr1boNj?=
 =?us-ascii?Q?HjVOQyH98DHiJxfryH9euxfLRGg4YDqHvlbf0BxDHfBIcQKaCGg/dS0msRTt?=
 =?us-ascii?Q?Nx7qA5+ge3maAfj/alHO9B9ac3NDjT0yDU0Jr220YDMVyQamCH2wMgoGNozJ?=
 =?us-ascii?Q?8hDbbeU85iEy0tWpwHWjmFSDho4YkqA0DDPugD433+yCNQD/MQ2o+LKBIQJE?=
 =?us-ascii?Q?8Yotx2oADnQFI/NfrOmPWTdcTaX+coRoDDSfKywFwsPXoNRnepAJk8o0rubS?=
 =?us-ascii?Q?8AIjGFpIszwiMVCOR5iKvv7Y4u2fChZ7TrS39J73Wt6WEdr10cZCc9Dw+RDl?=
 =?us-ascii?Q?MsgAXx2h73YF8sFzrgpB9fNcINAGQmA7uEXLZ3jG4cJmgGe+cyDaWBtcNGvb?=
 =?us-ascii?Q?ynGMpVEicyoT5nYUaT463fuLczIYt8I3G31MyKds96FhuRxh8Sn9nOt/dlSy?=
 =?us-ascii?Q?5kTeuuoNOpkbux/UA08h8iNllkmVgoU6fLf23AHASdmVJhHVqxFg8waZsJmK?=
 =?us-ascii?Q?eWaFvMgR/TRdaCa1FKqUG4Pi4dE6k6KsHqlqM1Sq8ipR8uqa31SDRfRjNyL+?=
 =?us-ascii?Q?LdLdgP9ErGuWTxTfQqolHEdexE8iiQ0ISTrOXvAl/GHKcCMjfqyBZJkWsyEu?=
 =?us-ascii?Q?CAHSA3PkJi48oiJUntDJRz9pPh7fd3GuokO0KVX27f7cpUqj5o8iHAmBjj75?=
 =?us-ascii?Q?4uKpTv7lFSUF90VzhE0zMJNbo0xFDldNSsXcEaadP3/DXezWsHk4cERXGP4k?=
 =?us-ascii?Q?lMoutGe+dhPfM8Eu60ah37XSBfiC96v5rIISUO08jlaicSLsFBeF3q5v7BoR?=
 =?us-ascii?Q?2qbBDJK66C6DRO0LvpGnPl2rA7Z2QahLsWh5YdL34/xpWa33zyGOYBhIjbQn?=
 =?us-ascii?Q?BYdr/g+omUR7Yzqwh2MmQ0F9ldTeIe0aqvNNvucuv+ExzHUsPC1+lsc2GT3m?=
 =?us-ascii?Q?n0Tq0nGcf3NtmOLkmwcuRJq+gbdloy9ewtgEga4RnuJ7jxaHL4tXlQTYyXFx?=
 =?us-ascii?Q?6p5x0a5qaqfw7QLUQS4a8LMt8+WvLwqO8CMf05aRwv14uDZ6LYuIc1j86M4W?=
 =?us-ascii?Q?8hVK+nEyd5RM0nck3n3kJ0KWhpf500wLCO1eeOnC2y9aoTekREpifeu/IT+D?=
 =?us-ascii?Q?Tovr02rWcckCw8q/zDON3eHOlWTIpWBEnLlR/xWu5y9Dl3q4ZaoAviWu8oGG?=
 =?us-ascii?Q?N6fAh3bp3uj1pj+g6mLD0w9j2g+vgDtuA8AspozMNjYb8ZrrwJ1L6YtfUfEr?=
 =?us-ascii?Q?YCuD6CO0PAYbWWNBnz0iO+82tAaSdwEdRaftzQpf09XSdL705LMzxn2WmueR?=
 =?us-ascii?Q?I0In36G/q68nTvBFKVuRvtYOAWCbKJpTThAAbfCGJCQlnwrZ64giY9JlQQ/V?=
 =?us-ascii?Q?+cIP+SCkqxYQlumBB0NP230mpPR4a3CWdGDLGDcwfPuHs+tgoVD+QaMFW2/i?=
 =?us-ascii?Q?lA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 528ae2fb-6fd1-4c16-b592-08dc84a9edf7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 15:20:55.7662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DhgUA60r1zCmT6zo7RxxWQQYG8loPgHcfevoD+M0J9HuzNXxazTY7soORpjDVc6a4wqkFG3kRGSz6cpnDU4ObcT00+4Te/488gZzVRM3KKA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4883
X-OriginatorOrg: intel.com

Imre Deak wrote:
> Hi,
> 
> [Sorry for the previous message, resending it now
>  with proper In-reply-to: header added.]
> 
> I see a similar issue, a corruption in the lock_keys_hash while
> alloc_workqueue()->lockdep_register_key() iterates it, see [1] for the
> stacktrace.
> 
> Not sure if related or even will solve [1], but [2] will revert
> 
> commit 7e89efc6e9e4 ("PCI: Lock upstream bridge for pci_reset_function()")
> 
> which does
> 
> lockdep_register_key(&dev->cfg_access_key);
> 
> in pci_device_add() and doesn't unregister the key when the pci device is
> removed (and potentially freed); so basically 7e89efc6e9e4 was missing a
> 
> lockdep_unregister_key();
> 
> in pci_destroy_dev().
> 
> Based on the above I wonder if 7e89efc6e9e4 could also lead to the
> corruption of lock_keys_hash after a pci device is removed.o

Are you running with the revert applied and still seeing issues?