Received-SPF: pass (google.com: domain of linux-kernel+bounces-200962-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ef1bb07b-0233-40c9-8c46-0db67d1c8bda@wolfvision.net>
Date: Tue, 4 Jun 2024 17:31:19 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 0/4] Input: support overlay objects on touchscreens
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Rob Herring
 <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Bastian Hecht <hechtb@gmail.com>,
 Michael Riesch <michael.riesch@wolfvision.net>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, Jeff LaBundy <jeff@labundy.com>
References: <20240422-feature-ts_virtobj_patch-v9-0-acf118d12a8a@wolfvision.net>
Content-Language: en-US, de-AT
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <20240422-feature-ts_virtobj_patch-v9-0-acf118d12a8a@wolfvision.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Zjk5SWRHQ1NDTVVib3RHVk9SUGVNOFowQW9vNXZvV2tEVVByTnliTEk3bVNp?=
 =?utf-8?B?R0dvd0pJYnZSOW02S0JnQWYvU0tpL2VYZHdPMDVtMHlBeGVoci8xbUo0TDZm?=
 =?utf-8?B?b3FFTlpSd1lnVFdmOFdCN3lVeVdQS0xlbm1tcEZFRndJVDdzK2YwSVhBc3dH?=
 =?utf-8?B?U0o2ZTMwTENWVkpFdjRnOEtVUndiUFBuMEhwRTB0SFgvNTZ4ZlhGMUhkZDdp?=
 =?utf-8?B?OFRZTFE0M0lGOHJnL3I3VFFQaCtPYXo1WTRVTWhsMTF6bkZuS2wzcy81TTJ6?=
 =?utf-8?B?UGEwYTYzb1ljRjVYUC9WVjZUWlA0d1Y0K2grZkJyNWVCZEJqdXVyRytSV2w3?=
 =?utf-8?B?c1NnbXNCWFpjWGc0QU0xL3JXY0RDZkh2c0N3dks5dzhMaWQzeGtMRi80NWI3?=
 =?utf-8?B?K0dPeUxRVThqWFV0UnNubHVvYWovZkpuL1FTZVhwcW9mVHpIdlk3U2dEbGh0?=
 =?utf-8?B?SVJDdWxJdityWUtyQ1dPUXFuWWtNbDhuOHA1NmhDdjc3T2FxNkE0eEJEYzBC?=
 =?utf-8?B?aisvYWhic2pmWWt2UHVQZ2c1MldQQ3phNkxWVjRrbHFpZXJtcEl3ZWFqcWJT?=
 =?utf-8?B?QlBzVzBwNnF0eTNKRGp6VVJZTmU4dElIaFZyZ2k2bVlqdnZTQkxjbHk0a0M3?=
 =?utf-8?B?TzlWK0dvWHdYd0xBT0x4SnQ0NWVXTzBvVnR3My9Mc21KeFJCTHM2NkI3L01U?=
 =?utf-8?B?UEZOcjhsN2lEamFJS1I3OG1mNmdzNWVsSnpnc1RiTHhKNGVpOGVNNGo3SUoy?=
 =?utf-8?B?RVhWQi9sVWVpa3FMY1c4WlZ1Y0NzN3NoUktDWG9RLzRQM05TQzg0eWYveGI1?=
 =?utf-8?B?YnRONHJRelpNeEtrWElLdm01c0YxK3djYlUzVlUvWk95RGE1a1lwUVIwQUU4?=
 =?utf-8?B?eFVPZUVKclNTdGpnd0JVaGxvajlvSzNDaVY5b0tURDNZY1dReHVvKzdrU0RM?=
 =?utf-8?B?eEs5K3Bxamg3cGRiV215RTBSdXJxY0dweWljK1ExNGRBbjlPbHQ5c0xEY20y?=
 =?utf-8?B?aUp5Y2x4aS81UDdKdkxTSHNjdlhwVnRxRDhaNTRsajFEY0hPUlc4SVhHYk41?=
 =?utf-8?B?UmRyc243SDNTUnJKRzZqdktUOXptL1dEbSsvamx3emdVUHRhRDdpYUovTEM2?=
 =?utf-8?B?Wm1CSVYwRzVCYVZhQ2xLZ0dtTG1qbWIvbkdLSzJXNDRzaWdWMGl6WHh1WENI?=
 =?utf-8?B?Unp0VDZkak9CTFJ6S2pGbTYwY3oyeHhKbzNYcTFXY1JhSWxtbnNwQnFydUVl?=
 =?utf-8?B?Qjg3THZFejI3K2t4RkVnUThyWjR4S2N1eEN2bm1MMTVsRFFCQVJvRXdwTzl1?=
 =?utf-8?B?NWVaUnpUaFAyc0pmTjhwVHdNUDhWNG5OQjk3RW12ZDloYitTWTZJNWJ0R2N2?=
 =?utf-8?B?V1FadHNYeXcvWkhwZ1NlRXRSUnZ4OThuYnpTT1RPYi9FckYxY1VKdXh4cFdZ?=
 =?utf-8?B?YmlCK3Z3RDdlYjJsK1BCcnpwZHBKbVpIVExMWWI1Q3NjQnFtRFE1bUNia2Y3?=
 =?utf-8?B?ZHR5djIzamtIdXFMaFFHdmxLQVVIRzBGbVV1SGEyNUEvWXd5Zm5LU2hkamx0?=
 =?utf-8?B?RVg2bTFSaWZxYllqWnFuUmljeXdhUG5wLzMwRW54NSt2SFgyai96RXZYQlhG?=
 =?utf-8?B?UmdVbWpiWHpmNVg3SDJnQ1dTYXI2ZXEwOGFXTFBQeXBrK0l0SHp2bzlXR2hH?=
 =?utf-8?B?NUZHY0NNaHFpeWhzczZ0eUlWSkw2cVRsUlZvL2J4cWJFQzN5bnF6b3R4MEFX?=
 =?utf-8?B?UnNKRlNmeUZkYStXVjJncjZIZndOaUN5M1NvMytpcVFtb1crTmJ1cEpSOW5X?=
 =?utf-8?B?OFNSRTdWTnlOaTkzNjVkK0RVSURpeEhzQm9YNGo3Y2ZUSndxcXYyRzhhUk9y?=
 =?utf-8?B?bndIdWp4QmYwaSswbjVSN25IVFovYnU2b0VNNUtFREZNZmhTcHByYzJuUFhP?=
 =?utf-8?B?Z2VFWnFYU21xNVFaTDFOY2VDbklPT1BScm9XT2NNdGpOT0ZtKzdHTFdISnhP?=
 =?utf-8?B?OWdHWFUrTDBFYkNYRU5rOEZPMnk5ODcxZUZQMjRjMnhIcGp2emVPQWRSbVRQ?=
 =?utf-8?B?ZHRsTy9iTHZTak5jMFc4cCtzWTdsYnd3TGo2dVVHbGZxNTY0NXRpb0JHVDBh?=
 =?utf-8?B?RVZNQWZDaGxsZFF5cWYvMVBGZ2tXZEV5dmZwM1UrNkFSQUpMV1pwSWVWM3ha?=
 =?utf-8?Q?hivvPBAABbovG3WlWFZ5yqo=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 86dabf7a-2bcc-4858-068e-08dc84ab62f6
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 15:31:21.5482
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nFeuIT7RuAQiadGJTARTB9jN4bZZMv8bxN/EmuncknEjhz3Ch3XJjWY5PcM1c8aBQXzKyRnuMCHszzJMlol9smKDePYDjn/7sCkZlKWbm8k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9911

On 22/04/2024 12:07, Javier Carrasco wrote:
> Some touchscreens are shipped with a physical layer on top of them where
> a number of buttons and a resized touchscreen surface might be available.
> 
> In order to generate proper key events by overlay buttons and adjust the
> touch events to a clipped surface, this series offers a documented,
> device-tree-based solution by means of helper functions.
> An implementation for a specific touchscreen driver is also included.
> 
> The functions in touch-overlay provide a simple workflow to acquire
> physical objects from the device tree, map them into a list and generate
> events according to the object descriptions.
> 
> This feature has been tested with a JT240MHQS-E3 display, which consists
> of an st1624 as the base touchscreen and an overlay with two buttons and
> a frame that clips its effective surface mounted on it.
> 
> To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> To: Conor Dooley <conor+dt@kernel.org>
> To: Bastian Hecht <hechtb@gmail.com>
> To: Michael Riesch <michael.riesch@wolfvision.net>
> Cc: linux-input@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
> 
> Changes in v9:
> - touch-overlay.c: trigger a button release if the finger slides out of
>   the button segment to be consistent with the button press when sliding
>   into a button segment (see touch_overlay_button_event()).
> - touch-overlay.c: (nit) remove braces in if with a single statement in
>   touch_overaly_process_event().
> - Link to v8: https://lore.kernel.org/r/20240320-feature-ts_virtobj_patch-v8-0-cab6e7dcb1f6@wolfvision.net
> 
> Changes in v8:
> - touchscreen bindings: fix description formatting.
> - Link to v7: https://lore.kernel.org/r/20240119-feature-ts_virtobj_patch-v7-0-eda70985808f@wolfvision.net
> 
> Changes in v7:
> - General: return to a single input device implementation.
> - touchscreen bindings: segment instead of button in the label
>   description.
> - touch-overlay.c: define button-specific data inside segment struct.
> - touch-overlay.c: remove fwnode_property_present() and check return
>   value of fwnode_property_read_u32() in touch_overlay_get_segment().
> - touch-overlay.c: simplify return path in touch_overlay_map().
> - Link to v6: https://lore.kernel.org/r/20230510-feature-ts_virtobj_patch-v6-0-d8a605975153@wolfvision.net
> 
> Changes in v6:
> - General: use a single list to manage a single type of object.
> - General: swap patches to have bindings preceding the code.
> - touch-overlay.c: minor code-sytle fixes.
> - Link to v5: https://lore.kernel.org/r/20230510-feature-ts_virtobj_patch-v5-0-ff6b5c4db693@wolfvision.net
> 
> Changes in v5:
> - touchscreen bindings: move overlay common properties to a $def entry (Rob Herring)
> - st1232 bindings: move overlays to the existing example instead of
>   making a new one (Rob Herring)
> - Link to v4: https://lore.kernel.org/r/20230510-feature-ts_virtobj_patch-v4-0-5c6c0fc1eed6@wolfvision.net
> 
> Changes in v4:
> - General: rename "touchscreen" to "touch" to include other consumers.
> - PATCH 1/4: move touch-overlay feature to input core.
> - PATCH 1/4, 3/4: set key caps and report key events without consumer's
>   intervention.
> - PATCH 2/4: add missing 'required' field with the required properties.
> - Link to v3: https://lore.kernel.org/r/20230510-feature-ts_virtobj_patch-v3-0-b4fb7fc4bab7@wolfvision.net
> 
> Changes in v3:
> - General: rename "virtobj" and "virtual" to "overlay"
> - PATCH 1/4: Make feature bool instead of tristate (selected by
>   supported touchscreens)
> - Link to v2: https://lore.kernel.org/r/20230510-feature-ts_virtobj_patch-v2-0-f68a6bfe7a0f@wolfvision.net
> 
> Changes in v2:
> - PATCH 1/4: remove preprocessor directives (the module is selected by
>   the drivers that support the feature). Typo in the commit message.
> - PATCH 2/4: more detailed documentation. Images and examples were added.
> - PATCH 3/4: select ts-virtobj automatically.
> - Link to v1: https://lore.kernel.org/r/20230510-feature-ts_virtobj_patch-v1-0-5ae5e81bc264@wolfvision.net
> 
> ---
> Javier Carrasco (4):
>       dt-bindings: touchscreen: add touch-overlay property
>       Input: touch-overlay - Add touchscreen overlay handling
>       dt-bindings: input: touchscreen: st1232: add touch-overlay example
>       Input: st1232 - add touch overlays handling
> 
>  .../input/touchscreen/sitronix,st1232.yaml         |  29 +++
>  .../bindings/input/touchscreen/touchscreen.yaml    | 119 ++++++++++
>  MAINTAINERS                                        |   7 +
>  drivers/input/Makefile                             |   2 +-
>  drivers/input/touch-overlay.c                      | 263 +++++++++++++++++++++
>  drivers/input/touchscreen/st1232.c                 |  48 ++--
>  include/linux/input/touch-overlay.h                |  22 ++
>  7 files changed, 475 insertions(+), 15 deletions(-)
> ---
> base-commit: 0bbac3facb5d6cc0171c45c9873a2dc96bea9680
> change-id: 20230510-feature-ts_virtobj_patch-e267540aae74
> 
> Best regards,

Little reminder: this feature was reviewed a few weeks ago, and it is
waiting to be applied or receive new feedback if required.

Thanks and best regards,
Javier Carrasco