Received: by 2002:a05:6500:1b41:b0:1fb:d597:ff75 with SMTP id cz1csp199915lqb; Tue, 4 Jun 2024 08:52:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUhkyyyRevp3F+7KEn4G1AuBELVuu7o0SIKkKscf6KkzSOngNt+PtChxzOwkdQIZ21Mmj4TSF6m55nYF0j5BI1t9D4Qk7eKUgH+yu14WQ== X-Google-Smtp-Source: AGHT+IEdfR1Il2mh9rp6vhHC5DegkZDylts/xriwwBQ08/VYlu9kpCGtuSCMi2GC2+RxXzV5GmWp X-Received: by 2002:a17:902:ea0d:b0:1f6:7fa4:e032 with SMTP id d9443c01a7336-1f67fa4e1e9mr83208975ad.63.1717516351003; Tue, 04 Jun 2024 08:52:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717516350; cv=pass; d=google.com; s=arc-20160816; b=KvjYcLSFJ+w9yfy2VCTzpBd5YMd/6VmrrkyH3hruD1IQM1KbaXiLWsGwOm2+OL0Mzz +w4SXygaH2PTI4+6NNS5bnudsJPmCTon171qd9qIczo248IGwlKbvG9dT6VllCuov4G7 acGbqqUat3A0Vs1jX/VoWRMlWV/CHZ41AMtWkb1eiXrBvgDmI5BIUhFPbFPO0UbxxXFq LFVJqc1/dr+bPc+1Nd9abEmgAfMM1T4RNxdGyHCLmZO/5RABV0o/JFtKAkH0evXMKkg/ b1oKZFK7CAZjSzr4dh8bZjcW854GyR3YNTnPpKh119C5gpqz6em1r6yw0L/u3gGAE8Wr miYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:subject:from:cc:to :content-language:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=IZM81H3ToOd0nFYz+ETE9GqM/ElioJLDbHOzj6vrDdc=; fh=2h0jfBJy2TJn99YO3Go6/F4tdg3m6qdlnZtODTCpjSc=; b=PL4FJ2aehYXt6ZGNa+7PqN1Db+pOYes9dMQXPCyfimlWvRobVyCmY3Y92F6l9kMjao J/0iuYKleuXqAXesNYhH3q14mVSgVqFiNDgpvg9ZxTUxOCnw2fLl7S5g3CnJZyJcJQYK rkW5LskC76Uz/LEXcRaFrvEYCmA46f8EyGyW1KfyYvzl6dK5yfp5dTD5Cr7LS5X80kpW S+vUmrAqR3pkB+W59aGEgGVFfQlaYlJI0OFuBW1iLtfyYU1fhDoxA/s7NcXiL35+wLl/ 9EeJ0cqPZ7HR9h8/hb5Ey1wgWT2f0bal7kzTyVk/aqoPWreaJOMxVB1w0rKnbpEXp9Vu s6VA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=DDEPN55+; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-200935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200935-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f66acaf22asi45785985ad.425.2024.06.04.08.52.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 08:52:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-200935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=DDEPN55+; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-200935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-200935-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4F6F1B265DE for ; Tue, 4 Jun 2024 15:16:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 68912143C74; Tue, 4 Jun 2024 15:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="DDEPN55+" Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85F0ABE4A; Tue, 4 Jun 2024 15:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717514157; cv=none; b=dm3UcprMa+Xjr6CUsn5sF8BqYKMaqO451ELUHRym0p0152jaHy8ph9FuFViaI7A2UDj/EsjXBtTr6BxH++sGWUfXgeak/ye3TXNypTq0u7jFSEjfwYJcm9FtoDA1e/30qsm3nXlBdt69NWL0tZsXqqY2tDr0km4Lk27CtFOdp64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717514157; c=relaxed/simple; bh=qYbGIfmyW9zgaQj0Mjiwwwvs2RxSuGP4Gkaw6xq7zok=; h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=M6QTxIzwvMyiJYTa0dnS+pBtku+/Il5mV3y7VmHr48wjF6/qu7E+nJP9dr9t+4TWV/v7v5ks5sc7xPDi6Ny7FaTGHDgbf9ocZ1Yh6h2nEkAS//kjycU4nHUE1BPCdICgiOnqBzBBFTfR0vmcd/C3SPUDQRJwxd9EaQzzrMuSY/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=DDEPN55+; arc=none smtp.client-ip=212.227.17.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1717514139; x=1718118939; i=markus.elfring@web.de; bh=IZM81H3ToOd0nFYz+ETE9GqM/ElioJLDbHOzj6vrDdc=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:From: Subject:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=DDEPN55+LLeSvhW42oQd7v++QohEwbLsqRsGIjysRMgB07ROpQg095B6OSgf6Lyy h7LkgH4rc4cy13ocLb/4KmoTVO3qDJwSJDsUqYqLo1kqS4TxSM/4ev79IAJmQeoo1 nfJervAltRKB9O/zNCjprB+Ex2nXuWhmI9k8tXp0ilKDrpemtkAqwDZ7WbSDMNFTB y6S1C+VT+Mvwx86B8VWIufxFQaa04MZ5jBr5VzDXaEBrdFGxzh2G+e5vyzMTryy3d EOh/fBcYu87Yq/3xfl17UVblAkVYCZCkd38V7yHMCvYYgYeT4y0UzMcWTCzAVaqe3 SQliltvFtP11nKMEYg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MN6Fj-1rvbSQ2F4X-00V9Wq; Tue, 04 Jun 2024 17:15:39 +0200 Message-ID: <0fc79fe9-da49-4cbe-a7ff-6443ad93f120@web.de> Date: Tue, 4 Jun 2024 17:15:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: kernel-janitors@vger.kernel.org, Andy Shevchenko , Geert Uytterhoeven , =?UTF-8?Q?Marek_Beh=C3=BAn?= , Miguel Ojeda , Robin van der Gracht Cc: LKML From: Markus Elfring Subject: [PATCH] auxdisplay: ht16k33: Drop device node reference after registration failure in ht16k33_led_probe() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:4Lsg5L4n7WeLu0+owQVBLTAx9hJoe3FKwtwJMJko7SkcACI7w/N UnnlaL5VjNtXJmfKa9xhJAR893ZZ+jLRqLUVt7w/HDbJ5nPxlfBqdt1vz0vFjt7h9GBzHiF DuIvwEbwUM4TcsrxGIobgl/n+8jiKaBWHvESeKgJT7xXfVa3ivOi1mLAg3/8ThkqG7IL1iA BcdytZBCCf375SA0gyWCw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:TLohPM8XQAE=;YculmRcoXr5MdlBnPySciJuvA09 kz4AIvEvSYJ+FzGfJ0VPTlDhqByuXBAq1142MlGTaH6q5cO/Z0HXipqy1JMaelzRKua6+2i50 AABEJZTzrNaStTM5NROSc4lcs+wwDTWC313hKpb06WtAnZri6b0bZNGhgv6LSZ5hDYOp95jaG b7lvBZKlHVX9bfjRwq+1gyxOXQjaLjeo5yoHpNDYM07QeDr8kiptwS0rZh52TXY+PuH4J1NoJ 0baqwHGvMjvhnuMYKw+G3Tq9LkcgElaMtnySj/9aYXO5L3Fmtt9HxZwGRmk0WnI/mLLPYwM71 uo7RoPSVYJqzaFGMtJXq/LXBJibR67QoWg8g837fND2mhMp4LgGd+ZFl8Uf63Z1gh/msm7MWs uH5YXR6SgTJ6nCfFWId25Nh6UuSPO7zlarbPwTB1TMLXwGJZfKSP8rzBNMJvexgQq5Gn7jTzO tQWtQzltj3kMJhW73nzx9G/+vWL6y1ZJLX/QL5/ZbGdCiV1Vg37GJ2nLj272TA9Pp0/VCnlnx X15dPFYaAqLfjn7U+4EoORSI8bWMcXiPOu+I2BuVUyv8I0g53/Pqlf4sjg5SavSOZkbv/wVX7 JBrNPxKWHbUg22ugwy8ewVQijBfTgfpUYwKdjgphZViFNZ2ge+fxThMmhlT3WIApuGz1olAsB +x29jVrXYRB6iQpCnLc/UAKs6kUt7qxVn/aow2wjZlXqQnqt0XERi1PdLtKgFwkhUVgNjQUZv I7e6zkf5uVPKpmUup0VXgpvp2Hedwc3FdvcSCMC1300xC8UWjCD7rH7HPxtIvCrz7x0rcQttP Br+TRMnNJVfmLg8ndvi9K30tnuoJJhEKlNia8piZuBtwg= From: Markus Elfring Date: Tue, 4 Jun 2024 17:02:15 +0200 A failed call of the function =E2=80=9Cdevm_led_classdev_register_ext=E2= =80=9D can be reported. Add a call of the function =E2=80=9Cfwnode_handle_put=E2=80=9D for this er= ror case. Fixes: c223d9c636ed ("auxdisplay: ht16k33: Add LED support") Signed-off-by: Markus Elfring =2D-- drivers/auxdisplay/ht16k33.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index ce987944662c..ef86537c9d83 100644 =2D-- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c @@ -483,8 +483,10 @@ static int ht16k33_led_probe(struct device *dev, stru= ct led_classdev *led, led->max_brightness =3D MAX_BRIGHTNESS; err =3D devm_led_classdev_register_ext(dev, led, &init_data); - if (err) + if (err) { dev_err(dev, "Failed to register LED\n"); + fwnode_handle_put(init_data.fwnode); + } return err; } =2D- 2.45.1