Received-SPF: pass (google.com: domain of linux-kernel+bounces-201014-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240507045450.895430-1-jstultz@google.com> <20240507045450.895430-5-jstultz@google.com>
 <20240604131204.n4njtgo4tpo352ht@airbuntu>
In-Reply-To: <20240604131204.n4njtgo4tpo352ht@airbuntu>
From: John Stultz <jstultz@google.com>
Date: Tue, 4 Jun 2024 08:53:22 -0700
Message-ID: <CANDhNCocJCShaAOzd1sU+O+B3wd+YjXSddcGr2pESx9nfCdH4w@mail.gmail.com>
Subject: Re: [PATCH v10 4/7] sched: Add move_queued_task_locked helper
To: Qais Yousef <qyousef@layalina.io>
Cc: LKML <linux-kernel@vger.kernel.org>, Joel Fernandes <joelaf@google.com>, 
	Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, 
	Juri Lelli <juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>, 
	Dietmar Eggemann <dietmar.eggemann@arm.com>, Valentin Schneider <vschneid@redhat.com>, 
	Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, 
	Zimuzo Ezeozue <zezeozue@google.com>, Youssef Esmat <youssefesmat@google.com>, 
	Mel Gorman <mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>, Will Deacon <will@kernel.org>, 
	Waiman Long <longman@redhat.com>, Boqun Feng <boqun.feng@gmail.com>, 
	"Paul E. McKenney" <paulmck@kernel.org>, Metin Kaya <Metin.Kaya@arm.com>, 
	Xuewen Yan <xuewen.yan94@gmail.com>, K Prateek Nayak <kprateek.nayak@amd.com>, 
	Thomas Gleixner <tglx@linutronix.de>, kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 4, 2024 at 6:12=E2=80=AFAM Qais Yousef <qyousef@layalina.io> wr=
ote:
> On 05/06/24 21:54, John Stultz wrote:
> > From: Connor O'Brien <connoro@google.com>
> >
> > Switch logic that deactivates, sets the task cpu,
> > and reactivates a task on a different rq to use a
> > helper that will be later extended to push entire
> > blocked task chains.
> >
> > This patch was broken out from a larger chain migration
> > patch originally by Connor O'Brien.
...
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index ae50f212775e..2d41ebe200c7 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -3480,5 +3480,16 @@ static inline void init_sched_mm_cid(struct task=
_struct *t) { }
> >
> >  extern u64 avg_vruntime(struct cfs_rq *cfs_rq);
> >  extern int entity_eligible(struct cfs_rq *cfs_rq, struct sched_entity =
*se);
> > +#ifdef CONFIG_SMP
> > +static inline
> > +void move_queued_task_locked(struct rq *rq, struct rq *dst_rq, struct =
task_struct *task)
> > +{
> > +     lockdep_assert_rq_held(rq);
> > +     lockdep_assert_rq_held(dst_rq);
> > +     deactivate_task(rq, task, 0);
> > +     set_task_cpu(task, dst_rq->cpu);
> > +     activate_task(dst_rq, task, 0);
> > +}
> > +#endif
>
> I see this pattern in __migrate_swap_task() and try_steal_cookie(), shoul=
d they
> be converted to?

Ah! Thanks for pointing it out. I'll include that in the next iteration.

> Beside this
>
> Reviewed-by: Qais Yousef <qyousef@layalina.io>

Thank you so much for the review and feedback!
-john