Received: by 2002:a05:6500:1b41:b0:1fb:d597:ff75 with SMTP id cz1csp205317lqb; Tue, 4 Jun 2024 09:01:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUgCblPRpjv9qGuFFOEp6U7ODHlqH5V2E3powojl3pLB/fQQLEgKcyeCWNeezPvT9bLK4Gt7aaQ41BHICbWK29t+r2d7D/xffTFyRjD6Q== X-Google-Smtp-Source: AGHT+IFEX3DAwn+St8g85uAj44KD3w7W7t/yAN2GEarKBPfKfxNcYOaQWYeuMzmqN4Z2LzMnJzdC X-Received: by 2002:a5b:345:0:b0:dfa:c5fc:51e8 with SMTP id 3f1490d57ef6-dfac5fc596emr829640276.16.1717516877891; Tue, 04 Jun 2024 09:01:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717516877; cv=pass; d=google.com; s=arc-20160816; b=xHpTaUdhIcRuwlMYDzW07h3a6M0vSGNasGcj3Ix/JxIffL7Jjp8eJJvFNjWaF/ft1O JETVeXG12HGN2fziD0pnflITbX4CTSLrg4G1SrBbS6uTXZkpfUlturIY1IzH9QjK7gjs o7zkKNvTcaD8p1zneNW+3I8vmVz7umsZHwuZ+M+IEqFPqVXEESPOw0qWSpuTQ67srymY bBeOI+WrO1ufoESnTPJRr0K8028MEyQkLlLa7MeBfako/TWdXnQ+RQq6c+o6MJTuaMOB 0+glNl/akBcHCcAV4894zydu67pgnK1VdbEWisBEhYt85JIJC3nU6vG7849fFRcTP6Pt Z2+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=iNLJKAhoau3QXq4yfsQV/TfaTIyyOeXiqLeTuKJEEsI=; fh=PvNVbttQ7thZL6HPsfq3d6ih5IOCA3FWzIC1+jIQGkE=; b=pePdMxbnLOkQTbAH1PC6z+OQxn+SB6a40gSnLSHhwcevJre7GwRkBX1ZABtnSQzhlp UNSYb9EKj1IYbLAPWs/8K+Hvw7mnFEVZ9Pm8YOzbUPGdH+RbG6hWLr56eIThnPzzR3Bx TooKbS2InMGG7peCMOOnqpg35WvLTH6z5q7OCyQsPCKd1JBBGXTZi3YD+U2DIFAEszas sDdGuyZ/WmM3z5NXynQ6sBn9BvCpz8yRCdWt3KoJKcd5Lpg6HlCbexFqXzO8HUoGaU0j w8YdBFtnrpL1NW88OupFY6FdhgU0LM43Su+tmwWlOc9Mj8ftWeyeW9eMmmOsng480g4N T9jQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HpwwDhn7; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-201022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201022-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 3f1490d57ef6-dfa822e5396si4540630276.645.2024.06.04.09.01.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 09:01:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-201022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HpwwDhn7; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-201022-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-201022-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 865A31C2434D for ; Tue, 4 Jun 2024 16:01:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 017A8146D6E; Tue, 4 Jun 2024 16:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HpwwDhn7" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB8D1420C9 for ; Tue, 4 Jun 2024 16:01:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717516864; cv=none; b=Z3bhAn6fo38tl3s2RZ8tTThKI9u3IP/+i0n4STrtsz0mVWb4hmScUabYH4Z+YH8Fj+k0J2hsHu40H05+GQExq9FPKJshLoa2mgYrVrV3PlBxuikohXzviKlPQVP7CW//aC6qkpeA3HkGGGULNPszGhoG8/Tn/vcBhsYUKvUNHL4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717516864; c=relaxed/simple; bh=cearPzUutPsAMGH1Y6EdkHOgarYAuOPoDbddxCp4K44=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y8cjoxxgdkIKiZKeU8fe7kaFyiqqezP4jxtF9OYcbxqaJH2OIHBR1EapyiID1qlySBBLYA+8mQPKXWeTAiX4S3RB8bXCZp+nXHvKETBM4FeTBV9GdmZTiW0k93WM1aAZO+mTMlVPQsXzix7c6yeCDIu2GTmNtUJGNbc2BHsMhrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HpwwDhn7; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717516862; x=1749052862; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=cearPzUutPsAMGH1Y6EdkHOgarYAuOPoDbddxCp4K44=; b=HpwwDhn7S2nM7LbikrUrZSBjm92hhtgY2iRYz6h8vbDPxHoP7n1qQVKy 5iUzUIvX4IqY75gLn9BsxmYCW9YNiA59n32FMb9pYblf6F4teMOeDMD15 fFYKALfMRuPJaqPJ/M71hUnfuVnxULK9JHZE7n+hXK5/LlXjr8JrBeVfZ Bb3DibK3bD4q0vlaEwIpI4mHKZI44Tq9MSY0+Z7YotvlLWut0+4ZfCOAb p+UmmvpP2FMQnNxUYmqalX3P7QVjNTfjMDupVceJm/p95RBgXHigpcsoX 8P5QMcxc67JVM4EMx0nPqa1uVsQMHTBZqxYrJqgpTXVypVMdhcoHUUpLb w==; X-CSE-ConnectionGUID: GXvnw0QkS/a1tlZxjnIz3g== X-CSE-MsgGUID: fytc5eYHT6+IV+F8zpHNZw== X-IronPort-AV: E=McAfee;i="6600,9927,11093"; a="14207007" X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="14207007" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 09:01:01 -0700 X-CSE-ConnectionGUID: nye2neQtRJSZaJn3uapRtA== X-CSE-MsgGUID: 5W+Z/73WSKuecZp17OX15Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="37362374" Received: from cdpresto-mobl2.amr.corp.intel.com.amr.corp.intel.com (HELO [10.125.108.218]) ([10.125.108.218]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 09:01:00 -0700 Message-ID: <3f15814c-de9c-4aa6-b56d-82761bb6520a@intel.com> Date: Tue, 4 Jun 2024 09:00:59 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] x86/entry: Remove unwanted instrumentation in common_interrupt() To: Dmitry Vyukov , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org Cc: linux-kernel@vger.kernel.org, syzkaller@googlegroups.com, elver@google.com, glider@google.com, nogikh@google.com, tarasmadan@google.com, Peter Zijlstra References: <1ada3be307bbd076c4ea63530cf445e7fbd0e4e7.1717507310.git.dvyukov@google.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <1ada3be307bbd076c4ea63530cf445e7fbd0e4e7.1717507310.git.dvyukov@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/4/24 06:45, Dmitry Vyukov wrote: > The manifestation is that KCOV produces spurious coverage > in kvm_set_cpu_l1tf_flush_l1d() in random places because > the call happens when preempt count is not yet updated > to say that we are in an interrupt. > > Mark kvm_set_cpu_l1tf_flush_l1d() as __always_inline and move > out of instrumentation_begin/end() section. > It only calls __this_cpu_write() which is already safe to call > in noinstr contexts. I've internalized the main rules around noinstr to basically be: Only call noinstr functions before begin_instrumentation(). Second, try to minimize the amount of noinstr code. This patch seems to be adding another rule which is that all code before preempt_count manipulation needs to be noinstr. _Is_ that a new rule, or was it something I was missing?