Received-SPF: pass (google.com: domain of linux-kernel+bounces-201018-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <5b4155c9-35d4-499e-9256-148b3ed7a491@amd.com>
Date: Tue, 4 Jun 2024 10:56:40 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cpufreq: amd-pstate: add check for cpufreq_cpu_get's
 return value
To: Anastasia Belova <abelova@astralinux.ru>, Huang Rui <ray.huang@amd.com>
Cc: "Gautham R. Shenoy" <gautham.shenoy@amd.com>,
 Perry Yuan <perry.yuan@amd.com>, "Rafael J. Wysocki" <rafael@kernel.org>,
 Viresh Kumar <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
References: <20240603110741.24818-1-abelova@astralinux.ru>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240603110741.24818-1-abelova@astralinux.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RW91RGlDVDZTR2o3ZVJyemlvQmxwNXFGRDZiem84dGpGZE0rM2lJVDIvQ0hp?=
 =?utf-8?B?Slp0ZHJkOGlJY3UySzZBQkZucU1nclRYUkYzOW0yN3lsbVN4c0E1U2RaWW0r?=
 =?utf-8?B?a1cvYWNHMXIwNlVwdW5VRDR2R1NqN2Y5eWNJcFYxaU9yR1UrWTFpTEU0bHNz?=
 =?utf-8?B?bDJWdnhCalM1Z3plYU1uTStWN2x5YWRGVmtTZ1M1MmFTdkZMY0VqZDVEKy90?=
 =?utf-8?B?Wjc3K1FOTzUzbHVBQjJSKzBYYkdyMWRUdDRKSUIzTFJMSmNwQWMvV1k5cCsz?=
 =?utf-8?B?U3ZkdnlIKzRuRHlFcTc2RW5xVnVGYWllVTRvQU5VV0lEVjNrdW8rNnJpWEYx?=
 =?utf-8?B?UFZtTmo3Z1NCMEY0OFZuMTg1OWZkY2ZVWHdoVE10dldNdXIxTlVkTnBCd3dr?=
 =?utf-8?B?anp5bW9Mc1RMaHlobUxra2I4UWlYcmZJK0FVRXpjV2lMbEJhZTR3ajRRRXJp?=
 =?utf-8?B?TmtVTDdHbzB3ZFFSZFhCYUo4UkhiUGdYaFBwM3hhSjFvRzFrN01vR3g2ZG9O?=
 =?utf-8?B?a3Q4WEFHRlZDMGtBdi9UUmZabDZ0cmZoV1VHcmM0WVhkNzAxSUFSdWlzYXA2?=
 =?utf-8?B?OHNmTmRTOEVQRkpLNncwMUFXbzRuekhERW1oOWhENHZHa0syMURqVUxnRUxx?=
 =?utf-8?B?cWJPSEZseTQ5cHlDWk1ZNVlFZW0zRzdMQmlYWGlhcEdTbFFRWTRWVDVLYkRu?=
 =?utf-8?B?NWtUdVM3b0JtczdKdEFXVnhmelVUKzhoVE40U1JrS3JpaGR6Sks1TXU4NFZx?=
 =?utf-8?B?TXR4VjVnQ1RiYzF0NXRNeUh3MlZEM3p6SDlPSitraTdiRjJ4UC9TclIrYkps?=
 =?utf-8?B?WVdndUxhS0libG1Jajd0MHBaS2c1b1RweXBjcXVHN1FZazIyc3hRSERqUGFS?=
 =?utf-8?B?MTR2SHk4dG9HM1FjelhLVnFFcFFSbWh3bGZXTGFjZy9JbjlzUk8rd01WNk95?=
 =?utf-8?B?clpxSFR5cmlqSWozQmh3Q1ZXUm5XS0hKdXcyQWNDSG5qNlRCRmlva2xMMVJC?=
 =?utf-8?B?Sml5SjA2elZhelBQdVo1M1lhaisxaEx3UnliQnhvNjdYdU5EQkFNcHI3ZDVz?=
 =?utf-8?B?ZFpiZnUrTGcrK0JjYWF1OE9sTGJmQWxGRFJqQk5DeTR5MEQxZWUvbi9xcVN1?=
 =?utf-8?B?V0NrTzFNY3RDanViSU1CWDBIODNhdFRGMXA1dVBscUxxNmNRYWtYQnBtVkw2?=
 =?utf-8?B?dlo4dHJNVVl2TkpQTXlNbERHb0t2ODNmNGhVbERtNEkrazJabnFQQ1hvV1pi?=
 =?utf-8?B?amZuemdwaURjR0t4eHhpYjMyZkdXTzdkU2N0MnhFZWJET3UrdnlZaEM0THE2?=
 =?utf-8?B?WmUxSjU5UDF5ek9IM1A2OUZKelhxRXFtaWxZd05rRDEwS2NSL1pIQlJ5VU9D?=
 =?utf-8?B?SXhqU3l2SEU3TG5ScVQrQU9YVkhRRC9COU1wMTJ2OHNaRVVCZE1tcTZhNS9M?=
 =?utf-8?B?SEN4SGFNOWNPclBPeGZoeHpqUDZrMWNaUFA2UXZDWUdTeDRwRDh1bjRJdFEy?=
 =?utf-8?B?T0lBU01YNUZDOEFtR3ZlMWNobjgyR0NPbk1SN3pnRTNDRWVQQ1k1d0lvbGRV?=
 =?utf-8?B?by9XSlgyT3dpVjhaZGhPVGhDVTRsd0VIZmlSRHhGYmZQUlZjL283Y2dHdWFF?=
 =?utf-8?B?RGR1cFBJZk90RERnUThpTDlQdG5UODV2d20xdVBJcUJidUZYY2JXL3hxRisx?=
 =?utf-8?B?Y1diazk2K0NLcHRkNmxaRGVVaFE0cisvRi90VXlsOE5xTFFhcHpMbVE5Qi80?=
 =?utf-8?B?R0hsaUc4OFpzQVpVN0NmS2xnWEZsZW9ldlMwOTMyMlphWXUxT2dQLzZwdS80?=
 =?utf-8?B?aWcxTy85ajJiT1J3eXJ1VllTbjBRQ1FzVVJ5ZktCdmMrS1FYSXdxN0xrbkFH?=
 =?utf-8?B?dDhXK1daS1lZdDFNOTBMWWlCeFAxTXFBNmd2YmVNUHJkb2twKzltWGFjYUdL?=
 =?utf-8?B?MjVrbmlUQUQzY3lQcFl2TFcxY2dUd0lFRnRZUnU2WjYyMzZrZTkwZW9TNXk2?=
 =?utf-8?B?T2ZpYmJrZ0krQ0NwWXVGR21IQ1BKSThyR0xrWjhiaHJ0QzYzQk9vSksvS1hr?=
 =?utf-8?B?MTRGWEh4VmJWL2lSeThMWGc1dVJ6dzF5Mk9uMTR0clR1RGFQTVcrWVphNDNq?=
 =?utf-8?Q?L4/0h4x68KiX8mb0FJIvutyun?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32300e11-b5f3-42f9-3aaf-08dc84aefad0
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 15:57:04.8379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fdhhKqLDzO1EgwgY5MevrlSyMrl/vWvgyevPvGYyJg983YgC6+dHtjhAeI2m4ez+DJiGwM6XKdwlJSwWxc2skQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4036

On 6/3/2024 06:07, Anastasia Belova wrote:
> cpufreq_cpu_get may return NULL. To avoid NULL-dereference check it
> and return in case of error.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
Thank you!

Acked-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/cpufreq/amd-pstate.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 1b7e82a0ad2e..672cb6c280a4 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -621,6 +621,8 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
>   	unsigned long max_perf, min_perf, des_perf,
>   		      cap_perf, lowest_nonlinear_perf, max_freq;
>   	struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
> +	if (!policy)
> +		return;
>   	struct amd_cpudata *cpudata = policy->driver_data;
>   	unsigned int target_freq;
>   
> @@ -777,6 +779,8 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata)
>   static void amd_pstate_update_limits(unsigned int cpu)
>   {
>   	struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
> +	if (!policy)
> +		return;
>   	struct amd_cpudata *cpudata = policy->driver_data;
>   	u32 prev_high = 0, cur_high = 0;
>   	int ret;