Received-SPF: pass (google.com: domain of linux-kernel+bounces-200968-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <459ef672-82c8-abcd-5c7a-5c1b4db7e1e3@quicinc.com>
Date: Tue, 4 Jun 2024 09:36:45 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] Documentation/accel/qaic: Fix typo
Content-Language: en-US
To: Danish Prakash <contact@danishpraka.sh>
CC: Shuah Khan <skhan@linuxfoundation.org>,
        Carl Vanderlip
	<quic_carlv@quicinc.com>,
        Pranjal Ramajor Asha Kanojiya
	<quic_pkanojiy@quicinc.com>,
        Oded Gabbay <ogabbay@kernel.org>, "Jonathan
 Corbet" <corbet@lwn.net>,
        "open list:QUALCOMM CLOUD AI (QAIC) DRIVER"
	<linux-arm-msm@vger.kernel.org>,
        "open list:QUALCOMM CLOUD AI (QAIC) DRIVER"
	<dri-devel@lists.freedesktop.org>,
        "open list:DOCUMENTATION"
	<linux-doc@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <16b1bcb5-00c6-4b59-a880-188bed32d175@linuxfoundation.org>
 <20240601145216.32232-1-contact@danishpraka.sh>
From: Jeffrey Hugo <quic_jhugo@quicinc.com>
In-Reply-To: <20240601145216.32232-1-contact@danishpraka.sh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

For future reference, since this is the second revision of this change, 
the subject should have "[PATCH v2]".

On 6/1/2024 8:51 AM, Danish Prakash wrote:
> Fixed a typo in the docs where 'phsyical' > was corrected to 'physical'.

Commit text should be in the present simple tense.  You currently are 
using past tense here.  "Fixed" -> "Fix", etc.

> Signed-off-by: Danish Prakash <contact@danishpraka.sh>
> ---

Since this is a single change and not a series, you should have a change 
log here which identifies what is different in this revision.

>   Documentation/accel/qaic/qaic.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/accel/qaic/qaic.rst b/Documentation/accel/qaic/qaic.rst
> index efb7771273bb..628bf2f7a416 100644
> --- a/Documentation/accel/qaic/qaic.rst
> +++ b/Documentation/accel/qaic/qaic.rst
> @@ -93,7 +93,7 @@ commands (does not impact QAIC).
>   uAPI
>   ====
>   
> -QAIC creates an accel device per phsyical PCIe device. This accel device exists
> +QAIC creates an accel device per physical PCIe device. This accel device exists
>   for as long as the PCIe device is known to Linux.
>   
>   The PCIe device may not be in the state to accept requests from userspace at