Received-SPF: pass (google.com: domain of linux-kernel+bounces-201072-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <99c5b19c-a8a3-484d-9adb-b313c57bc1f7@amd.com>
Date: Tue, 4 Jun 2024 11:28:57 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] crypto: ccp - Fix null pointer dereference in
 __sev_snp_shutdown_locked
Content-Language: en-US
To: Kim Phillips <kim.phillips@amd.com>, Ashish Kalra <ashish.kalra@amd.com>,
 John Allen <john.allen@amd.com>, Herbert Xu <herbert@gondor.apana.org.au>,
 "David S . Miller" <davem@davemloft.net>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
 linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
 stable@vger.kernel.org
References: <20240603151212.18342-1-kim.phillips@amd.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240603151212.18342-1-kim.phillips@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3o2aEZ3S280aG5Jb3ovbE9xaUhsaWV2UHNHbTJGaFkwVjFRekcySWpDVlNL?=
 =?utf-8?B?NmlvVFJkbmtqRDhIa0luVnZvNzVlaUh6WTNHbGZpZlFHS2hNeG5NckVSSmpC?=
 =?utf-8?B?TnRvL3Y2dnBZN0V6Z1BKeTcwbHVXYXRXMFVSK2Izb1RsNXNtM21tV1JyTnlF?=
 =?utf-8?B?Mnd0YitrOWhhOE9VMTVCSk9YUVR6QTNneHVnQm52dytxUkJOcjREYnR1Rmpt?=
 =?utf-8?B?aW43MFpCZUlaaTVPbVA2T3ZvOUxMa3BaRXErRmhoQ1JndnJHbHA5ODhBc0ZP?=
 =?utf-8?B?ZUFXTm43V3ZUMFE5d01WN3ZyYllxVWVzMHZWdlNUREZ2eWcwV1Ryd2diRytO?=
 =?utf-8?B?cFFRUjdWa21uck1SOXNNOFhxOTlhbFllQnpaN3JaNU1DdTU3emI2dVhxdTYz?=
 =?utf-8?B?U1pZdk9TUVBWZkUvelNsbkZJTHQ1U2tyNEtsVjBCY3JnVHNCNytmNzBpMVlH?=
 =?utf-8?B?ZUpVL2MzM3hBUXdBb3J6UWhxZVRlTDlIMHI3RUw1VnNBeWFORFJROUJYdUZ0?=
 =?utf-8?B?c0NwRUNwNHh5Q3FORVpXdzlhSDJ4MkV2QWFwNTNocVRqYzVYMzEwVDRSMWVV?=
 =?utf-8?B?NllGVDRIRDhpcmRmOEpoWDlmQmdXazg5WGpKM1VzQ1dnUFFXVmF0R1R0NmxJ?=
 =?utf-8?B?MElJZTZRZlc4c0pKYUlwSXVFZGNsRTdkbHZOMVZ1OWEzRjMxRGFDUjF5RkR6?=
 =?utf-8?B?cEMzeDBJV2xsQUtrUHN1c0diZG5Kd1poeDY2MzVMc0hTTlhMQlBrQUg2QTVt?=
 =?utf-8?B?bExRdHNzUWtyaHRWOVM4OHpZTWIybHUwSnJNNkhTQlpQb2lzQlhoMERJc0Jh?=
 =?utf-8?B?eGVrbFhFR0FtSXBwYk96a0N1d2lOcG53WWhHTHRpS20vNHpDTDFDRDRza2t3?=
 =?utf-8?B?dmlMbWZrRzJpSVdLT0JsazBhZXh3R0oxTlpoYmQ0dXdpbjdzU2JVR3V0WjNm?=
 =?utf-8?B?bzQvMm9IVWg0R3FJRmQvQytKWEp6cng1QkNjSVh4bVczUzduVkFtenRNc2dp?=
 =?utf-8?B?M0pmQ08vSWlCeldDWkNWbllDZHRFS2ZvWVlDNHFrYVJveTNnZTRLTlVyeUZo?=
 =?utf-8?B?VVg2K0RIcVExQXZvak84VmdHZFpNNkE2Y3pGcnJSZ3orNHo1clhYTkZENUZO?=
 =?utf-8?B?OWFEdFJYNDVxMzVxWStRUTVsRTFzNjY3RTJzZzZwbXVTL3hOejloSnVPTFEx?=
 =?utf-8?B?aExLZGQvc1hySW9kS2RhR0RoSjBHWTYzN04rRnpURzhZMmtIeTJPVWZrME15?=
 =?utf-8?B?WnE4YUlTQ2s1UUQ4dmFTak44WW9ZTFpWeTdkdkhkcmZBV09URnowNmVXemhq?=
 =?utf-8?B?SjVtWWlzZ3RJYjJmTytkRVFTcUVpTTFPcyt1bkZLaXBJdFYwckpFaEt4Nm55?=
 =?utf-8?B?eHcvY280cys4NjZqL1I3RlAwa3RWVDFOOTJBN0xVU0d2M09rTS9ncU11bHFs?=
 =?utf-8?B?bnlLaFVaYnVOV2VYRU51QVkzUm5DbmxORXhZL0liWk5zRUxtM1A1am56NFZa?=
 =?utf-8?B?SWp2bENwZ21uMXEwRE85QUF3aXZBRGJBVWpMMFRoTnFtS05hRWZJN2RsZEZX?=
 =?utf-8?B?VzNncGtWdkxUbzI0KzBlZVplYnJONkNvRFNBOHJSU3MyNm1UR09SQnBOdUdS?=
 =?utf-8?B?TndaR1g5T21rRVdCRDVDVEZldml0OURJYzE5RkRnUW96eVYvS0Ura2hSM2JN?=
 =?utf-8?B?SGFUR2ZqVXBaQnJIWmM4TkhZOXFhWHVONjBnT2NJOEUzSlNpdFFXdkZIUU42?=
 =?utf-8?B?b3haVzE2Y0haTXFIcm1iK0hjS2IvZWR5bDJXcjhkN2lmUG16b2dWKzR6ekxo?=
 =?utf-8?B?MUhEMDI5VTl0K0tkZ3hZL1d3Q1B1clkwUjJLS0x3cS8vRFY0eEhRZmhERDgz?=
 =?utf-8?B?L0hUdUVBd0x2bHlOYmZEZURSenpWd01DWEgwK25mRFArZWljdFpqMGFXYUVn?=
 =?utf-8?B?NGUzS1VVQUt5UzM4UnU1OFBicW9SVStTNitIemNwSmVNM3QyQmd4cHBhUy9L?=
 =?utf-8?B?S3Y2NGxhemVzdStMWEFGYkMwdlFtWnVRcVdYUFl5SzFtcWQ5NTNBM2JuSSsw?=
 =?utf-8?B?N21xQlV4UEVnKzdtMjVENFI0d0VrNEFVcFpKTklCQ2R6OTdnM1VwVmNDdkJK?=
 =?utf-8?Q?56U5cuK6iNn+OdlWhiRri0ZCM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc9a16d4-c3f3-482f-76d0-08dc84b3704b
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 16:28:59.9098
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LI2tzFONU11fT951QEb2AVlvKQfqWNkeeTxEsktDa/P36jHiys4hFwvW5IU7LONSXa7jlDLOjdWFtrjOyIa7Lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7309

On 6/3/24 10:12, Kim Phillips wrote:
> Another DEBUG_TEST_DRIVER_REMOVE induced splat found, this time
> in __sev_snp_shutdown_locked().
> 

> 
> Fixes: ccb88e9549e7 ("crypto: ccp - Fix null pointer dereference in __sev_platform_shutdown_locked")

Shouldn't the Fixes tag be:

1ca5614b84ee ("crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP")

Thanks,
Tom

> Cc: stable@vger.kernel.org
> Signed-off-by: Kim Phillips <kim.phillips@amd.com>
> ---
>   drivers/crypto/ccp/sev-dev.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>