Received-SPF: pass (google.com: domain of linux-kernel+bounces-201081-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 4 Jun 2024 19:33:31 +0300
From: Andy Shevchenko <andy@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>,
	Miguel Ojeda <ojeda@kernel.org>,
	Robin van der Gracht <robin@protonic.nl>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] auxdisplay: ht16k33: Drop device node reference after
 registration failure in ht16k33_led_probe()
Message-ID: <Zl9B2zqbJqVAf83d@smile.fi.intel.com>
References: <0fc79fe9-da49-4cbe-a7ff-6443ad93f120@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0fc79fe9-da49-4cbe-a7ff-6443ad93f120@web.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Tue, Jun 04, 2024 at 05:15:37PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 4 Jun 2024 17:02:15 +0200
> 
> A failed call of the function “devm_led_classdev_register_ext”
> can be reported.
> Add a call of the function “fwnode_handle_put” for this error case.

Replace double quotes by parentheses, so the reference to the functions
will look like func().

...

>  	err = devm_led_classdev_register_ext(dev, led, &init_data);
> -	if (err)
> +	if (err) {
>  		dev_err(dev, "Failed to register LED\n");
> +		fwnode_handle_put(init_data.fwnode);
> +	}

There are two issues with this approach:
1) there is the same issue in ->remove(), isn't it?
2) it potentially might mess up the ordering if any other devm call happens
   in beetween.

But, by design we don't use reference counting after we registered LED, hence
both error and successful paths need to have this, so add another
fwnode_handle_put() after this branch.

-- 
With Best Regards,
Andy Shevchenko